| Message ID | 20240326095457.201572-2-chunhau.tan@starfivetech.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add JH8100 support for snps,dw-axi-dmac | expand |
On Tue, Mar 26, 2024 at 02:54:56AM -0700, Tan Chun Hau wrote: > Add support for StarFive JH8100 SoC in Sysnopsys Designware AXI DMA > controller. Your commit message should explain what makes this incompatible with existing devices. That inforatiion does appear to be in the driver patch, but should also be here. Otherwise, Acked-by: Conor Dooley <conor.dooley@microchip.com> > > Signed-off-by: Tan Chun Hau <chunhau.tan@starfivetech.com> > --- > Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml > index 363cf8bd150d..525f5f3932f5 100644 > --- a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml > +++ b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml > @@ -21,6 +21,7 @@ properties: > - snps,axi-dma-1.01a > - intel,kmb-axi-dma > - starfive,jh7110-axi-dma > + - starfive,jh8100-axi-dma > > reg: > minItems: 1 > -- > 2.25.1 >
> -----Original Message----- > From: Conor Dooley <conor@kernel.org> > Sent: Wednesday, 27 March, 2024 2:33 AM > To: ChunHau Tan <chunhau.tan@starfivetech.com> > Cc: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>; Vinod Koul > <vkoul@kernel.org>; Rob Herring <robh@kernel.org>; Krzysztof Kozlowski > <krzysztof.kozlowski+dt@linaro.org>; Conor Dooley <conor+dt@kernel.org>; > Leyfoon Tan <leyfoon.tan@starfivetech.com>; JeeHeng Sia > <jeeheng.sia@starfivetech.com>; dmaengine@vger.kernel.org; > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH 1/2] dt-bindings: dma: snps,dw-axi-dmac: Add JH8100 > support > > On Tue, Mar 26, 2024 at 02:54:56AM -0700, Tan Chun Hau wrote: > > Add support for StarFive JH8100 SoC in Sysnopsys Designware AXI DMA > > controller. > > Your commit message should explain what makes this incompatible with existing > devices. That inforatiion does appear to be in the driver patch, but should also be > here. Otherwise, > Acked-by: Conor Dooley <conor.dooley@microchip.com> Okay, thank you for the feedback. > > > > > Signed-off-by: Tan Chun Hau <chunhau.tan@starfivetech.com> > > --- > > Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git > > a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml > > b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml > > index 363cf8bd150d..525f5f3932f5 100644 > > --- a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml > > +++ b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml > > @@ -21,6 +21,7 @@ properties: > > - snps,axi-dma-1.01a > > - intel,kmb-axi-dma > > - starfive,jh7110-axi-dma > > + - starfive,jh8100-axi-dma > > > > reg: > > minItems: 1 > > -- > > 2.25.1 > >
diff --git a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml index 363cf8bd150d..525f5f3932f5 100644 --- a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml +++ b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml @@ -21,6 +21,7 @@ properties: - snps,axi-dma-1.01a - intel,kmb-axi-dma - starfive,jh7110-axi-dma + - starfive,jh8100-axi-dma reg: minItems: 1
Add support for StarFive JH8100 SoC in Sysnopsys Designware AXI DMA controller. Signed-off-by: Tan Chun Hau <chunhau.tan@starfivetech.com> --- Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml | 1 + 1 file changed, 1 insertion(+)