| Message ID | 20240403024932.3342606-1-nichen@iscas.ac.cn (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 2b1c1cf08a0addb6df42f16b37133dc7a351de29 |
| Headers | show |
| Series | dmaengine: idma64: Add check for dma_set_max_seg_size | expand |
On Wed, Apr 03, 2024 at 02:49:32AM +0000, Chen Ni wrote: > As the possible failure of the dma_set_max_seg_size(), it should be > better to check the return value of the dma_set_max_seg_size(). OK. Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
On Wed, 03 Apr 2024 02:49:32 +0000, Chen Ni wrote: > As the possible failure of the dma_set_max_seg_size(), it should be > better to check the return value of the dma_set_max_seg_size(). > > Applied, thanks! [1/1] dmaengine: idma64: Add check for dma_set_max_seg_size commit: 2b1c1cf08a0addb6df42f16b37133dc7a351de29 Best regards,
diff --git a/drivers/dma/idma64.c b/drivers/dma/idma64.c index 78a938969d7d..58ac374efa3b 100644 --- a/drivers/dma/idma64.c +++ b/drivers/dma/idma64.c @@ -594,7 +594,9 @@ static int idma64_probe(struct idma64_chip *chip) idma64->dma.dev = chip->sysdev; - dma_set_max_seg_size(idma64->dma.dev, IDMA64C_CTLH_BLOCK_TS_MASK); + ret = dma_set_max_seg_size(idma64->dma.dev, IDMA64C_CTLH_BLOCK_TS_MASK); + if (ret) + return ret; ret = dma_async_device_register(&idma64->dma); if (ret)
As the possible failure of the dma_set_max_seg_size(), it should be better to check the return value of the dma_set_max_seg_size(). Fixes: e3fdb1894cfa ("dmaengine: idma64: set maximum allowed segment size for DMA") Signed-off-by: Chen Ni <nichen@iscas.ac.cn> --- drivers/dma/idma64.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)