| Message ID | 20240627221217.713633-1-Frank.Li@nxp.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [1/1] dt-bindings: fsl-qdma: fix interrupts 'if' check logic | expand |
On 28/06/2024 00:12, Frank Li wrote: > All compatible string include 'fsl,ls1021a-qdma'. Previous if check are > always true. > > if: > properties: > compatible: > contains: > enum: > - fsl,ls1021a-qdma > > Change to check other compatible strings to get correct logic and fix > below CHECK_DTB warnings. > > arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var1.dtb: > dma-controller@8380000: interrupts: [[0, 43, 4], [0, 251, 4], [0, 252, 4], [0, 253, 4], [0, 254, 4]] is too long > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- > Documentation/devicetree/bindings/dma/fsl-qdma.yaml | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/dma/fsl-qdma.yaml b/Documentation/devicetree/bindings/dma/fsl-qdma.yaml > index 25e410a149fce..48dcf1d1f25ce 100644 > --- a/Documentation/devicetree/bindings/dma/fsl-qdma.yaml > +++ b/Documentation/devicetree/bindings/dma/fsl-qdma.yaml > @@ -92,8 +92,16 @@ allOf: > compatible: > contains: > enum: > - - fsl,ls1021a-qdma > + - fsl,ls1028a-qdma > + - fsl,ls1043a-qdma > + - fsl,ls1046a-qdma > then: > + properties: > + interrupts: You need here minItems: 5 (that's a new dtschema requirement) > + maxItems: 5 > + interrupt-names: You need here minItems: 5 > + maxItems: 5 > + else: > properties: > interrupts: > maxItems: 3 Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/dma/fsl-qdma.yaml b/Documentation/devicetree/bindings/dma/fsl-qdma.yaml index 25e410a149fce..48dcf1d1f25ce 100644 --- a/Documentation/devicetree/bindings/dma/fsl-qdma.yaml +++ b/Documentation/devicetree/bindings/dma/fsl-qdma.yaml @@ -92,8 +92,16 @@ allOf: compatible: contains: enum: - - fsl,ls1021a-qdma + - fsl,ls1028a-qdma + - fsl,ls1043a-qdma + - fsl,ls1046a-qdma then: + properties: + interrupts: + maxItems: 5 + interrupt-names: + maxItems: 5 + else: properties: interrupts: maxItems: 3
All compatible string include 'fsl,ls1021a-qdma'. Previous if check are always true. if: properties: compatible: contains: enum: - fsl,ls1021a-qdma Change to check other compatible strings to get correct logic and fix below CHECK_DTB warnings. arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var1.dtb: dma-controller@8380000: interrupts: [[0, 43, 4], [0, 251, 4], [0, 252, 4], [0, 253, 4], [0, 254, 4]] is too long Signed-off-by: Frank Li <Frank.Li@nxp.com> --- Documentation/devicetree/bindings/dma/fsl-qdma.yaml | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)