diff mbox series

[v2] dt-bindings: dma: fsl,imx-dma: Document the DMA clocks

Message ID 20240807170517.64290-1-festevam@gmail.com (mailing list archive)
State Accepted
Commit 2ccf4822683336f027a5c9f12cb2468e329125d9
Headers show
Series [v2] dt-bindings: dma: fsl,imx-dma: Document the DMA clocks | expand

Commit Message

Fabio Estevam Aug. 7, 2024, 5:05 p.m. UTC 
From: Fabio Estevam <festevam@denx.de>

Document the IPG and AHB clocks that are needed by the DMA hardware
as required properties.

It is not possible to have DMA functional without the DMA clocks
being turned on.

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
Changes since v1:
- Mark clock and clock-names as required properties (Conor).

 .../devicetree/bindings/dma/fsl,imx-dma.yaml       | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

Comments

Conor Dooley Aug. 7, 2024, 5:23 p.m. UTC | #1 
On Wed, Aug 07, 2024 at 02:05:17PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> Document the IPG and AHB clocks that are needed by the DMA hardware
> as required properties.
> 
> It is not possible to have DMA functional without the DMA clocks
> being turned on.
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
> Changes since v1:
> - Mark clock and clock-names as required properties (Conor).

Acked-by: Conor Dooley <conor.dooley@microchip.com>
Vinod Koul Aug. 29, 2024, 5:30 p.m. UTC | #2 
On Wed, 07 Aug 2024 14:05:17 -0300, Fabio Estevam wrote:
> Document the IPG and AHB clocks that are needed by the DMA hardware
> as required properties.
> 
> It is not possible to have DMA functional without the DMA clocks
> being turned on.
> 
> 
> [...]

Applied, thanks!

[1/1] dt-bindings: dma: fsl,imx-dma: Document the DMA clocks
      commit: 2ccf4822683336f027a5c9f12cb2468e329125d9

Best regards,
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/dma/fsl,imx-dma.yaml b/Documentation/devicetree/bindings/dma/fsl,imx-dma.yaml
index 902a11f65be2..75957f9fb58b 100644
--- a/Documentation/devicetree/bindings/dma/fsl,imx-dma.yaml
+++ b/Documentation/devicetree/bindings/dma/fsl,imx-dma.yaml
@@ -28,6 +28,14 @@  properties:
       - description: DMA Error interrupt
     minItems: 1
 
+  clocks:
+    maxItems: 2
+
+  clock-names:
+    items:
+      - const: ipg
+      - const: ahb
+
   "#dma-cells":
     const: 1
 
@@ -42,15 +50,21 @@  required:
   - reg
   - interrupts
   - "#dma-cells"
+  - clocks
+  - clock-names
 
 additionalProperties: false
 
 examples:
   - |
+    #include <dt-bindings/clock/imx27-clock.h>
+
     dma-controller@10001000 {
       compatible = "fsl,imx27-dma";
       reg = <0x10001000 0x1000>;
       interrupts = <32 33>;
       #dma-cells = <1>;
       dma-channels = <16>;
+      clocks = <&clks IMX27_CLK_DMA_IPG_GATE>, <&clks IMX27_CLK_DMA_AHB_GATE>;
+      clock-names = "ipg", "ahb";
     };