| Message ID | 20240819193641.600176-1-harshit.m.mogalapalli@oracle.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | dmaengine: xilinx: xdma: Fix IS_ERR() vs NULL bug in xdma_probe() | expand |
It looks a dup of https://lore.kernel.org/dmaengine/CALYqZ9=pVRtSY=w4hG0R3HEM_Y=bpLba2_jRcvcZX4eLX5Yw-A@mail.gmail.com/ Thanks, Lizhi On 8/19/24 12:36, Harshit Mogalapalli wrote: > devm_regmap_init_mmio() returns error pointers on error, it doesn't > return NULL. Update the error check. > > Fixes: 17ce252266c7 ("dmaengine: xilinx: xdma: Add xilinx xdma driver") > Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> > --- > This is based on static analysis with smatch, only compile tested. > --- > drivers/dma/xilinx/xdma.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/dma/xilinx/xdma.c b/drivers/dma/xilinx/xdma.c > index 718842fdaf98..44fae351f0a0 100644 > --- a/drivers/dma/xilinx/xdma.c > +++ b/drivers/dma/xilinx/xdma.c > @@ -1240,7 +1240,8 @@ static int xdma_probe(struct platform_device *pdev) > > xdev->rmap = devm_regmap_init_mmio(&pdev->dev, reg_base, > &xdma_regmap_config); > - if (!xdev->rmap) { > + if (IS_ERR(xdev->rmap)) { > + ret = PTR_ERR(xdev->rmap); > xdma_err(xdev, "config regmap failed: %d", ret); > goto failed; > }
On Mon, Aug 19, 2024 at 01:11:34PM -0700, Lizhi Hou wrote: > > It looks a dup of > > https://lore.kernel.org/dmaengine/CALYqZ9=pVRtSY=w4hG0R3HEM_Y=bpLba2_jRcvcZX4eLX5Yw-A@mail.gmail.com/ > That patch was sent in May. It was sent in an unusable format but no one responded to it so it was never fixed. :/ Eric, please read the first two paragraphs of Documentation/process/email-clients.rst. I suggest we add merge this patch but with Eric as a Reported-by. regards, dan carpenter
On 8/19/24 12:36, Harshit Mogalapalli wrote: > devm_regmap_init_mmio() returns error pointers on error, it doesn't > return NULL. Update the error check. > > Fixes: 17ce252266c7 ("dmaengine: xilinx: xdma: Add xilinx xdma driver") > Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> > --- > This is based on static analysis with smatch, only compile tested. > --- > drivers/dma/xilinx/xdma.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/dma/xilinx/xdma.c b/drivers/dma/xilinx/xdma.c > index 718842fdaf98..44fae351f0a0 100644 > --- a/drivers/dma/xilinx/xdma.c > +++ b/drivers/dma/xilinx/xdma.c > @@ -1240,7 +1240,8 @@ static int xdma_probe(struct platform_device *pdev) > > xdev->rmap = devm_regmap_init_mmio(&pdev->dev, reg_base, > &xdma_regmap_config); > - if (!xdev->rmap) { > + if (IS_ERR(xdev->rmap)) { > + ret = PTR_ERR(xdev->rmap); Reviewed-by: Lizhi Hou <lizhi.hou@amd.com> > xdma_err(xdev, "config regmap failed: %d", ret); > goto failed; > }
diff --git a/drivers/dma/xilinx/xdma.c b/drivers/dma/xilinx/xdma.c index 718842fdaf98..44fae351f0a0 100644 --- a/drivers/dma/xilinx/xdma.c +++ b/drivers/dma/xilinx/xdma.c @@ -1240,7 +1240,8 @@ static int xdma_probe(struct platform_device *pdev) xdev->rmap = devm_regmap_init_mmio(&pdev->dev, reg_base, &xdma_regmap_config); - if (!xdev->rmap) { + if (IS_ERR(xdev->rmap)) { + ret = PTR_ERR(xdev->rmap); xdma_err(xdev, "config regmap failed: %d", ret); goto failed; }
devm_regmap_init_mmio() returns error pointers on error, it doesn't return NULL. Update the error check. Fixes: 17ce252266c7 ("dmaengine: xilinx: xdma: Add xilinx xdma driver") Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> --- This is based on static analysis with smatch, only compile tested. --- drivers/dma/xilinx/xdma.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)