| Message ID | 20240829092418.2863659-2-quic_msavaliy@quicinc.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Enable shared SE support over I2C | expand |
On 29/08/2024 10:24, Mukesh Kumar Savaliya wrote: > Adds qcom,shared-se flag usage. Use this when particular I2C serial > controller needs to be shared between two subsystems. > > Signed-off-by: Mukesh Kumar Savaliya <quic_msavaliy@quicinc.com> > --- > Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml > index 9f66a3bb1f80..ae423127f736 100644 > --- a/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml > +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml > @@ -60,6 +60,10 @@ properties: > power-domains: > maxItems: 1 > > + qcom,shared-se: > + description: True if I2C needs to be shared between two or more subsystems. > + type: boolean > + > reg: > maxItems: 1 > SE = shared execution ? --- bod
On 29/08/2024 10:58, Bryan O'Donoghue wrote: > On 29/08/2024 10:24, Mukesh Kumar Savaliya wrote: >> Adds qcom,shared-se flag usage. Use this when particular I2C serial >> controller needs to be shared between two subsystems. >> >> Signed-off-by: Mukesh Kumar Savaliya <quic_msavaliy@quicinc.com> >> --- >> Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git >> a/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml >> b/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml >> index 9f66a3bb1f80..ae423127f736 100644 >> --- a/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml >> +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml >> @@ -60,6 +60,10 @@ properties: >> power-domains: >> maxItems: 1 >> + qcom,shared-se: >> + description: True if I2C needs to be shared between two or more >> subsystems. >> + type: boolean >> + >> reg: >> maxItems: 1 > > SE = shared execution ? > > --- > bod > Serial Engines This is a good example of defining TLAs commit eddac5af06546d2e7a0730e3dc02dde3dc91098a Author: Karthikeyan Ramasubramanian <kramasub@codeaurora.org> Date: Fri Mar 30 11:08:17 2018 -0600 soc: qcom: Add GENI based QUP Wrapper driver This driver manages the Generic Interface (GENI) firmware based Qualcomm Universal Peripheral (QUP) Wrapper. GENI based QUP is the next generation programmable module composed of multiple Serial Engines (SE) ...
On 29/08/2024 11:24, Mukesh Kumar Savaliya wrote: > Adds qcom,shared-se flag usage. Use this when particular I2C serial > controller needs to be shared between two subsystems. > > Signed-off-by: Mukesh Kumar Savaliya <quic_msavaliy@quicinc.com> > --- > Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml | 4 ++++ > 1 file changed, 4 insertions(+) <form letter> Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. Tools like b4 or scripts/get_maintainer.pl provide you proper list of people, so fix your workflow. Tools might also fail if you work on some ancient tree (don't, instead use mainline) or work on fork of kernel (don't, instead use mainline). Just use b4 and everything should be fine, although remember about `b4 prep --auto-to-cc` if you added new patches to the patchset. You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time. Please kindly resend and include all necessary To/Cc entries. </form letter> Best regards, Krzysztof
Thanks Krzysztof for the review. On 8/30/2024 1:41 PM, Krzysztof Kozlowski wrote: > On 29/08/2024 11:24, Mukesh Kumar Savaliya wrote: >> Adds qcom,shared-se flag usage. Use this when particular I2C serial >> controller needs to be shared between two subsystems. >> >> Signed-off-by: Mukesh Kumar Savaliya <quic_msavaliy@quicinc.com> >> --- >> Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml | 4 ++++ >> 1 file changed, 4 insertions(+) > > <form letter> > Please use scripts/get_maintainers.pl to get a list of necessary people > and lists to CC. It might happen, that command when run on an older > kernel, gives you outdated entries. Therefore please be sure you base > your patches on recent Linux kernel. > Sorry, i forgot to add list for different SS. I am adding all maintainers and list after running maintainers scripts on each patch. > Tools like b4 or scripts/get_maintainer.pl provide you proper list of > people, so fix your workflow. Tools might also fail if you work on some > ancient tree (don't, instead use mainline) or work on fork of kernel > (don't, instead use mainline). Just use b4 and everything should be > fine, although remember about `b4 prep --auto-to-cc` if you added new > patches to the patchset. > > You missed at least devicetree list (maybe more), so this won't be > tested by automated tooling. Performing review on untested code might be > a waste of time. > You mean flag addition into DTSI file ? If yes, then the intention was to just enable feature support but not into mainline because it should happen per board or usecase. Please suggest if i can enable particular node with DTSI feature flag. Please correct me if my understanding on your ask went wrong. > Please kindly resend and include all necessary To/Cc entries. > </form letter> > > Best regards, > Krzysztof > >
On 04/09/2024 20:12, Mukesh Kumar Savaliya wrote: >> Tools like b4 or scripts/get_maintainer.pl provide you proper list of >> people, so fix your workflow. Tools might also fail if you work on some >> ancient tree (don't, instead use mainline) or work on fork of kernel >> (don't, instead use mainline). Just use b4 and everything should be >> fine, although remember about `b4 prep --auto-to-cc` if you added new >> patches to the patchset. >> >> You missed at least devicetree list (maybe more), so this won't be >> tested by automated tooling. Performing review on untested code might be >> a waste of time. >> > > You mean flag addition into DTSI file ? If yes, then the intention was > to just enable feature support but not into mainline because it should > happen per board or usecase. Please suggest if i can enable particular > node with DTSI feature flag. > Please correct me if my understanding on your ask went wrong. How is this related? Best regards, Krzysztof
On 8/29/2024 3:31 PM, Bryan O'Donoghue wrote: > On 29/08/2024 10:58, Bryan O'Donoghue wrote: >> On 29/08/2024 10:24, Mukesh Kumar Savaliya wrote: >>> Adds qcom,shared-se flag usage. Use this when particular I2C serial >>> controller needs to be shared between two subsystems. >>> >>> Signed-off-by: Mukesh Kumar Savaliya <quic_msavaliy@quicinc.com> >>> --- >>> Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git >>> a/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml >>> b/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml >>> index 9f66a3bb1f80..ae423127f736 100644 >>> --- a/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml >>> +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml >>> @@ -60,6 +60,10 @@ properties: >>> power-domains: >>> maxItems: 1 >>> + qcom,shared-se: >>> + description: True if I2C needs to be shared between two or more >>> subsystems. >>> + type: boolean >>> + >>> reg: >>> maxItems: 1 >> >> SE = shared execution ? >> >> --- >> bod >> > > Serial Engines > Sorry for short name. yes, SE = Serial Engine. I shall mention in brackets in next patch. Noted below TLAs too. > This is a good example of defining TLAs > > commit eddac5af06546d2e7a0730e3dc02dde3dc91098a > Author: Karthikeyan Ramasubramanian <kramasub@codeaurora.org> > Date: Fri Mar 30 11:08:17 2018 -0600 > > soc: qcom: Add GENI based QUP Wrapper driver > > This driver manages the Generic Interface (GENI) firmware based > Qualcomm Universal Peripheral (QUP) Wrapper. GENI based QUP is the > next generation programmable module composed of multiple Serial > Engines (SE) > > ...
Thanks Bryan For reviewing. On 8/29/2024 3:28 PM, Bryan O'Donoghue wrote: > On 29/08/2024 10:24, Mukesh Kumar Savaliya wrote: >> Adds qcom,shared-se flag usage. Use this when particular I2C serial >> controller needs to be shared between two subsystems. >> >> Signed-off-by: Mukesh Kumar Savaliya <quic_msavaliy@quicinc.com> >> --- >> Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml | 4++++ >> 1 file changed, 4 insertions(+) >> >> diff --git >> a/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml >> b/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml >> index 9f66a3bb1f80..ae423127f736 100644 >> --- a/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml >> +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml >> @@ -60,6 +60,10 @@ properties: >> power-domains: >> maxItems: 1 >> + qcom,shared-se: >> + description: True if I2C needs to be shared between two or more >> subsystems. >> + type: boolean >> + >> reg: >> maxItems: 1 > > SE = shared execution ? > Sorry for short name. SE = Serial Engine. I shall mention in bracket in next step. > --- > bod
On 9/4/2024 11:50 PM, Krzysztof Kozlowski wrote: > On 04/09/2024 20:12, Mukesh Kumar Savaliya wrote: >>> Tools like b4 or scripts/get_maintainer.pl provide you proper list of >>> people, so fix your workflow. Tools might also fail if you work on some >>> ancient tree (don't, instead use mainline) or work on fork of kernel >>> (don't, instead use mainline). Just use b4 and everything should be >>> fine, although remember about `b4 prep --auto-to-cc` if you added new >>> patches to the patchset. >>> >>> You missed at least devicetree list (maybe more), so this won't be >>> tested by automated tooling. Performing review on untested code might be >>> a waste of time. >>> >> >> You mean flag addition into DTSI file ? If yes, then the intention was >> to just enable feature support but not into mainline because it should >> happen per board or usecase. Please suggest if i can enable particular >> node with DTSI feature flag. >> Please correct me if my understanding on your ask went wrong. > > How is this related? "You missed at least devicetree list (maybe more)" - Do you mean to say i missed to add DTSI changes OR maintainers for DTSI ? seeking clarity to avoid confusion. > > Best regards, > Krzysztof > >
On 05/09/2024 07:43, Mukesh Kumar Savaliya wrote: > > > On 9/4/2024 11:50 PM, Krzysztof Kozlowski wrote: >> On 04/09/2024 20:12, Mukesh Kumar Savaliya wrote: >>>> Tools like b4 or scripts/get_maintainer.pl provide you proper list of >>>> people, so fix your workflow. Tools might also fail if you work on some >>>> ancient tree (don't, instead use mainline) or work on fork of kernel >>>> (don't, instead use mainline). Just use b4 and everything should be >>>> fine, although remember about `b4 prep --auto-to-cc` if you added new >>>> patches to the patchset. >>>> >>>> You missed at least devicetree list (maybe more), so this won't be >>>> tested by automated tooling. Performing review on untested code might be >>>> a waste of time. >>>> >>> >>> You mean flag addition into DTSI file ? If yes, then the intention was >>> to just enable feature support but not into mainline because it should >>> happen per board or usecase. Please suggest if i can enable particular >>> node with DTSI feature flag. >>> Please correct me if my understanding on your ask went wrong. >> >> How is this related? > "You missed at least devicetree list (maybe more)" - Do you mean to say > i missed to add DTSI changes OR maintainers for DTSI ? seeking clarity > to avoid confusion. You did not CC maintainers and necessary list. I wrote nothing about DTSI. You are expected to use tools, not manually come with some address list. Best regards, Krzysztof
On 9/5/2024 11:51 AM, Krzysztof Kozlowski wrote: > On 05/09/2024 07:43, Mukesh Kumar Savaliya wrote: >> >> >> On 9/4/2024 11:50 PM, Krzysztof Kozlowski wrote: >>> On 04/09/2024 20:12, Mukesh Kumar Savaliya wrote: >>>>> Tools like b4 or scripts/get_maintainer.pl provide you proper list of >>>>> people, so fix your workflow. Tools might also fail if you work on some >>>>> ancient tree (don't, instead use mainline) or work on fork of kernel >>>>> (don't, instead use mainline). Just use b4 and everything should be >>>>> fine, although remember about `b4 prep --auto-to-cc` if you added new >>>>> patches to the patchset. >>>>> >>>>> You missed at least devicetree list (maybe more), so this won't be >>>>> tested by automated tooling. Performing review on untested code might be >>>>> a waste of time. >>>>> >>>> >>>> You mean flag addition into DTSI file ? If yes, then the intention was >>>> to just enable feature support but not into mainline because it should >>>> happen per board or usecase. Please suggest if i can enable particular >>>> node with DTSI feature flag. >>>> Please correct me if my understanding on your ask went wrong. >>> >>> How is this related? >> "You missed at least devicetree list (maybe more)" - Do you mean to say >> i missed to add DTSI changes OR maintainers for DTSI ? seeking clarity >> to avoid confusion. > > You did not CC maintainers and necessary list. I wrote nothing about > DTSI. You are expected to use tools, not manually come with some address > list. > Got it, yes, i missed to add necessary list subsystem wise, sorry. Thanks Krzysztof. > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml index 9f66a3bb1f80..ae423127f736 100644 --- a/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml @@ -60,6 +60,10 @@ properties: power-domains: maxItems: 1 + qcom,shared-se: + description: True if I2C needs to be shared between two or more subsystems. + type: boolean + reg: maxItems: 1
Adds qcom,shared-se flag usage. Use this when particular I2C serial controller needs to be shared between two subsystems. Signed-off-by: Mukesh Kumar Savaliya <quic_msavaliy@quicinc.com> --- Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml | 4 ++++ 1 file changed, 4 insertions(+)