| Message ID | 20250404122114.359087-2-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] dmaengine: sh: Do not enable SH_DMAE_BASE by default during compile testing | expand |
On 4/4/25 3:21 PM, Krzysztof Kozlowski wrote: > Enabling the compile test should not cause automatic enabling of all > drivers. The scope of compile test has changed? These drivers will likely not going to be compile tested from now on in practice on other that the platforms they are used? It gave a piece of mind to know that the code compiles on ppc/x86/etc also or it is no longer important sanity check? > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > drivers/dma/ti/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/dma/ti/Kconfig b/drivers/dma/ti/Kconfig > index 2adc2cca10e9..dbf168146d35 100644 > --- a/drivers/dma/ti/Kconfig > +++ b/drivers/dma/ti/Kconfig > @@ -17,7 +17,7 @@ config TI_EDMA > select DMA_ENGINE > select DMA_VIRTUAL_CHANNELS > select TI_DMA_CROSSBAR if (ARCH_OMAP || COMPILE_TEST) > - default y > + default ARCH_DAVINCI || ARCH_OMAP || ARCH_KEYSTONE > help > Enable support for the TI EDMA (Enhanced DMA) controller. This DMA > engine is found on TI DaVinci, AM33xx, AM43xx, DRA7xx and Keystone 2 > @@ -29,7 +29,7 @@ config DMA_OMAP > select DMA_ENGINE > select DMA_VIRTUAL_CHANNELS > select TI_DMA_CROSSBAR if (SOC_DRA7XX || COMPILE_TEST) > - default y > + default ARCH_OMAP > help > Enable support for the TI sDMA (System DMA or DMA4) controller. This > DMA engine is found on OMAP and DRA7xx parts.
On 06/04/2025 18:08, Péter Ujfalusi wrote: > > > On 4/4/25 3:21 PM, Krzysztof Kozlowski wrote: >> Enabling the compile test should not cause automatic enabling of all >> drivers. > > The scope of compile test has changed? No, it's the same. > These drivers will likely not going to be compile tested from now on in Why? They are. That's why allyesconfig you have. > practice on other that the platforms they are used? > > It gave a piece of mind to know that the code compiles on ppc/x86/etc > also or it is no longer important sanity check? And nothing changes here. They will be compile tested on all these other archs the same as all other arch/soc specific drivers, which do exactly what I am doing here. Best regards, Krzysztof
diff --git a/drivers/dma/ti/Kconfig b/drivers/dma/ti/Kconfig index 2adc2cca10e9..dbf168146d35 100644 --- a/drivers/dma/ti/Kconfig +++ b/drivers/dma/ti/Kconfig @@ -17,7 +17,7 @@ config TI_EDMA select DMA_ENGINE select DMA_VIRTUAL_CHANNELS select TI_DMA_CROSSBAR if (ARCH_OMAP || COMPILE_TEST) - default y + default ARCH_DAVINCI || ARCH_OMAP || ARCH_KEYSTONE help Enable support for the TI EDMA (Enhanced DMA) controller. This DMA engine is found on TI DaVinci, AM33xx, AM43xx, DRA7xx and Keystone 2 @@ -29,7 +29,7 @@ config DMA_OMAP select DMA_ENGINE select DMA_VIRTUAL_CHANNELS select TI_DMA_CROSSBAR if (SOC_DRA7XX || COMPILE_TEST) - default y + default ARCH_OMAP help Enable support for the TI sDMA (System DMA or DMA4) controller. This DMA engine is found on OMAP and DRA7xx parts.
Enabling the compile test should not cause automatic enabling of all drivers. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- drivers/dma/ti/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)