diff mbox series

dmaengine: idxd: Remove unused pointer and macro

Message ID 20250408173829.892317-1-ezulian@redhat.com (mailing list archive)
State New
Headers show
Series dmaengine: idxd: Remove unused pointer and macro | expand

Commit Message

Eder Zulian April 8, 2025, 5:38 p.m. UTC
The pointer 'extern struct kmem_cache *idxd_desc_pool' and the macro
'#define IDXD_ALLOCATED_BATCH_SIZE 128U' were introduced in commit
bfe1d56091c1 ("dmaengine: idxd: Init and probe for Intel data
accelerators") but they were never used.

Signed-off-by: Eder Zulian <ezulian@redhat.com>
---
 drivers/dma/idxd/idxd.h | 2 --
 1 file changed, 2 deletions(-)

Comments

Dave Jiang April 8, 2025, 10:47 p.m. UTC | #1
On 4/8/25 10:38 AM, Eder Zulian wrote:
> The pointer 'extern struct kmem_cache *idxd_desc_pool' and the macro
> '#define IDXD_ALLOCATED_BATCH_SIZE 128U' were introduced in commit
> bfe1d56091c1 ("dmaengine: idxd: Init and probe for Intel data
> accelerators") but they were never used.
> 
> Signed-off-by: Eder Zulian <ezulian@redhat.com>

Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
>  drivers/dma/idxd/idxd.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/dma/idxd/idxd.h b/drivers/dma/idxd/idxd.h
> index 214b8039439f..74e6695881e6 100644
> --- a/drivers/dma/idxd/idxd.h
> +++ b/drivers/dma/idxd/idxd.h
> @@ -19,7 +19,6 @@
>  
>  #define IDXD_DRIVER_VERSION	"1.00"
>  
> -extern struct kmem_cache *idxd_desc_pool;
>  extern bool tc_override;
>  
>  struct idxd_wq;
> @@ -171,7 +170,6 @@ struct idxd_cdev {
>  
>  #define DRIVER_NAME_SIZE		128
>  
> -#define IDXD_ALLOCATED_BATCH_SIZE	128U
>  #define WQ_NAME_SIZE   1024
>  #define WQ_TYPE_SIZE   10
>
diff mbox series

Patch

diff --git a/drivers/dma/idxd/idxd.h b/drivers/dma/idxd/idxd.h
index 214b8039439f..74e6695881e6 100644
--- a/drivers/dma/idxd/idxd.h
+++ b/drivers/dma/idxd/idxd.h
@@ -19,7 +19,6 @@ 
 
 #define IDXD_DRIVER_VERSION	"1.00"
 
-extern struct kmem_cache *idxd_desc_pool;
 extern bool tc_override;
 
 struct idxd_wq;
@@ -171,7 +170,6 @@  struct idxd_cdev {
 
 #define DRIVER_NAME_SIZE		128
 
-#define IDXD_ALLOCATED_BATCH_SIZE	128U
 #define WQ_NAME_SIZE   1024
 #define WQ_TYPE_SIZE   10