From patchwork Thu Apr 10 23:22:36 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marco Felsch X-Patchwork-Id: 14047337 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE5AE2036FC for ; Thu, 10 Apr 2025 23:22:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744327380; cv=none; b=XDoNWdFru0E34qJT2lFQ1SQtdUqSkNbGdJmQ3j8beUPYSnIk1xJcM3UkgH32DCc595Qp0Yw9DHHDFBGOr+ufA79L2DOtGOayoyoLB06pbXewybVTpgTOFTVD92PoqVNfLi8HZRy5o038BGluZGGbfjLs7dvT2SK3B98c5P9HzEA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744327380; c=relaxed/simple; bh=Ag1W4qx4ObWxvU5wIkALiGD3Ap0ZT/8sMDoHafbWzXE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=bnH7ruznE4LdVvbDfNeVOTyBeJyyaWh64zfcWtIlG5g4r0V5pi1g5By7x9rxDksoHQlJ5nrrBsJg/g5iYFDXk52yZyK3/0hqfV4VwxGtltFLt+Kw+K87/LlKEqNezQHGQtmRMUpw66rE5wAqrZy2uH1aI7r2HIxQ50+Xil4GfSE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from dude02.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::28]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1u31EU-0003vb-AG; Fri, 11 Apr 2025 01:22:54 +0200 From: Marco Felsch To: kernel@pengutronix.de, "vkoul@kernel.org, shawnguo@kernel.org, Sascha Hauer" Cc: dmaengine@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 01/10] dmaengine: imx-sdma: drop legacy device_node np check Date: Fri, 11 Apr 2025 01:22:36 +0200 Message-Id: <20250410232247.1434659-2-m.felsch@pengutronix.de> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250410232247.1434659-1-m.felsch@pengutronix.de> References: <20250410232247.1434659-1-m.felsch@pengutronix.de> Precedence: bulk X-Mailing-List: dmaengine@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:1101:1d::28 X-SA-Exim-Mail-From: m.felsch@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: dmaengine@vger.kernel.org The legacy 'if (np)' was required in past where we had pdata and dt. Nowadays the driver binds only to dt platforms. So using a new kernel but still use pdata is not possible, therefore we can drop the legacy 'if' code path. Signed-off-by: Marco Felsch --- drivers/dma/imx-sdma.c | 32 ++++++++++++++------------------ 1 file changed, 14 insertions(+), 18 deletions(-) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index 3449006cd14b..699f0c6b5ae5 100644 --- a/drivers/dma/imx-sdma.c +++ b/drivers/dma/imx-sdma.c @@ -2326,11 +2326,9 @@ static int sdma_probe(struct platform_device *pdev) vchan_init(&sdmac->vc, &sdma->dma_device); } - if (np) { - sdma->iram_pool = of_gen_pool_get(np, "iram", 0); - if (sdma->iram_pool) - dev_info(&pdev->dev, "alloc bd from iram.\n"); - } + sdma->iram_pool = of_gen_pool_get(np, "iram", 0); + if (sdma->iram_pool) + dev_info(&pdev->dev, "alloc bd from iram.\n"); ret = sdma_init(sdma); if (ret) @@ -2370,21 +2368,19 @@ static int sdma_probe(struct platform_device *pdev) goto err_init; } - if (np) { - ret = of_dma_controller_register(np, sdma_xlate, sdma); - if (ret) { - dev_err(&pdev->dev, "failed to register controller\n"); - goto err_register; - } + ret = of_dma_controller_register(np, sdma_xlate, sdma); + if (ret) { + dev_err(&pdev->dev, "failed to register controller\n"); + goto err_register; + } - spba_bus = of_find_compatible_node(NULL, NULL, "fsl,spba-bus"); - ret = of_address_to_resource(spba_bus, 0, &spba_res); - if (!ret) { - sdma->spba_start_addr = spba_res.start; - sdma->spba_end_addr = spba_res.end; - } - of_node_put(spba_bus); + spba_bus = of_find_compatible_node(NULL, NULL, "fsl,spba-bus"); + ret = of_address_to_resource(spba_bus, 0, &spba_res); + if (!ret) { + sdma->spba_start_addr = spba_res.start; + sdma->spba_end_addr = spba_res.end; } + of_node_put(spba_bus); /* * Because that device tree does not encode ROM script address,