| Message ID | 20250410232247.1434659-3-m.felsch@pengutronix.de (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [01/10] dmaengine: imx-sdma: drop legacy device_node np check | expand |
On 25-04-11, Marco Felsch wrote: > We don't need to set the pdev driver data to NULL since the device will > be freed anyways. > > Also drop the tasklet_kill() since this is done by the virt-dma driver > during the vchan_synchronize(). Please ignore this patch, I had issues with my mail setup. Regards, Marco
diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index 699f0c6b5ae5..9e634cbc1173 100644 --- a/drivers/dma/imx-sdma.c +++ b/drivers/dma/imx-sdma.c @@ -2424,11 +2424,8 @@ static void sdma_remove(struct platform_device *pdev) for (i = 0; i < MAX_DMA_CHANNELS; i++) { struct sdma_channel *sdmac = &sdma->channel[i]; - tasklet_kill(&sdmac->vc.task); sdma_free_chan_resources(&sdmac->vc.chan); } - - platform_set_drvdata(pdev, NULL); } static struct platform_driver sdma_driver = {
We don't need to set the pdev driver data to NULL since the device will be freed anyways. Also drop the tasklet_kill() since this is done by the virt-dma driver during the vchan_synchronize(). Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> --- drivers/dma/imx-sdma.c | 3 --- 1 file changed, 3 deletions(-)