From patchwork Fri Sep 16 15:09:39 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 9336103 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1A3AC60839 for ; Fri, 16 Sep 2016 15:10:24 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0B921284B3 for ; Fri, 16 Sep 2016 15:10:24 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id F416229837; Fri, 16 Sep 2016 15:10:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 17BC3284B3 for ; Fri, 16 Sep 2016 15:10:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935334AbcIPPKU (ORCPT ); Fri, 16 Sep 2016 11:10:20 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:56663 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754330AbcIPPKR (ORCPT ); Fri, 16 Sep 2016 11:10:17 -0400 Received: from wuerfel.localnet ([78.43.20.153]) by mrelayeu.kundenserver.de (mreue005) with ESMTPSA (Nemesis) id 0MbcdF-1bSYyG2mlp-00IyPg; Fri, 16 Sep 2016 17:09:41 +0200 From: Arnd Bergmann To: Vinod Koul Cc: dmaengine@vger.kernel.org, Jun Nie , Jon Hunter , Krzysztof Kozlowski , M'boumba Cedric Madianga , Zhangfei Gao , Qiao Zhou , Peter Ujfalusi , Russell King , Linus Walleij , Lars-Peter Clausen Subject: Re: [PATCH 00/30] dmaengine: add COMPILE_TEST to drivers Date: Fri, 16 Sep 2016 17:09:39 +0200 Message-ID: <3449722.HEiUokW1P4@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <20160916142034.GB13920@localhost> References: <1473960849-23024-1-git-send-email-vinod.koul@intel.com> <6822072.1Uz5GuSK3z@wuerfel> <20160916142034.GB13920@localhost> MIME-Version: 1.0 X-Provags-ID: V03:K0:BAhmGhZxeQcBXSukCqa5dNHHZcYaTTp7FzS1petuiDtYgFzcgXe 3a60dDHbjBXWnPzn9JCBRHPwys2lfJPpR3bLeIGsBUqjEw6pTNm9mJ6TcsKF0XqZFucejF4 +4jYgCkeibAdYcnAdoNJ8G6Sl7Aw62z9ia7aIunqLTKdrNhHoWoIJM2JmFJhEU3ZzYGUJf0 qNBshvFPYxqGp9NScEd5A== X-UI-Out-Filterresults: notjunk:1; V01:K0:3JRpFO9NdSQ=:f1iLsp6Imz4hefjKfFiZNZ 7Kziq+gMC4Lyk2fr+XMv/tHU7nNCOVk3Ap3PK0FQuo3gSNug5iXbpbxccDuTreJ/pIyiwSTy/ yb8c8SBvdgGqHRjC8au+qp0Pu+r6SyPjlRxBQKskqyUVhv7s87ZC3nnns7SMYmlroHwfDkd2M hEpMT0YsWcvEh00rXkWoYYCRfyWGCxVQ5GJfegDAuS4wq4YQZgxS1CEP6kNGEO+8HEd4PVJcn 5lfXA/aJ864Sghr+M6FaRjQyQKX+lhjOSpIybeNgOcmm2Gc5RcHQpOCmaMFKzUYo19jijiyGK mZBojGjElBrl6StchEvki9JtTXLYlhu6xoTxW67pHwFFDr9C9vbvj8JB7V6uBnAc9N2Ku7ijH eldEtflXTS8ihh8Lt8Ipcaw2x+ON/yTa6YR4smdLbR3QHc6VVCD2hBSDKKCrveYPI9lcwlQ95 RCbL2hcqSZ3sW9XZOxfc/J2wgm4GWkFtcq9ErSN/rFOq3l/iCJ/DtJxDPNz4LMPCJ+7pW/OF6 vHVwsyYPc0GBZAo+Q5fpuYuV2i9h+AYK71jy/MTwoHjG05MnZ0j6OMhVA/DqRD4h9HVIKdz94 0vlf+AChUmExAH+g5VHc35Z8ijAqF4KrTSxz41FpvN29aAezv/U29bBhaoXdxXbuIYFw2TbSQ 5Fj1RHJ/TyOM96tqiRIAoPoFRBEMKWzms7G6lTQrk4FCbr+9n2NljVO3dUtdLNVeWi3HD7Ub0 gMsflxOrWrv2lNXU Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Friday, September 16, 2016 7:50:35 PM CEST Vinod Koul wrote: > On Fri, Sep 16, 2016 at 09:40:55AM +0200, Arnd Bergmann wrote: > > On Thursday, September 15, 2016 11:03:39 PM CEST Vinod Koul wrote: > > > We recently had a conversation about me cribbing that some drivers being > > > hard to compile [1]. Arnd suggested [2] to add COMPILE_TEST to these so > > > right now. With this I have one ARM config which compiles all drivers. > > > > > > I used multi_v7 default config and checked the drivers which are not > > > compiling and starting fixing them. So most of them were pretty fine, few > > > got warning mostly on bad usage of print specifiers with dma_addr_t and > > > size_t being major culprits there and few sparse warnings. > > > > > > While compile testing most of the driver compiled fine on others (i have > > > used ppc, arm, x86_64, i386, mips) expect the two where we explicitly depends > > > on ARM, one is omap and second one is tegra. Jz one had issues but I moved > > > header out of arm, so it worked fine. > > > They have some API dependency, which we should resolve later.. > > > > > > Please test... > > > > > > > Very nice series. If you have a git tree with these patches, I > > can add the branch to my randconfig testing to see if I get > > any build regression on 32-bit ARM. > > I had pushed it my kernel.org tree where Fenguuang's bot found a numbe of > issues, this series is present at: > > git://git.kernel.org/pub/scm/linux/kernel/git/vkoul/slave-dma.git test/compile-fixes > > Please let me know if you find something. > This is what I needed on top I got this warning for the drivers that select DMA_OF, but it's CONFIG_OF is always enabled for those platforms, and that makes DMA_OF enabled as well. Build testing works fine without DMA_OF, so we don't need the 'select' warning: (DMA_SUN4I && MOXART_DMA && STM32_DMA) selects DMA_OF which has unmet direct dependencies (DMADEVICES && OF) Please fold this into your patches as appropriate. Arnd Signed-off-by: Arnd Bergmann --- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig index 00302dfcde95..713c13189926 100644 --- a/drivers/dma/Kconfig +++ b/drivers/dma/Kconfig @@ -151,7 +151,6 @@ config DMA_SUN4I depends on MACH_SUN4I || MACH_SUN5I || MACH_SUN7I default (MACH_SUN4I || MACH_SUN5I || MACH_SUN7I) select DMA_ENGINE - select DMA_OF select DMA_VIRTUAL_CHANNELS help Enable support for the DMA controller present in the sun4i, @@ -307,7 +306,7 @@ config MMP_TDMA bool "MMP Two-Channel DMA support" if COMPILE_TEST && !ARCH_MMP default ARCH_MMP select DMA_ENGINE - select MMP_SRAM + select MMP_SRAM if ARCH_MMP help Support the MMP Two-Channel DMA engine. This engine used for MMP Audio DMA and pxa910 SQU. @@ -317,7 +316,6 @@ config MOXART_DMA tristate "MOXART DMA support" depends on ARCH_MOXART select DMA_ENGINE - select DMA_OF select DMA_VIRTUAL_CHANNELS help Enable support for the MOXA ART SoC DMA controller. @@ -442,7 +440,6 @@ config STM32_DMA bool "STMicroelectronics STM32 DMA support" if COMPILE_TEST && !ARCH_STM32 default ARCH_STM32 select DMA_ENGINE - select DMA_OF select DMA_VIRTUAL_CHANNELS help Enable support for the on-chip DMA controller on STMicroelectronics diff --git a/include/linux/platform_data/dma-mmp_tdma.h b/include/linux/platform_data/dma-mmp_tdma.h index 0c72886030ef..422d4504dbac 100644 --- a/include/linux/platform_data/dma-mmp_tdma.h +++ b/include/linux/platform_data/dma-mmp_tdma.h @@ -28,7 +28,7 @@ struct sram_platdata { int granularity; }; -#ifdef CONFIG_ARM +#ifdef CONFIG_MMP_SRAM extern struct gen_pool *sram_get_gpool(char *pool_name); #else static inline struct gen_pool *sram_get_gpool(char *pool_name)