From patchwork Tue Jan 28 20:45:38 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 3548081 X-Patchwork-Delegate: vinod.koul@intel.com Return-Path: X-Original-To: patchwork-dmaengine@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 2A79BC02DC for ; Tue, 28 Jan 2014 20:45:49 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 4372620170 for ; Tue, 28 Jan 2014 20:45:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 338AC20160 for ; Tue, 28 Jan 2014 20:45:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755519AbaA1Upq (ORCPT ); Tue, 28 Jan 2014 15:45:46 -0500 Received: from moutng.kundenserver.de ([212.227.17.8]:58631 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755326AbaA1Upq (ORCPT ); Tue, 28 Jan 2014 15:45:46 -0500 Received: from wuerfel.localnet (HSI-KBW-085-216-031-165.hsi.kabelbw.de [85.216.31.165]) by mrelayeu.kundenserver.de (node=mreu1) with ESMTP (Nemesis) id 0LrGCe-1V7nW31nbw-013VUS; Tue, 28 Jan 2014 21:45:39 +0100 From: Arnd Bergmann To: linux-kernel@vger.kernel.org Cc: dmaengine@vger.kernel.org, Stephen Warren , Lars-Peter Clausen , Joe Perches , Vinod Koul , Dan Williams , Daniel Mack , Xiang Wang , Zhangfei Gao Subject: [PATCH] dmaengine: mmp_pdma: fix mismerge Date: Tue, 28 Jan 2014 21:45:38 +0100 Message-ID: <3546714.4OTE6dW34L@wuerfel> User-Agent: KMail/4.11 rc1 (Linux/3.10.0-5-generic; KDE/4.11.2; x86_64; ; ) MIME-Version: 1.0 X-Provags-ID: V02:K0:PSX+okaYWkh5bIqMhVFTYR2dql1eNqWS7YGRj/dtuk1 R4udZ7NmPUh19o4NimI8pQDP9RrqzhzYttq6xZI+WPvxL3GR0Y noLiGl7JqjXBtF3g/idh/WV3uJFBLKx21PA/Y6t4mRtRh40oaE T/UXV81yMIw0XVspyvfvGH5moJwOAGNr3F25+boSpanLvDkLRu YYyOUQ+IC/20OsZ8D0lElxuim9F39yxMZ/bSy8dE1dccc/YQck jprmN0u8NcfO7nDqeUt6UscTeIhKQmVp+L7gjxIW80Ysa25N6g TBQrIXwmlZO5b0eBAdrItcmO3sTCHpMa3Z4qXpeIny5UvUB+vm RxGhreBmxmpjbuJNo04A= Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The merge between 2b7f65b11d87f "mmp_pdma: Style neatening" and 8010dad55a0ab0 "dma: add dma_get_any_slave_channel(), for use in of_xlate()" caused a build error by leaving obsolete code in place: mmp_pdma.c: In function 'mmp_pdma_dma_xlate': mmp_pdma.c:909:31: error: 'candidate' undeclared mmp_pdma.c:912:3: error: label 'retry' used but not defined mmp_pdma.c:901:24: warning: unused variable 'c' [-Wunused-variable] This removes the extraneous lines. Signed-off-by: Arnd Bergmann --- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/dma/mmp_pdma.c b/drivers/dma/mmp_pdma.c index 32e58ee..69c6a12 100644 --- a/drivers/dma/mmp_pdma.c +++ b/drivers/dma/mmp_pdma.c @@ -898,19 +898,11 @@ static struct dma_chan *mmp_pdma_dma_xlate(struct of_phandle_args *dma_spec, { struct mmp_pdma_device *d = ofdma->of_dma_data; struct dma_chan *chan; - struct mmp_pdma_chan *c; chan = dma_get_any_slave_channel(&d->device); if (!chan) return NULL; - /* dma_get_slave_channel will return NULL if we lost a race between - * the lookup and the reservation */ - chan = dma_get_slave_channel(candidate); - - if (!chan) - goto retry; - to_mmp_pdma_chan(chan)->drcmr = dma_spec->args[0]; return chan;