diff mbox

[1/2] dt-bindings: dma: Add Spreadtrum SC9860 DMA controller

Message ID 63f2b93b3e484862f736e37d6d422b5566637163.1500361078.git.baolin.wang@spreadtrum.com (mailing list archive)
State Changes Requested
Headers show

Commit Message

Baolin Wang July 18, 2017, 7:06 a.m. UTC
This patch adds the binding documentation for Spreadtrum SC9860 DMA
controller device.

Signed-off-by: Baolin Wang <baolin.wang@spreadtrum.com>
---
 Documentation/devicetree/bindings/dma/sprd-dma.txt |   41 ++++++++++++++++++++
 1 file changed, 41 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/dma/sprd-dma.txt

Comments

Rob Herring (Arm) July 24, 2017, 5:52 p.m. UTC | #1
On Tue, Jul 18, 2017 at 03:06:11PM +0800, Baolin Wang wrote:
> This patch adds the binding documentation for Spreadtrum SC9860 DMA
> controller device.
> 
> Signed-off-by: Baolin Wang <baolin.wang@spreadtrum.com>
> ---
>  Documentation/devicetree/bindings/dma/sprd-dma.txt |   41 ++++++++++++++++++++
>  1 file changed, 41 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/dma/sprd-dma.txt
> 
> diff --git a/Documentation/devicetree/bindings/dma/sprd-dma.txt b/Documentation/devicetree/bindings/dma/sprd-dma.txt
> new file mode 100644
> index 0000000..3ccf776
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/dma/sprd-dma.txt
> @@ -0,0 +1,41 @@
> +* Spreadtrum DMA controller
> +
> +This driver follows the generic DMA bindings defined in dma.txt.

s/driver/binding/

With that,

Acked-by: Rob Herring <robh@kernel.org>
--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
(Exiting) Baolin Wang July 25, 2017, 6:23 a.m. UTC | #2
On 25 July 2017 at 01:52, Rob Herring <robh@kernel.org> wrote:
> On Tue, Jul 18, 2017 at 03:06:11PM +0800, Baolin Wang wrote:
>> This patch adds the binding documentation for Spreadtrum SC9860 DMA
>> controller device.
>>
>> Signed-off-by: Baolin Wang <baolin.wang@spreadtrum.com>
>> ---
>>  Documentation/devicetree/bindings/dma/sprd-dma.txt |   41 ++++++++++++++++++++
>>  1 file changed, 41 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/dma/sprd-dma.txt
>>
>> diff --git a/Documentation/devicetree/bindings/dma/sprd-dma.txt b/Documentation/devicetree/bindings/dma/sprd-dma.txt
>> new file mode 100644
>> index 0000000..3ccf776
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/dma/sprd-dma.txt
>> @@ -0,0 +1,41 @@
>> +* Spreadtrum DMA controller
>> +
>> +This driver follows the generic DMA bindings defined in dma.txt.
>
> s/driver/binding/
>
> With that,
>
> Acked-by: Rob Herring <robh@kernel.org>

Will fix this in next version. Thanks Rob.
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/dma/sprd-dma.txt b/Documentation/devicetree/bindings/dma/sprd-dma.txt
new file mode 100644
index 0000000..3ccf776
--- /dev/null
+++ b/Documentation/devicetree/bindings/dma/sprd-dma.txt
@@ -0,0 +1,41 @@ 
+* Spreadtrum DMA controller
+
+This driver follows the generic DMA bindings defined in dma.txt.
+
+Required properties:
+- compatible: Should be "sprd,sc9860-dma".
+- reg: Should contain DMA registers location and length.
+- interrupts: Should contain one interrupt shared by all channel.
+- #dma-cells: must be <1>. Used to represent the number of integer
+	cells in the dmas property of client device.
+- #dma-channels : Number of DMA channels supported. Should be 32.
+- clock-names: Should contain the clock of the DMA controller.
+- clocks: Should contain a clock specifier for each entry in clock-names.
+
+Example:
+
+Controller:
+apdma: dma-controller@20100000 {
+	compatible = "sprd,sc9860-dma";
+	reg = <0x20100000 0x4000>;
+	interrupts = <GIC_SPI 50 IRQ_TYPE_LEVEL_HIGH>;
+	#dma-cells = <1>;
+	#dma-channels = <32>;
+	clock-names = "enable";
+	clocks = <&clk_ap_ahb_gates 5>;
+};
+
+
+Client:
+DMA clients connected to the Spreadtrum DMA controller must use the format
+described in the dma.txt file, using a two-cell specifier for each channel.
+The two cells in order are:
+1. A phandle pointing to the DMA controller.
+2. The channel id.
+
+spi0: spi@70a00000{
+	...
+	dma-names = "rx_chn", "tx_chn";
+	dmas = <&apdma 11>, <&apdma 12>;
+	...
+};