| Message ID | 87wpwpurzk.wl%kuninori.morimoto.gx@renesas.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
On Fri, Aug 21, 2015 at 05:35:58AM +0000, Kuninori Morimoto wrote: > > Hi Vinod > > ${LINUX}/drivers/dma/of-dma.c will be compiled if .config has DMA_OF > > obj-$(CONFIG_DMA_OF) += of-dma.o > > But, ${LINUX}/include/linux/of_dma.h is based on CONFIG_OF Intially it was OF only and then DMA_OF was added. I think we missed it during the move, so yes your below patch makes sense Can you please send as formal patch for me to apply
Hi Vinod, Mark
Current OF base DMAEngine API will be compiled if .config has
CONFIG_DMA_OF. but of-dma.h based on CONFIG_OF instead of CONFIG_DMA_OF.
These patches tidyup this issue.
Please check 1) patch carefully, since DMAEngine API has many dependency
to other drivers.
> Mark
I think 2) patch is based on 1). Please check it
Kuninori Morimoto (2):
1) dmaengine: OF DMAEngine API based on CONFIG_DMA_OF instead of CONFIG_OF
2) ASoC: rsnd: SND_SOC_RCAR doesn't depend on DMA_OF
include/linux/of_dma.h | 2 +-
sound/soc/sh/Kconfig | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/linux/of_dma.h b/include/linux/of_dma.h index 98ba752..9440622 100644 --- a/include/linux/of_dma.h +++ b/include/linux/of_dma.h @@ -34,7 +34,7 @@ struct of_dma_filter_info { dma_filter_fn filter_fn; }; -#ifdef CONFIG_OF +#ifdef DMA_OF extern int of_dma_controller_register(struct device_node *np, struct dma_chan *(*of_dma_xlate) (struct of_phandle_args *, struct of_dma *),
Hi Vinod ${LINUX}/drivers/dma/of-dma.c will be compiled if .config has DMA_OF obj-$(CONFIG_DMA_OF) += of-dma.o But, ${LINUX}/include/linux/of_dma.h is based on CONFIG_OF #ifdef CONFIG_OF extern int of_dma_controller_register(struct device_node *np, ... #else static inline int of_dma_controller_register(struct device_node *np, ... #endif I have issue if .config has CONFIG_OF but not have DMA_OF. Is this correct patch ? --------------------------------- --------------------------------- Best regards --- Kuninori Morimoto -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html