| Message ID | 902c5769afd77f600c9bef24da0da34f@208suo.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | dma: at_hdmac: "(foo*)" should be "(foo *)" | expand |
On 19-07-23, 16:48, hanyu001@208suo.com wrote: > This patch fixes the checkpatch.pl error: > > ./drivers/dma/at_hdmac.c:1119: ERROR: "(foo*)" should be "(foo *)" > > Signed-off-by: Yu Han <hanyu001@208suo.com> Thanks for the patch, the From for this patch should match the signed-off name, pls fix and resend > --- > drivers/dma/at_hdmac.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c > index ee3a219..af747a7 100644 > --- a/drivers/dma/at_hdmac.c > +++ b/drivers/dma/at_hdmac.c > @@ -1116,7 +1116,7 @@ static int atdma_create_memset_lli(struct dma_chan > *chan, > /* Only the first byte of value is to be used according to dmaengine */ > fill_pattern = (char)value; > > - *(u32*)vaddr = (fill_pattern << 24) | > + *(u32 *)vaddr = (fill_pattern << 24) | > (fill_pattern << 16) | > (fill_pattern << 8) | > fill_pattern;
diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c index ee3a219..af747a7 100644 --- a/drivers/dma/at_hdmac.c +++ b/drivers/dma/at_hdmac.c @@ -1116,7 +1116,7 @@ static int atdma_create_memset_lli(struct dma_chan *chan, /* Only the first byte of value is to be used according to dmaengine */ fill_pattern = (char)value; - *(u32*)vaddr = (fill_pattern << 24) | + *(u32 *)vaddr = (fill_pattern << 24) | (fill_pattern << 16) |
This patch fixes the checkpatch.pl error: ./drivers/dma/at_hdmac.c:1119: ERROR: "(foo*)" should be "(foo *)" Signed-off-by: Yu Han <hanyu001@208suo.com> --- drivers/dma/at_hdmac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (fill_pattern << 8) | fill_pattern;