diff mbox series

[-next] dmaengine: idxd: fix PCI_MSI build errors

Message ID 9dee3f46-70d9-ea75-10cb-5527ab297d1d@infradead.org (mailing list archive)
State Accepted
Headers show
Series [-next] dmaengine: idxd: fix PCI_MSI build errors | expand

Commit Message

Randy Dunlap July 14, 2020, 6:35 a.m. UTC 
From: Randy Dunlap <rdunlap@infradead.org>

Fix build errors when CONFIG_PCI_MSI is not enabled by making the
driver depend on PCI_MSI:

ld: drivers/dma/idxd/device.o: in function `idxd_mask_msix_vector':
device.c:(.text+0x26f): undefined reference to `pci_msi_mask_irq'
ld: drivers/dma/idxd/device.o: in function `idxd_unmask_msix_vector':
device.c:(.text+0x2af): undefined reference to `pci_msi_unmask_irq'

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Dave Jiang <dave.jiang@intel.com>
Cc: dmaengine@vger.kernel.org
Cc: Vinod Koul <vkoul@kernel.org>
---
 drivers/dma/Kconfig |    1 +
 1 file changed, 1 insertion(+)

Comments

Dave Jiang July 14, 2020, 2:58 p.m. UTC | #1 
On 7/13/2020 11:35 PM, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
> 
> Fix build errors when CONFIG_PCI_MSI is not enabled by making the
> driver depend on PCI_MSI:
> 
> ld: drivers/dma/idxd/device.o: in function `idxd_mask_msix_vector':
> device.c:(.text+0x26f): undefined reference to `pci_msi_mask_irq'
> ld: drivers/dma/idxd/device.o: in function `idxd_unmask_msix_vector':
> device.c:(.text+0x2af): undefined reference to `pci_msi_unmask_irq'
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Dave Jiang <dave.jiang@intel.com>
> Cc: dmaengine@vger.kernel.org
> Cc: Vinod Koul <vkoul@kernel.org>

Vinod, I submitted this fix patch last week:
https://patchwork.kernel.org/patch/11649231/

But I think maybe Randy's patch may be more preferable? You can apply this one 
and ignore my submission.

> ---
>   drivers/dma/Kconfig |    1 +
>   1 file changed, 1 insertion(+)
> 
> --- mmotm-2020-0713-1949.orig/drivers/dma/Kconfig
> +++ mmotm-2020-0713-1949/drivers/dma/Kconfig
> @@ -285,6 +285,7 @@ config INTEL_IDMA64
>   config INTEL_IDXD
>   	tristate "Intel Data Accelerators support"
>   	depends on PCI && X86_64
> +	depends on PCI_MSI
>   	depends on SBITMAP
>   	select DMA_ENGINE
>   	help
> 
>
Vinod Koul July 15, 2020, 6:03 a.m. UTC | #2 
On 14-07-20, 07:58, Dave Jiang wrote:
> 
> 
> On 7/13/2020 11:35 PM, Randy Dunlap wrote:
> > From: Randy Dunlap <rdunlap@infradead.org>
> > 
> > Fix build errors when CONFIG_PCI_MSI is not enabled by making the
> > driver depend on PCI_MSI:
> > 
> > ld: drivers/dma/idxd/device.o: in function `idxd_mask_msix_vector':
> > device.c:(.text+0x26f): undefined reference to `pci_msi_mask_irq'
> > ld: drivers/dma/idxd/device.o: in function `idxd_unmask_msix_vector':
> > device.c:(.text+0x2af): undefined reference to `pci_msi_unmask_irq'
> > 
> > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> > Cc: Dave Jiang <dave.jiang@intel.com>
> > Cc: dmaengine@vger.kernel.org
> > Cc: Vinod Koul <vkoul@kernel.org>
> 
> Vinod, I submitted this fix patch last week:
> https://patchwork.kernel.org/patch/11649231/
> 
> But I think maybe Randy's patch may be more preferable? You can apply this
> one and ignore my submission.

Ok, Applied this one, thanks
diff mbox series

Patch

--- mmotm-2020-0713-1949.orig/drivers/dma/Kconfig
+++ mmotm-2020-0713-1949/drivers/dma/Kconfig
@@ -285,6 +285,7 @@  config INTEL_IDMA64
 config INTEL_IDXD
 	tristate "Intel Data Accelerators support"
 	depends on PCI && X86_64
+	depends on PCI_MSI
 	depends on SBITMAP
 	select DMA_ENGINE
 	help