From patchwork Sun Nov 8 07:45:26 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julia Lawall X-Patchwork-Id: 7577281 Return-Path: X-Original-To: patchwork-dmaengine@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 1ED05C05C6 for ; Sun, 8 Nov 2015 07:46:16 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 51000205C1 for ; Sun, 8 Nov 2015 07:46:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6801720532 for ; Sun, 8 Nov 2015 07:46:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751948AbbKHHpb (ORCPT ); Sun, 8 Nov 2015 02:45:31 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:8980 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751709AbbKHHpa (ORCPT ); Sun, 8 Nov 2015 02:45:30 -0500 X-IronPort-AV: E=Sophos;i="5.20,261,1444687200"; d="scan'208";a="186582887" Received: from 203-7.98.82.ozone.net (HELO hadrien.local) ([82.98.7.203]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-SHA; 08 Nov 2015 08:45:27 +0100 Date: Sun, 8 Nov 2015 08:45:26 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Sinan Kaya cc: agross@codeaurora.org, kbuild-all@01.org, dmaengine@vger.kernel.org, timur@codeaurora.org, cov@codeaurora.org, jcm@redhat.com, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sinan Kaya , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Vinod Koul , Dan Williams , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] dma: fix returnvar.cocci warnings Message-ID: User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Remove unneeded variable used to store return value. Generated by: scripts/coccinelle/misc/returnvar.cocci CC: Sinan Kaya Signed-off-by: Fengguang Wu Signed-off-by: Julia Lawall --- hidma_ll.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/drivers/dma/qcom/hidma_ll.c +++ b/drivers/dma/qcom/hidma_ll.c @@ -567,14 +567,13 @@ int hidma_ll_resume(struct hidma_lldev * static int hidma_ll_hw_start(struct hidma_lldev *lldev) { - int rc = 0; unsigned long irqflags; spin_lock_irqsave(&lldev->lock, irqflags); writel(lldev->tre_write_offset, lldev->trca + TRCA_DOORBELL_OFFSET); spin_unlock_irqrestore(&lldev->lock, irqflags); - return rc; + return 0; } bool hidma_ll_isenabled(struct hidma_lldev *lldev) @@ -600,7 +599,6 @@ bool hidma_ll_isenabled(struct hidma_lld int hidma_ll_queue_request(struct hidma_lldev *lldev, u32 tre_ch) { struct hidma_tre *tre; - int rc = 0; unsigned long flags; tre = &lldev->trepool[tre_ch]; @@ -618,7 +616,7 @@ int hidma_ll_queue_request(struct hidma_ lldev->tre_write_offset = (lldev->tre_write_offset + TRE_SIZE) % lldev->tre_ring_size; spin_unlock_irqrestore(&lldev->lock, flags); - return rc; + return 0; } int hidma_ll_start(struct hidma_lldev *lldev)