diff mbox series

dmaengine: milbeaut-hdmac: fix returnvar.cocci warnings

Message ID alpine.DEB.2.21.1909101200570.4379@hadrien (mailing list archive)
State Changes Requested
Headers show
Series dmaengine: milbeaut-hdmac: fix returnvar.cocci warnings | expand

Commit Message

Julia Lawall Sept. 10, 2019, 10:02 a.m. UTC 
From: kbuild test robot <lkp@intel.com>

Remove unneeded variable used to store return value.

Generated by: scripts/coccinelle/misc/returnvar.cocci

Fixes: 7cff81f3886d ("dmaengine: milbeaut-hdmac: Add HDMAC driver for Milbeaut platforms")
CC: Jassi Brar <jaswinder.singh@linaro.org>
Signed-off-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
---

url:    https://github.com/0day-ci/linux/commits/jassisinghbrar-gmail-com/Add-support-for-AHB-DMA-controller-on-Milbeaut-series/20190910-142047
:::::: branch date: 2 hours ago
:::::: commit date: 2 hours ago

Please take the patch only if it's a positive warning. Thanks!

 milbeaut-hdmac.c |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
diff mbox series

Patch

--- a/drivers/dma/milbeaut-hdmac.c
+++ b/drivers/dma/milbeaut-hdmac.c
@@ -171,7 +171,6 @@  static irqreturn_t milbeaut_hdmac_interr
 {
 	struct milbeaut_hdmac_chan *mc = dev_id;
 	struct milbeaut_hdmac_desc *md;
-	irqreturn_t ret = IRQ_HANDLED;
 	u32 val;

 	spin_lock(&mc->vc.lock);
@@ -201,7 +200,7 @@  static irqreturn_t milbeaut_hdmac_interr

 out:
 	spin_unlock(&mc->vc.lock);
-	return ret;
+	return IRQ_HANDLED;
 }

 static void milbeaut_hdmac_free_chan_resources(struct dma_chan *chan)
@@ -289,7 +288,6 @@  static int milbeaut_hdmac_terminate_all(
 	struct virt_dma_chan *vc = to_virt_chan(chan);
 	struct milbeaut_hdmac_chan *mc = to_milbeaut_hdmac_chan(vc);
 	unsigned long flags;
-	int ret = 0;
 	u32 val;

 	LIST_HEAD(head);
@@ -311,7 +309,7 @@  static int milbeaut_hdmac_terminate_all(

 	vchan_dma_desc_free_list(vc, &head);

-	return ret;
+	return 0;
 }

 static void milbeaut_hdmac_synchronize(struct dma_chan *chan)