From patchwork Wed May 17 16:40:47 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 9731587 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B013D615E1 for ; Wed, 17 May 2017 16:41:19 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A2566287D3 for ; Wed, 17 May 2017 16:41:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A103A287F4; Wed, 17 May 2017 16:41:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 836D4287FD for ; Wed, 17 May 2017 16:40:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752995AbdEQQku (ORCPT ); Wed, 17 May 2017 12:40:50 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:58954 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753543AbdEQQkt (ORCPT ); Wed, 17 May 2017 12:40:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: Content-Type:MIME-Version:Date:Message-ID:Cc:Subject:From:To:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=7usl4u1VSYeRWKbD+ipMzAnYY76EzyNFYQ/yYrKx74g=; b=Zpymi6gHAWaBOVgBZSJwP+m5k tuoMLM1AMp9po7Sel0hTPLQ3Ul6NsoZZVfgvwbOglIDJH3nvXnDUxdQC0VLcJpsxtUOIyaDWecdUc TARROPLrr2oi3ciUYgWeWTci0QqRNxs9sAd+VmQ3ocjRUoXj9C+vg3seo7/dd83vYXwQdG8al6gnF 3od6FXwLTqKi4cnaN+ieD9QoYRR+3YNuAe625dknpco8tZRtj5X8nMeqXN9e4PwnynyHL+rETNO/Q tzchpm+EBDCZJIChlFuzBtA9djfN1ih1TW5N9sp7riGykVLCvweqP/klEaQprOmJ2FLLl/cbfNYKq 7WhkqDl/w==; Received: from static-50-53-32-16.bvtn.or.frontiernet.net ([50.53.32.16] helo=[192.168.1.19]) by bombadil.infradead.org with esmtpsa (Exim 4.87 #1 (Red Hat Linux)) id 1dB20F-00087F-MC; Wed, 17 May 2017 16:40:47 +0000 To: LKML , Anup Patel , Vinod Koul From: Randy Dunlap Subject: [PATCH -next] dma: bcm-sba-raid: fix build errors and dependencies Cc: "dmaengine@vger.kernel.org" Message-ID: Date: Wed, 17 May 2017 09:40:47 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 Content-Language: en-US Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Randy Dunlap Fix build errors when COMPILE_TEST is enabled but RAID6_PQ is not enabled (seen on x86_64). drivers/built-in.o: In function `sba_prep_dma_pq_req': (.text+0x16132): undefined reference to `raid6_gflog' drivers/built-in.o: In function `sba_prep_dma_pq_single_req': (.text+0x162f4): undefined reference to `raid6_gflog' This driver needs RAID6_PQ and MAILBOX (from inspection) independent of ARM64 or COMPILE_TEST. However, RAID6_PQ is not defined in any Kconfig file, although it is used in several of them. :( Signed-off-by: Randy Dunlap Cc: Anup Patel Cc: Vinod Koul Cc: dmaengine@vger.kernel.org Acked-by: Bjorn Andersson --- drivers/dma/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- linux-next-20170517.orig/drivers/dma/Kconfig +++ linux-next-20170517/drivers/dma/Kconfig @@ -101,7 +101,8 @@ config AXI_DMAC config BCM_SBA_RAID tristate "Broadcom SBA RAID engine support" - depends on (ARM64 && MAILBOX && RAID6_PQ) || COMPILE_TEST + depends on ARM64 || COMPILE_TEST + depends on MAILBOX && RAID6_PQ select DMA_ENGINE select DMA_ENGINE_RAID select ASYNC_TX_DISABLE_XOR_VAL_DMA