| Message ID | e9e3837a680c9bd2438e4db2b83270c6c052d005.1666640987.git.christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 1b512d5365b202cc3147410ee687c1dac767f6a0 |
| Headers | show |
| Series | dmaengine: mv_xor_v2: Fix a resource leak in mv_xor_v2_remove() | expand |
On 24-10-22, 21:50, Christophe JAILLET wrote: > A clk_prepare_enable() call in the probe is not balanced by a corresponding > clk_disable_unprepare() in the remove function. Applied, thanks
diff --git a/drivers/dma/mv_xor_v2.c b/drivers/dma/mv_xor_v2.c index f629ef6fd3c2..113834e1167b 100644 --- a/drivers/dma/mv_xor_v2.c +++ b/drivers/dma/mv_xor_v2.c @@ -893,6 +893,7 @@ static int mv_xor_v2_remove(struct platform_device *pdev) tasklet_kill(&xor_dev->irq_tasklet); clk_disable_unprepare(xor_dev->clk); + clk_disable_unprepare(xor_dev->reg_clk); return 0; }
A clk_prepare_enable() call in the probe is not balanced by a corresponding clk_disable_unprepare() in the remove function. Add the missing call. Fixes: 3cd2c313f1d6 ("dmaengine: mv_xor_v2: Fix clock resource by adding a register clock") Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- drivers/dma/mv_xor_v2.c | 1 + 1 file changed, 1 insertion(+)