| Message ID | 20190812101149.26036-1-shiju.jose@huawei.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | ACPI: APEI: Add support to notify the vendor specific HW errors | expand |
Hi, On 12/08/2019 11:11, Shiju Jose wrote: > Presently kernel does not support reporting the vendor specific HW errors, > in the non-standard format, to the vendor drivers for the recovery. 'non standard' here is probably a little jarring to the casual reader. You're referring to the UEFI spec's "N.2.3 Non-standard Section Body", which refers to any section type published somewhere other than the UEFI spec. These still have to have a GUID to identify them, so they still have the same section header format. > This patch set add this support and also move the existing handler > functions for the standard errors to the new callback method. Could you give an example of where this would be useful? You're adding an API with no caller to justify its existence. GUIDs should only belong to one driver. I don't think we should call drivers for something described as a fatal error. (which is the case with what you have here) > Also the CCIX RAS patches could be move to the proposed callback method. Presumably for any vendor-specific stuff? Thanks, James
Hi James, Thanks for the feedback. >-----Original Message----- >From: linux-acpi-owner@vger.kernel.org [mailto:linux-acpi- >owner@vger.kernel.org] On Behalf Of James Morse >Sent: 21 August 2019 18:23 >To: Shiju Jose <shiju.jose@huawei.com> >Cc: linux-acpi@vger.kernel.org; linux-edac@vger.kernel.org; linux- >kernel@vger.kernel.org; rjw@rjwysocki.net; lenb@kernel.org; >tony.luck@intel.com; bp@alien8.de; baicar@os.amperecomputing.com; >Linuxarm <linuxarm@huawei.com>; Jonathan Cameron ><jonathan.cameron@huawei.com>; tanxiaofei <tanxiaofei@huawei.com> >Subject: Re: [PATCH RFC 0/4] ACPI: APEI: Add support to notify the vendor >specific HW errors > >Hi, > >On 12/08/2019 11:11, Shiju Jose wrote: >> Presently kernel does not support reporting the vendor specific HW >> errors, in the non-standard format, to the vendor drivers for the recovery. > >'non standard' here is probably a little jarring to the casual reader. You're >referring to the UEFI spec's "N.2.3 Non-standard Section Body", which refers to >any section type published somewhere other than the UEFI spec. OK. I will change it. > >These still have to have a GUID to identify them, so they still have the same >section header format. Yes. > > >> This patch set add this support and also move the existing handler >> functions for the standard errors to the new callback method. > >Could you give an example of where this would be useful? You're adding an API >with no caller to justify its existence. One such example is handling the local errors occurred in a device controller, such as PCIe. > > >GUIDs should only belong to one driver. UEFI spec's N.2.3 Non-standard Section Body mentioned, "The type (e.g. format) of a non-standard section is identified by the GUID populated in the Section Descriptor's Section Type field." There is a possibility to define common non-standard error section format which will be used for more than one driver if the error data to be reported is in the same format. Then can the same GUID belong to multiple drivers? > >I don't think we should call drivers for something described as a fatal error. >(which is the case with what you have here) The notification is intended only for the recoverable errors as the ghes_proc() call panic for the fatal errors in the early stage. > > >> Also the CCIX RAS patches could be move to the proposed callback method. > >Presumably for any vendor-specific stuff? This information was related to the proposal to replace the number of if(guid_equal(...)) else if(guid_equal(...)) checks in the ghes_do_proc() for the existing UEFI spec defined error sections(such as PCIe, Memory, ARM HW error) by registering the corresponding handler functions to the proposed notification method. The same apply to the CCIX error sections and any other error sections defined by the UEFI spec in the future. > > >Thanks, > >James Thanks, Shiju
Hi Shiju, On 22/08/2019 17:56, Shiju Jose wrote: > James Morse wrote: >> On 12/08/2019 11:11, Shiju Jose wrote: >>> Presently kernel does not support reporting the vendor specific HW >>> errors, in the non-standard format, to the vendor drivers for the recovery. >> >> 'non standard' here is probably a little jarring to the casual reader. You're >> referring to the UEFI spec's "N.2.3 Non-standard Section Body", which refers to >> any section type published somewhere other than the UEFI spec. >>> This patch set add this support and also move the existing handler >>> functions for the standard errors to the new callback method. >> >> Could you give an example of where this would be useful? You're adding an API >> with no caller to justify its existence. > One such example is handling the local errors occurred in a device controller, such as PCIe. Could we have the example in the form of patches? (sorry, I wasn't clear) I don't think its realistic that a PCIe device driver would want to know about errors on other devices in the system. (SAS-HBA meet the GPU). PCIe's has AER for handling errors that (may have) occurred on a PCIe link, and this has its own CPER records. >> GUIDs should only belong to one driver. > UEFI spec's N.2.3 Non-standard Section Body mentioned, "The type (e.g. format) of a > non-standard section is identified by the GUID populated in the Section Descriptor's > Section Type field." > There is a possibility to define common non-standard error section format I agree the GUID describes the format of the error record, > which will > be used for more than one driver if the error data to be reported is in the same format. > Then can the same GUID belong to multiple drivers? ... but here we disagree. CPER has a component/block-diagram view of the system. It describes a Memory error or an error with a PCIe endpoint. An error record affects one component. If you wanted to describe an error caused by a failed transaction between a PCIe device and memory, you would need two of these records, and its guesswork as to what happened between them. But the PCIe device has no business poking around in the memory error. Even if it did APEI would be the wrong place to do this as its not the only caller of memory_failure(). >>> Also the CCIX RAS patches could be move to the proposed callback method. >> >> Presumably for any vendor-specific stuff? > This information was related to the proposal to replace the number of if(guid_equal(...)) else > if(guid_equal(...)) checks in the ghes_do_proc() for the existing UEFI spec defined error > sections(such as PCIe, Memory, ARM HW error) 'the standard ones' > by registering the corresponding handler functions to the proposed notification method. I really don't like this. Registering a handler for 'memory corruption' would require walking a list of dynamically allocated pointers. Can there be more than one entry? Can random drivers block memory_failure() while they allocate more memory to send packets over USB? What if it loops? For the standard error sources the kernel needs to run 'the' handler as quickly as possible, with a minimum of code/memory-access in the meantime. It already takes too long. Thanks, James > The same apply to the CCIX error sections and any other > error sections defined by the UEFI spec in the future.
Presently kernel does not support reporting the vendor specific HW errors, in the non-standard format, to the vendor drivers for the recovery. This patch set add this support and also move the existing handler functions for the standard errors to the new callback method. Also the CCIX RAS patches could be move to the proposed callback method. https://www.spinics.net/lists/linux-edac/msg10508.html https://patchwork.kernel.org/patch/10979491/ Shiju Jose (4): ACPI: APEI: Add support to notify the vendor specific HW errors ACPI: APEI: Add ghes_handle_memory_failure to the new notification method ACPI: APEI: Add ghes_handle_aer to the new notification method ACPI: APEI: Add log_arm_hw_error to the new notification method drivers/acpi/apei/ghes.c | 170 +++++++++++++++++++++++++++++++++++++++++------ drivers/ras/ras.c | 5 +- include/acpi/ghes.h | 47 +++++++++++++ include/linux/ras.h | 7 +- 4 files changed, 205 insertions(+), 24 deletions(-)