mbox series

[v4,0/2] Add an API for edac device, for mulriple errors

Message ID 20190923191741.29322-1-hhhawa@amazon.com (mailing list archive)
Headers show
Series Add an API for edac device, for mulriple errors | expand

Message

Hawa, Hanna Sept. 23, 2019, 7:17 p.m. UTC 
Add an API for EDAC device to report for multiple errors, and move the
old report function to use the new API.

Changes from v3:
----------------
- Move count check to inline function
- Fix count variable describtion
  (Reported-by: kbuild test robot <lkp@intel.com>)

Changes from v2:
----------------
- Remove copy of edac_device_handle_*() functions, modify the existing
functions.

Changes from v1:
----------------
- use 'unsigned int' instead of u16
- update variable name to be count
- remove WARN_ON and simply exit if count is zero
- add inline functions in header file

Hanna Hawa (2):
  edac: Add an API for edac device to report for multiple errors
  edac: move edac_device_handle_*() API functions to header

 drivers/edac/edac_device.c | 44 +++++++++++++++++----------------
 drivers/edac/edac_device.h | 50 +++++++++++++++++++++++++++++++++-----
 2 files changed, 67 insertions(+), 27 deletions(-)

Comments

Robert Richter Sept. 24, 2019, 6:33 a.m. UTC | #1 
On 23.09.19 20:17:39, Hanna Hawa wrote:
> Add an API for EDAC device to report for multiple errors, and move the
> old report function to use the new API.
> 
> Changes from v3:
> ----------------
> - Move count check to inline function
> - Fix count variable describtion
>   (Reported-by: kbuild test robot <lkp@intel.com>)

Looks good to me. If another respin happens, please fix the 80 char
limitation for the static inline functions, you could line break after
the type definition.

Thanks,

-Robert