From patchwork Sat Sep 10 19:49:49 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Serge Semin X-Patchwork-Id: 12972627 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A9EEECAAD3 for ; Sat, 10 Sep 2022 19:50:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229516AbiIJTuV (ORCPT ); Sat, 10 Sep 2022 15:50:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52078 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229459AbiIJTuU (ORCPT ); Sat, 10 Sep 2022 15:50:20 -0400 Received: from mail.baikalelectronics.com (mail.baikalelectronics.com [87.245.175.230]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 32EB229C86; Sat, 10 Sep 2022 12:50:19 -0700 (PDT) Received: from mail (mail.baikal.int [192.168.51.25]) by mail.baikalelectronics.com (Postfix) with ESMTP id 1FB2BDA3; Sat, 10 Sep 2022 22:54:09 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.baikalelectronics.com 1FB2BDA3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baikalelectronics.ru; s=mail; t=1662839649; bh=IweD942MZOoOOu0jp63XfXx5pfgiid/lLTQ1w8nMtAA=; h=From:To:CC:Subject:Date:From; b=GM5HEI9skOQnX4tiaB39FSS7wLES1qu9zsdItmUc4NrevXtmw3+4jjIrJWlNE8+O1 mQZATfJ8ZP5nwQOxEkXjC6B2m+ZWWOC0ehJRjV/cGlHQcTW4wKSocAdsn8LzqXBLd1 4UaBTj7kE/G3jdLT4MW2XRtfCnb5vRgw5xdwpbRk= Received: from localhost (192.168.168.10) by mail (192.168.51.25) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Sat, 10 Sep 2022 22:50:18 +0300 From: Serge Semin To: Michal Simek , Borislav Petkov , Mauro Carvalho Chehab , Tony Luck CC: Serge Semin , Serge Semin , Alexey Malahov , Michail Ivanov , Pavel Parkhomenko , Punnaiah Choudary Kalluri , Manish Narani , Dinh Nguyen , James Morse , Robert Richter , , , Subject: [PATCH RESEND v2 00/18] EDAC/synopsys: Add generic DDRC info and address mapping Date: Sat, 10 Sep 2022 22:49:49 +0300 Message-ID: <20220910195007.11027-1-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 X-ClientProxiedBy: MAIL.baikal.int (192.168.51.25) To mail (192.168.51.25) Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org This patchset is a second one in the series created in the framework of my Baikal-T1 DDRC-related work: [1: In-progress] EDAC/mc/synopsys: Various fixes and cleanups Link: https://lore.kernel.org/linux-edac/20220910194237.10142-1-Sergey.Semin@baikalelectronics.ru [2: In-progress] EDAC/synopsys: Add generic DDRC info and address mapping Link: ---you are looking at it--- [3: In-progress] EDAC/synopsys: Add generic resources and Baikal-T1 support Link: https://lore.kernel.org/linux-edac/20220822191957.28546-1-Sergey.Semin@baikalelectronics.ru Note the patchsets above must be merged in the same order as they are placed in the list in order to prevent conflicts. Nothing prevents them from being reviewed synchronously though. Any tests are very welcome. Thanks in advance. The second patchset mainly concerns converting the DW uMCTL2 DDRC driver to being more generic so later it would be extended with our DDR controller support and further with the new DW uMCTL2 DDRC IP-core compilations. The series starts with the Error-injection functionality movement to DebugFS. Indeed the Debug-parts should be in the dedicated DebugFS. SysFS is not a place for it, moreover seeing later we'll add some more debug nodes. Afterwards even though it isn't advertised but even at this stage the DW uMCTL2 DDRC driver supports a bit more DDR protocols than it actually specifies in the mem_ctrl_info.mtype_cap field. So first we suggest to extend the MCI core memory types enumeration with LPDDR (mDDR) and LPDDR2, which support can be enabled in the DW uMCTL2 DDR controller. Second we need to make sure all the possible DDR protocol types are correctly detected during the DW uMCTL DDRC probe procedure. Then a bit painful patch goes. Alas we have to deviate the driver from the EDAC standard private data allocation/initialization pattern. Since we are going to add the DW uMCTL2 IP-core specific parameters detection procedure and later on implement additional platform resources requests there is no other choice but to allocate the driver private data at the early stage of the device probe procedure even before it's possible to allocate the MCI descriptor. The DW uMCTL2 DDRC platform resources and configuration info will be then utilized to properly allocate and initialize the mem_ctrl_info structure instance. Third patch in the series is very important. It provides the DW uMCTL2 DDRC parameters detection procedure. The DDRC and ECC parameters detected at this stage will be then utilized to make the driver working with much wider set of the DW uMCTL2 revisions and configurations. In particular from now the driver will retrieve the next DDRC info at the probe stage: ECC type, SDRAM protocol (DDR type), Full and actual DQ-bus width, SDRAM and HIF burst length, Core/SDRAM frequency ration, number of SDRAM ranks. The DDRC parameters structure will be extended with some more fields later in this and the next patchset. The provided private DDRC parameters infrastructure can be utilized to implement the platform-specific capabilities so the platform data and its quirks are replaced with it. The detected at the probe stage DW uMCTL2 DDRC parameters can be now used to implement the configuration specific functionality. In particular first we introduce the conditional ADDRMAP* CSRs mapping since some of these CSRs and their fields are left unused by the controller in some cases. Secondly actual DIMM ECC errors grain, ECC corrected bit, full data pattern and syndrome are determined based on the DDRC parameters. Afterwards goes a series of the patches which introduce an interface to generically determine the system address based on the SDRAM address and vice-versa. Thus we'll be able to report actual PFN and offset in case of the corrected and uncorrected errors. So first we get to convert the currently available HIF/SDRAM mapping table utilized for the errors-injection functionality into a more generic Sys<->SDRAM address translation interface. Secondly we suggest to conform the SDRAM column address mapping detection algorithm with what is defined in the DW uMCTL2 DDRC hw reference manual. After adding a handy DebugFS node to read the HIF/SDRAM mapping and the system address regions support we finally introduce the erroneous page-frame/offset reporting to the MCI core. Since the full SDRAM address mapping is now always available we suggest to use it for the attached memory size calculation, which is a more correct approach rather than the si_meminfo()-based one. Link: https://lore.kernel.org/linux-edac/20220822191427.27969-1-Sergey.Semin@baikalelectronics.ru Changelog v2: - Rebase onto the latest version of the patchset: [PATCH v2 00/19] EDAC/mc/synopsys: Various fixes and cleanups - Just resend. Signed-off-by: Serge Semin Cc: Alexey Malahov Cc: Michail Ivanov Cc: Pavel Parkhomenko Cc: Punnaiah Choudary Kalluri Cc: Manish Narani Cc: Dinh Nguyen Cc: James Morse Cc: Robert Richter Cc: linux-arm-kernel@lists.infradead.org Cc: linux-edac@vger.kernel.org Cc: linux-kernel@vger.kernel.org Serge Semin (18): EDAC/synopsys: Convert sysfs nodes to debugfs ones EDAC/mc: Extend memtypes with LPDDR(mDDR) and LPDDR2 EDAC/synopsys: Extend memtypes supported by controller EDAC/synopsys: Detach private data from mci instance EDAC/synopsys: Add DDRC basic parameters infrastructure EDAC/synopsys: Convert plat-data to plat-init function EDAC/synopsys: Parse ADDRMAP[7-8] CSRs for (LP)DDR4 only EDAC/synopsys: Parse ADDRMAP[0] CSR for multi-ranks case only EDAC/synopsys: Set actual DIMM ECC errors grain EDAC/synopsys: Get corrected bit position EDAC/synopsys: Read full data pattern on errors EDAC/synopsys: Read data syndrome on errors EDAC/synopsys: Introduce System/SDRAM address translation interface EDAC/synopsys: Simplify HIF/SDRAM column mapping get procedure EDAC/synopsys: Add HIF/SDRAM mapping debugfs node EDAC/synopsys: Add erroneous page-frame/offset reporting EDAC/synopsys: Add system address regions support EDAC/synopsys: Add mapping-based memory size calculation drivers/edac/edac_mc.c | 2 + drivers/edac/synopsys_edac.c | 1772 ++++++++++++++++++++++++---------- include/linux/edac.h | 6 + 3 files changed, 1291 insertions(+), 489 deletions(-)