mbox series

[v1,0/2] Add EDAC driver for loongson memory controller

Message ID 20240821064728.8642-1-zhaoqunqin@loongson.cn (mailing list archive)
Headers show
Series Add EDAC driver for loongson memory controller | expand

Message

Zhao Qunqin Aug. 21, 2024, 6:47 a.m. UTC
From: zhaoqunqin <zhaoqunqin@loongson.cn>

These patchs are based on 6.10.4. Add a simple EDAC driver which report
single bit errors (CE) only on loongson platform.

zhaoqunqin (2):
  Loongarch: EDAC driver for loongson memory controller
  dt-bindings: EDAC for loongson memory controller

 .../bindings/edac/loongson,ls-mc-edac.yaml    |  35 +++
 MAINTAINERS                                   |   7 +
 arch/loongarch/Kconfig                        |   2 +
 drivers/edac/Kconfig                          |  10 +
 drivers/edac/Makefile                         |   1 +
 drivers/edac/loongson_edac.c                  | 208 ++++++++++++++++++
 6 files changed, 263 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/edac/loongson,ls-mc-edac.yaml
 create mode 100644 drivers/edac/loongson_edac.c

Comments

Xi Ruoyao Aug. 21, 2024, 7:01 a.m. UTC | #1
On Wed, 2024-08-21 at 14:47 +0800, Zhao Qunqin wrote:
> These patchs are based on 6.10.4. Add a simple EDAC driver which
> report
> single bit errors (CE) only on loongson platform.
> 
> zhaoqunqin (2):
>   Loongarch: EDAC driver for loongson memory controller
>   dt-bindings: EDAC for loongson memory controller

Hmm so the EDAC driver only works on DT-based systems?  It feels strange
to me.  AFAIK the ECC memory is mostly used in servers where the
firmware passes ACPI system tables instead of DT.

And it makes the incorrect "select EDAC" (I've mentioned in another
reply) worse: all desktop/server users are now building some code
definitely useless on their systems.