| Message ID | 1587624744-97240-1-git-send-email-zou_wei@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [-next] EDAC, thunderx: Make some symbols static | expand |
On Thu, Apr 23, 2020 at 02:52:24PM +0800, Zou Wei wrote: > Fix the following sparse warning: > > drivers/edac/thunderx_edac.c:1281:22: warning: symbol 'ocx_dfs_ents' > was not declared. Should it be static? > drivers/edac/thunderx_edac.c:1922:22: warning: symbol 'l2c_tad_dfs_ents' > was not declared. Should it be static? > drivers/edac/thunderx_edac.c:1928:22: warning: symbol 'l2c_cbc_dfs_ents' > was not declared. Should it be static? > drivers/edac/thunderx_edac.c:1934:22: warning: symbol 'l2c_mci_dfs_ents' > was not declared. Should it be static? > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Zou Wei <zou_wei@huawei.com> > --- > drivers/edac/thunderx_edac.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) Applied, thanks.
diff --git a/drivers/edac/thunderx_edac.c b/drivers/edac/thunderx_edac.c index 34be60f..4af9744 100644 --- a/drivers/edac/thunderx_edac.c +++ b/drivers/edac/thunderx_edac.c @@ -1278,7 +1278,7 @@ OCX_DEBUGFS_ATTR(lne23_badcnt, OCX_LNE_BAD_CNT(23)); OCX_DEBUGFS_ATTR(com_int, OCX_COM_INT_W1S); -struct debugfs_entry *ocx_dfs_ents[] = { +static struct debugfs_entry *ocx_dfs_ents[] = { &debugfs_tlk0_ecc_ctl, &debugfs_tlk1_ecc_ctl, &debugfs_tlk2_ecc_ctl, @@ -1919,19 +1919,19 @@ static irqreturn_t thunderx_l2c_threaded_isr(int irq, void *irq_id) L2C_DEBUGFS_ATTR(tad_int, L2C_TAD_INT_W1S); -struct debugfs_entry *l2c_tad_dfs_ents[] = { +static struct debugfs_entry *l2c_tad_dfs_ents[] = { &debugfs_tad_int, }; L2C_DEBUGFS_ATTR(cbc_int, L2C_CBC_INT_W1S); -struct debugfs_entry *l2c_cbc_dfs_ents[] = { +static struct debugfs_entry *l2c_cbc_dfs_ents[] = { &debugfs_cbc_int, }; L2C_DEBUGFS_ATTR(mci_int, L2C_MCI_INT_W1S); -struct debugfs_entry *l2c_mci_dfs_ents[] = { +static struct debugfs_entry *l2c_mci_dfs_ents[] = { &debugfs_mci_int, };
Fix the following sparse warning: drivers/edac/thunderx_edac.c:1281:22: warning: symbol 'ocx_dfs_ents' was not declared. Should it be static? drivers/edac/thunderx_edac.c:1922:22: warning: symbol 'l2c_tad_dfs_ents' was not declared. Should it be static? drivers/edac/thunderx_edac.c:1928:22: warning: symbol 'l2c_cbc_dfs_ents' was not declared. Should it be static? drivers/edac/thunderx_edac.c:1934:22: warning: symbol 'l2c_mci_dfs_ents' was not declared. Should it be static? Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Zou Wei <zou_wei@huawei.com> --- drivers/edac/thunderx_edac.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)