[v1,1/1] EDAC: (pnd2) Fix the log level for message "Failed to register device with error %d"

Commit Message

[e-mail] March 17, 2020, 6:28 a.m. UTC

From: Amy Shih <[e-mail]>

Fix the log level from "KERN_ERR" to "KERN_INFO" for message "Failed to
register device with error %d", since it is not the error message but
the information to notice the user.

Signed-off-by: Amy Shih <[e-mail]>
---
 drivers/edac/pnd2_edac.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Joe Perches March 20, 2020, 1:54 a.m. UTC | #1

On Tue, 2020-03-17 at 06:28 +0000, [e-mail] wrote:
> From: Amy Shih <[e-mail]>
> 
> Fix the log level from "KERN_ERR" to "KERN_INFO" for message "Failed to
> register device with error %d", since it is not the error message but
> the information to notice the user.
[]
> diff --git a/drivers/edac/pnd2_edac.c b/drivers/edac/pnd2_edac.c
[]
> @@ -1572,7 +1572,8 @@ static int __init pnd2_init(void)
>  
>  	rc = pnd2_probe();
>  	if (rc < 0) {
> -		pnd2_printk(KERN_ERR, "Failed to register device with error %d.\n", rc);
> +		pnd2_printk(KERN_INFO,
> +			    "Failed to register device with error %d.\n", rc);

So there's no need to use the word "error"
in the output message either.

	"Failed to register device - %d\n", rc

would be enough.

Patch

diff --git a/drivers/edac/pnd2_edac.c b/drivers/edac/pnd2_edac.c
index 933f772..f15d3b4 100644
--- a/drivers/edac/pnd2_edac.c
+++ b/drivers/edac/pnd2_edac.c
@@ -1572,7 +1572,8 @@  static int __init pnd2_init(void)
 
 	rc = pnd2_probe();
 	if (rc < 0) {
-		pnd2_printk(KERN_ERR, "Failed to register device with error %d.\n", rc);
+		pnd2_printk(KERN_INFO,
+			    "Failed to register device with error %d.\n", rc);
 		return rc;
 	}