diff mbox series

edac: amd64_edac: remove unneeded break

Message ID 20201019193524.13391-1-trix@redhat.com (mailing list archive)
State New, archived
Headers show
Series edac: amd64_edac: remove unneeded break | expand

Commit Message

Tom Rix Oct. 19, 2020, 7:35 p.m. UTC 
From: Tom Rix <trix@redhat.com>

A break is not needed if it is preceded by a return

Signed-off-by: Tom Rix <trix@redhat.com>
---
 drivers/edac/amd64_edac.c | 8 --------
 1 file changed, 8 deletions(-)

Comments

Robert Richter Oct. 19, 2020, 9:07 p.m. UTC | #1 
On 19.10.20 12:35:24, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
> 
> A break is not needed if it is preceded by a return
> 
> Signed-off-by: Tom Rix <trix@redhat.com>

Reviewed-by: Robert Richter <rric@kernel.org>
Borislav Petkov Oct. 26, 2020, 11:11 a.m. UTC | #2 
On Mon, Oct 19, 2020 at 12:35:24PM -0700, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
> 
> A break is not needed if it is preceded by a return
> 
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>  drivers/edac/amd64_edac.c | 8 --------
>  1 file changed, 8 deletions(-)

Applied, thanks.
diff mbox series

Patch

diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c
index fcc08bbf6945..386a3a4cf279 100644
--- a/drivers/edac/amd64_edac.c
+++ b/drivers/edac/amd64_edac.c
@@ -2461,14 +2461,11 @@  static int map_err_sym_to_channel(int err_sym, int sym_size)
 		case 0x20:
 		case 0x21:
 			return 0;
-			break;
 		case 0x22:
 		case 0x23:
 			return 1;
-			break;
 		default:
 			return err_sym >> 4;
-			break;
 		}
 	/* x8 symbols */
 	else
@@ -2478,17 +2475,12 @@  static int map_err_sym_to_channel(int err_sym, int sym_size)
 			WARN(1, KERN_ERR "Invalid error symbol: 0x%x\n",
 					  err_sym);
 			return -1;
-			break;
-
 		case 0x11:
 			return 0;
-			break;
 		case 0x12:
 			return 1;
-			break;
 		default:
 			return err_sym >> 3;
-			break;
 		}
 	return -1;
 }