From patchwork Wed Jan 26 20:03:52 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergey Shtylyov X-Patchwork-Id: 12725702 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16B63C63684 for ; Wed, 26 Jan 2022 20:04:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229707AbiAZUEA (ORCPT ); Wed, 26 Jan 2022 15:04:00 -0500 Received: from mxout01.lancloud.ru ([45.84.86.81]:37092 "EHLO mxout01.lancloud.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229712AbiAZUEA (ORCPT ); Wed, 26 Jan 2022 15:04:00 -0500 Received: from LanCloud DKIM-Filter: OpenDKIM Filter v2.11.0 mxout01.lancloud.ru A0780209BFBD Received: from LanCloud Received: from LanCloud Received: from LanCloud From: Sergey Shtylyov To: Borislav Petkov , Mauro Carvalho Chehab , Tony Luck , James Morse , Robert Richter , CC: Andre Przywara Subject: [PATCH 4/5] edac: highbank_l2: add IRQ checks Date: Wed, 26 Jan 2022 23:03:52 +0300 Message-ID: <20220126200353.14582-5-s.shtylyov@omp.ru> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20220126200353.14582-1-s.shtylyov@omp.ru> References: <20220126200353.14582-1-s.shtylyov@omp.ru> MIME-Version: 1.0 X-Originating-IP: [192.168.11.198] X-ClientProxiedBy: LFEXT01.lancloud.ru (fd00:f066::141) To LFEX1907.lancloud.ru (fd00:f066::207) Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org The driver neglects to check the result of platform_get_irq()'s calls and blithely passes the negative error codes to devm_request_irq() (which takes *unsigned* IRQ #), causing it to fail with -EINVAL, overriding the original error. Stop calling devm_request_irq() with the invalid IRQ #s. Fixes: 69154d069869 ("edac: add support for Calxeda highbank L2 cache ecc") Signed-off-by: Sergey Shtylyov --- drivers/edac/highbank_l2_edac.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/edac/highbank_l2_edac.c b/drivers/edac/highbank_l2_edac.c index c4549cec788b..e58c84f8e624 100644 --- a/drivers/edac/highbank_l2_edac.c +++ b/drivers/edac/highbank_l2_edac.c @@ -94,6 +94,10 @@ static int highbank_l2_err_probe(struct platform_device *pdev) goto err; drvdata->db_irq = platform_get_irq(pdev, 0); + if (drvdata->db_irq < 0) { + res = drvdata->db_irq; + goto err2; + } res = devm_request_irq(&pdev->dev, drvdata->db_irq, highbank_l2_err_handler, 0, dev_name(&pdev->dev), dci); @@ -101,6 +105,10 @@ static int highbank_l2_err_probe(struct platform_device *pdev) goto err2; drvdata->sb_irq = platform_get_irq(pdev, 1); + if (drvdata->sb_irq < 0) { + res = drvdata->sb_irq; + goto err2; + } res = devm_request_irq(&pdev->dev, drvdata->sb_irq, highbank_l2_err_handler, 0, dev_name(&pdev->dev), dci);