| Message ID | 20220126203503.16759-1-s.shtylyov@omp.ru (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Revert "EDAC/xgene: Do not print a failure message to get an IRQ twice" | expand |
diff --git a/drivers/edac/xgene_edac.c b/drivers/edac/xgene_edac.c index 2ccd1db5e98f..1d2c27a00a4a 100644 --- a/drivers/edac/xgene_edac.c +++ b/drivers/edac/xgene_edac.c @@ -1916,7 +1916,7 @@ static int xgene_edac_probe(struct platform_device *pdev) int i; for (i = 0; i < 3; i++) { - irq = platform_get_irq_optional(pdev, i); + irq = platform_get_irq(pdev, i); if (irq < 0) { dev_err(&pdev->dev, "No IRQ resource\n"); rc = -EINVAL;
This reverts commit e26124cd5f7099949109608845bba9e9bf96599c. Calling platform_get_irq_optional() doesn't make sense if you then bail out on any error it returns. Switch back to calling platform_get_irq(); note that calling dev_err_probe() from there is being discussed currently... Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru> --- This patch is against the 'edac-for-next' branch of the 'ras.git' repo. drivers/edac/xgene_edac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)