diff mbox series

EDAC/versal: Remove a unnecessary check

Message ID 20231024052253.25052-1-shubhrajyoti.datta@amd.com (mailing list archive)
State New, archived
Headers show
Series EDAC/versal: Remove a unnecessary check | expand

Commit Message

Shubhrajyoti Datta Oct. 24, 2023, 5:22 a.m. UTC 
The edac_mc_id is always positive remove an unnecessary failure check.
Fixes Smatch static checker warning:

drivers/edac/versal_edac.c:967 mc_probe()
warn: unsigned 'edac_mc_id' is never less than zero.

Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/all/a4db6f93-8e5f-4d55-a7b8-b5a987d48a58@moroto.mountain/
Fixes: 0fd934580ea3 ("EDAC/versal: Add a Xilinx Versal memory controller driver")
Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>
---

 drivers/edac/versal_edac.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
diff mbox series

Patch

diff --git a/drivers/edac/versal_edac.c b/drivers/edac/versal_edac.c
index 08f630185913..87e730dfefa0 100644
--- a/drivers/edac/versal_edac.c
+++ b/drivers/edac/versal_edac.c
@@ -962,10 +962,8 @@  static int mc_probe(struct platform_device *pdev)
 	if (!get_ecc_state(ddrmc_baseaddr))
 		return -ENXIO;
 
-	/* Allocate ID number for our EMIF controller */
+	/* Allocate ID number for the EMIF controller */
 	edac_mc_id = emif_get_id(pdev->dev.of_node);
-	if (edac_mc_id < 0)
-		return -EINVAL;
 
 	regval = readl(ddrmc_baseaddr + XDDR_REG_CONFIG0_OFFSET);
 	num_chans = FIELD_PREP(XDDR_REG_CONFIG0_NUM_CHANS_MASK, regval);