From patchwork Tue Jul 9 20:23:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 13728459 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2041.outbound.protection.outlook.com [40.107.22.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D3F5187856; Tue, 9 Jul 2024 20:23:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.22.41 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720556627; cv=fail; b=CCCrF6hrgupzHZNCexQQ+Q7tvcD/3NRD3Ptxh18tHtB3FhG4GF+CzcHzU9dq5dUyPZTY5NrkZkiYRnJq7SIWWWj4LVUWEGtc5MQtVKCETt7bL96V42qg8IuAo3GNHKag1GiyqeDUEpF26QjnFF3DAMU1/R2bZRGTLqYi1E9XI3U= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720556627; c=relaxed/simple; bh=w0nRzozlUKzyaSgoCBfno/orQTAg8Z8csRiuGUzusmA=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=HsIcY6SBYdSOMc90J4657q9AEFijViA2ab2h8q0s8+pPkaxi3ZbcsVMbwY2NF7Oxmn+X7JMMRSexcLkswHcGLF9zE6yuyL7XDD/l7GlEdXKFP0ku2eJpYRCbWWiguQrEbkJwAYUVg63ShW+W7QKbPVN4vkh4QEKwlMSFhuWn4uo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b=GxngbnE2; arc=fail smtp.client-ip=40.107.22.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="GxngbnE2" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CRfFcRjES5+NCMe2aNsL1z+KPE9k2BsDOo+1VbA8xLDSeB4yoIeboO971wkmvt8b+fm/zHMvy6I+wmJtBOnQ2Q6TJ1S0CH7QCOwxkJCqlEDx+rfziPJPAh0/LcLeJY9DWyymYZ2Hn/mRpjg1uENxP3tqvx0zciU10itsEQcnPxOgGDF0jFK1v/EvSLRUDvDiSE9HsE+IdC+z/8+iN7VerKY+NMrK4Y6ZwYuIWlfSD31HUc5SVvLwFVmqD2FbZ/xe/XX0vQ0zMXM4o//amfLJgXtaPIZOXmO1OSVWi9YXxSjkS0Rhib9lS41B+el0saPZuU1ia5PwfaunOGU2JmbZ+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UuCZ+qtZuHwlK6whSWPf8p+h6hNNgJzBMctNbfek56A=; b=LpGL42Q2woBPdiAx8Jh54mvgJ8NjCWS8Mxw1HQu2T8fWnkAfdkTlyzj6DJW4omyjBWUA7fco9q7+Lfk0aXseiobvNE8gLKgVJxn1VYjYqzR+ZlrwfFmjBSTiDZBG/bZaf4Kx3T1KwgIkpraEtFy1yH8bN8krnHHCdUV18TL79TDEIxdnX+NgSmXijyBqtxgIZIo6guCzzK5MIVeHzI/BnFeOx/VICX+Mbp0sIfsBqj3fruy5asedfqLSNN8VKVRl0WlBZiIJY6hOs5JgnvYUIWzYnv3trMV+Q3oHR8yjuMnpc/xpMiULNqmL9E/4K2PMgYfJJXRhuFNcmQrpwVLvcA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UuCZ+qtZuHwlK6whSWPf8p+h6hNNgJzBMctNbfek56A=; b=GxngbnE2yRRyl0jdZZGSxkcGHuGqLUtKte4r5PoDh6MLXhTPjW6xoJWxOsjxi9vIGfeufJcXNjGVtR606JQr/Cqidq7EksP9JV/JmCoixq3Np+f1PTFzjuV/80Xrmu3T1nwtZ7xcSTmsVmA/KOGHmZ24GP1f8KAQpe/8S6PTVkA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by DB9PR04MB8267.eurprd04.prod.outlook.com (2603:10a6:10:24b::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7741.35; Tue, 9 Jul 2024 20:23:42 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%2]) with mapi id 15.20.7741.033; Tue, 9 Jul 2024 20:23:42 +0000 From: Frank Li Date: Tue, 09 Jul 2024 16:23:04 -0400 Subject: [PATCH 3/6] EDAC: fsl: Fix bad bit shift operations Message-Id: <20240709-imx95_edac-v1-3-3e9c146c1b01@nxp.com> References: <20240709-imx95_edac-v1-0-3e9c146c1b01@nxp.com> In-Reply-To: <20240709-imx95_edac-v1-0-3e9c146c1b01@nxp.com> To: York Sun , Borislav Petkov , Tony Luck , James Morse , Mauro Carvalho Chehab , Robert Richter , Krzysztof Kozlowski , Rob Herring , Conor Dooley , Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam Cc: linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, Borislav Petkov , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Frank Li , Priyanka Singh , Sherry Sun , Li Yang X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1720556601; l=1758; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=yIBDEMa1tOArl3nH5oE1mzsXvIC+50RpgJfJD2pCSww=; b=puMEO4pwlHPQzAg1IqC+fRj92Cu/EFmnqVMekfg3xaM+mcKdL7bovGBGfwQZKOWQSEJjcHrgM c9UPnlILtDwDBxTuLn+efAGFo38VutXUjDvmdyv8jCf6ck8PKxMiVPz X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: BYAPR03CA0033.namprd03.prod.outlook.com (2603:10b6:a02:a8::46) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: linux-edac@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|DB9PR04MB8267:EE_ X-MS-Office365-Filtering-Correlation-Id: f71cb98d-c8ac-48ad-6511-08dca05506bb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|376014|1800799024|7416014|366016|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?FPcbrqnQSD0XbOjlAKL6VOsaXnrVt/3?= =?utf-8?q?ibsetWhMdlw4LJaQqOdYliq08mRf/pT5N73SSFNrr1RcpJBqxswKJy+3ZwMkMzIVP?= =?utf-8?q?pZA0Vj2IOmdsJ2wglplwLkkFo81w9zTVW6G0baJlIWh/SwRTsyj7vsC5dlV4T58U4?= =?utf-8?q?B2yI7ALgS2yVgG/PlTnY5ZVxBjaFHVIZ2ucXm/m3AAzsMxTZCzgQZ/3OrpURjLdfl?= =?utf-8?q?zplNOLY4BpbZdtPEt9Gl4+IdEZt116fAvbKbkFV4AEUhwx2+j9UG3j56D5A9hTx8r?= =?utf-8?q?drveL21sFJv7ZasMv8mRpUYhiTz2FYj0bNh0QJgZIA86v3E6srHOoR9DRAGk94jib?= =?utf-8?q?CNmWnSLqrukKeK+s+06x6rT9VJytCp1ceqN1DP+Akk3/hRu6cmwbA8F+YagKeqmbp?= =?utf-8?q?naQnHGNCF2VzXBr41PGnlNbdWzFE38V+i/Ma8JuzVm5DSAxPiV+JdeJwb5tJebUnO?= =?utf-8?q?J1H4JMyvIJkEbffm5+oo6ROCl/oxFv1HyvY1dYI2n2dtw8SvE90V5rmWhxLIVIHfU?= =?utf-8?q?Bi7gfLZBgnjes3dQKQRJokT6R6BGvrzlJ38UJ3JFrmISz4zO+Zfi3Enb9dooNMTX6?= =?utf-8?q?n+004iJOjgNQHXANebiNZUhD+V/0QiYiQ32Rge5kQL9qOWKXdXcymjg3wLB+v5Xto?= =?utf-8?q?4pJXCTWu12Nc/D7xxZDQydW0MQQndcA7r+uAidN3sH3+ZIJzV/U8aBkgh1s0ZGYpg?= =?utf-8?q?ir+dobp27V+uezpktvqzh/l5IA4mDtnEzHUyUAT9RTNwsj8JvXInyoIAz4d8OMiEK?= =?utf-8?q?hVlnbSmL8kPoONlMJOuTZvaQ3eL9MC/ZTHzw6EGnndT17LKHj9imvTuX1W7Kf0jD7?= =?utf-8?q?v/EGFxVpQn6OVdohY9W8dDypK27i32TdLTODINMOpdlKcYYwT0lTJ1V99B7EauUrH?= =?utf-8?q?irJXQmt/pCmbtkCba7c5dH4owkGypyIelm0g57aQ8QMVcLsVQgq7PYj7osOhSr+BZ?= =?utf-8?q?OA5EgM77AjqPhu/tGkWMuFrXf14tsMQwCwB9McDpfDaQgb7Sxt3QaR47skYuHV22w?= =?utf-8?q?tTM4FFBkyy8clN2OxDvLrqne4hra285La6bsc39zCn/RZLhUQl9ROgs67XImcLPJM?= =?utf-8?q?TeOIRJD6DZhMRt87O3JTon18UG3aaUhKHNnBqSnZ4bY9wCpMVrXug3sSFXlbAkPdX?= =?utf-8?q?WTUor0mwBxbUywb1bT/EJ9O2unk2ShwRZ29efOlGFwolRdx0scn2UB2tpn2O07usv?= =?utf-8?q?W858LEvdzHcq2kx2W1UmjXtcvIrxrtyiSTMt4mbvmVms7VCeF9Ls2aRLqis3Cz+7T?= =?utf-8?q?h09Cm+AXnpzxTjRXEW2vSjGJk/1tPejXV8uomdRdyR1uxaZCa0WEgyQinRqc4GZGR?= =?utf-8?q?i3npQWA84fZRMCBL2LIVtN42ZaVfHEKGSV+i3ZM+B/oNY2oDkBgtCcE=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(376014)(1800799024)(7416014)(366016)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?nTcSzyV4MXSQmwZJm4Ym7WAaYASj?= =?utf-8?q?061agWLlpXRy0q0wFuhHkfbKK7Cw66A/CjnfKsiHm2VHfOYb51uauFLIJ64u1e7Ai?= =?utf-8?q?tRqG3qZtFQ2bW/kQzo8CN+ofdsQiAPxbmGZ5VUgLjKOTFdFh1BiVJiF34R90N/fB7?= =?utf-8?q?4t5aeY9dsjl+rkvmNsF4fIO+INywszDupz0Ya2ltYcZLlstxuuF0nh4aWBVihHonu?= =?utf-8?q?DoQBO96j9QOX8WGDP1GyXlrTbQQCzIBNH/FISaMOT2vFv9E36P/yBYe6uNXgiYi7f?= =?utf-8?q?OrOtDQBkxzPbjaggPmWlU8EDj2uCnqeC3zHDnhVPu87y4LWbB6bMGkcrruyJmIxh9?= =?utf-8?q?IHbPQXT0BT6MJ6F0BbVy5TfqWsAPg1FCj3y9pLRth0KmUkIxIVaWX7rjhwl+VBdi8?= =?utf-8?q?BNtigpbDFWUrB2uD/ANuIMBJCcHpXWiucDT+++Y1YEGIJri27/QAbAMtIBUxbWs8z?= =?utf-8?q?h065M8NmeS+r80P38ednWY4LU14+8mSBsrpMxKtReaRmR+Zio24mY/YLXjj2nImz4?= =?utf-8?q?wu8cFE+0a36fgQ9oFGhY8KxTLwxGJ37F8xhzxAOvAe/BOc36lAnktnwwE3KX4n2dY?= =?utf-8?q?BdR1COZtRxQwCGbOjwGnw/ttcmzEV8uWG7BUES2DWJ1IPxf9lc09q++pqr7gDi7QS?= =?utf-8?q?DAL+ISJN9YtwcaQPNfpqxuvTRbmp4oJvodvlsJrrPeM8s8akHxawIhFrS/bDAu2Zr?= =?utf-8?q?mFnr2mqeTR5tKpMKLB67+P5sXIrYTzYd2kw6hr+YyVyH4PzQUygAC2/MsqvVnQcZ5?= =?utf-8?q?+8g94oqs9oYEy9gSsuBKMc2pXmvvjrZ8K4OVi7olfK0ptNGjHgTTfPbtMMlgFw9Hf?= =?utf-8?q?gsgVRW4RBD8k8Z/U7egXxTgkw9SrBYQ1pt/BL4homq9fORIIQgSC/MoO+rUlCsASP?= =?utf-8?q?C51gJZMVJl9+ImAn9JB9ukW/wEpGmVj6kevlsA0/pW5lFdQcjHZv1nohELtuu16r1?= =?utf-8?q?OOhdZS8cH0akaVSefzWOdde4GK/C1FB4w6B5REC1qhakf70GqtEyr4RnY5z6u6ipF?= =?utf-8?q?LvcFb8XFqlYDqefZ7rdDN6JFO9s2FmxGgmjBlwd4CJX8f1L/OhW837JOENGgexY06?= =?utf-8?q?vEv8+fGprLE7jPD65vnqpYwh9mJ+6g5QsNSHb4pkymQtGm5O2QCB/b/LIRjlftGym?= =?utf-8?q?L9WQ1fNAwDPcwuN3LO4jq8aYl6o1BR/Gqe1Y0ENW1HUWJizNOdpCPQhoRj7Z+famq?= =?utf-8?q?jbatDqfNwdjzHey1qgH0OjtKces7M9UCFBuqW61RfxglYnX/hYg858JW/8qP4wfA4?= =?utf-8?q?fHcnZ/q2jtLQD1C1IX5Dk6Jk9CcvA2k588kshL30yoOyWVBahW+kur4f0KdXg5ksB?= =?utf-8?q?VyqCnT2h9JCGtUFd8EEF6kmOHDrtwwAMeqxZHW5RVHJgodfCwSl03KLeDc865WtXh?= =?utf-8?q?0J2+yhBmxJx7mXGplHlHoxIK+JMhkdBKUNg9Nce1bJRejJfiVX6RFN3zrsODTrvWW?= =?utf-8?q?Z0cPr9iLQHa37NT91+NhlazeLdKMU+lJQl+FmrTTfObeobMHn92SeNHkdMmQQ3AeO?= =?utf-8?q?2Dh/FfjlsxUv?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: f71cb98d-c8ac-48ad-6511-08dca05506bb X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jul 2024 20:23:42.6521 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XstainIzzxSB29QtlC7RI/USSLnwdc7EIL3+j9luyi7GaoP6YxGWrHQN76kEE4f4KYSEAkc5NjO+KbyThfUW/A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8267 From: Priyanka Singh The original code: cap_high ^ (1 << (bad_data_bit - 32)) The variable bad_data_bit ranges from 0 to 63. If bad_data_bit is below 32, bad_data_bit - 32 will be a negative value. Left shifting a negative value in C is undefined behavior. Fix this by checking the range of bad_data_bit. Fixes: ea2eb9a8b620 ("EDAC, fsl-ddr: Separate FSL DDR driver from MPC85xx") Signed-off-by: Priyanka Singh Reviewed-by: Sherry Sun Signed-off-by: Li Yang Signed-off-by: Frank Li --- drivers/edac/fsl_ddr_edac.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/drivers/edac/fsl_ddr_edac.c b/drivers/edac/fsl_ddr_edac.c index 10b0a46669f3d..da743cf8a95e9 100644 --- a/drivers/edac/fsl_ddr_edac.c +++ b/drivers/edac/fsl_ddr_edac.c @@ -338,11 +338,18 @@ static void fsl_mc_check(struct mem_ctl_info *mci) fsl_mc_printk(mci, KERN_ERR, "Faulty ECC bit: %d\n", bad_ecc_bit); - fsl_mc_printk(mci, KERN_ERR, - "Expected Data / ECC:\t%#8.8x_%08x / %#2.2x\n", - cap_high ^ (1 << (bad_data_bit - 32)), - cap_low ^ (1 << bad_data_bit), - syndrome ^ (1 << bad_ecc_bit)); + if ((bad_data_bit > 0 && bad_data_bit < 32) && bad_ecc_bit > 0) { + fsl_mc_printk(mci, KERN_ERR, + "Expected Data / ECC:\t%#8.8x_%08x / %#2.2x\n", + cap_high, cap_low ^ (1 << bad_data_bit), + syndrome ^ (1 << bad_ecc_bit)); + } + if (bad_data_bit >= 32 && bad_ecc_bit > 0) { + fsl_mc_printk(mci, KERN_ERR, + "Expected Data / ECC:\t%#8.8x_%08x / %#2.2x\n", + cap_high ^ (1 << (bad_data_bit - 32)), + cap_low, syndrome ^ (1 << bad_ecc_bit)); + } } fsl_mc_printk(mci, KERN_ERR,