| Message ID | 20240821064728.8642-3-zhaoqunqin@loongson.cn (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Add EDAC driver for loongson memory controller | expand |
On Wed, 21 Aug 2024 14:47:28 +0800, Zhao Qunqin wrote: > From: zhaoqunqin <zhaoqunqin@loongson.cn> > > Add: drivers/edac/loongson_edac.c > > Signed-off-by: zhaoqunqin <zhaoqunqin@loongson.cn> > --- > .../bindings/edac/loongson,ls-mc-edac.yaml | 35 +++++++++++++++++++ > MAINTAINERS | 7 ++++ > 2 files changed, 42 insertions(+) > create mode 100644 Documentation/devicetree/bindings/edac/loongson,ls-mc-edac.yaml > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/edac/loongson,ls-mc-edac.example.dtb: mc0@1fe00600: reg: [[0, 534775296], [0, 80]] is too long from schema $id: http://devicetree.org/schemas/edac/loongson,ls-mc-edac.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240821064728.8642-3-zhaoqunqin@loongson.cn The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 21/08/2024 08:47, Zhao Qunqin wrote: > From: zhaoqunqin <zhaoqunqin@loongson.cn> > > Add: drivers/edac/loongson_edac.c > > Signed-off-by: zhaoqunqin <zhaoqunqin@loongson.cn> Please use full name, not login. > --- > .../bindings/edac/loongson,ls-mc-edac.yaml | 35 +++++++++++++++++++ Bindings are before users. > MAINTAINERS | 7 ++++ > 2 files changed, 42 insertions(+) > create mode 100644 Documentation/devicetree/bindings/edac/loongson,ls-mc-edac.yaml > > diff --git a/Documentation/devicetree/bindings/edac/loongson,ls-mc-edac.yaml b/Documentation/devicetree/bindings/edac/loongson,ls-mc-edac.yaml > new file mode 100644 > index 000000000..29e5b8381 > --- /dev/null > +++ b/Documentation/devicetree/bindings/edac/loongson,ls-mc-edac.yaml > @@ -0,0 +1,35 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/edac/loongson,ls-mc-edac.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Loongson Memory Controller EDAC > + > +maintainers: > + - Zhao Qunqin <zhaoqunqin@loongson.cn> > + > +description: | > + EDAC node is defined to describe on-chip error detection and correction for > + Loongson Memory Controller. > + > +properties: > + > + compatible: > + const: loongson,ls-mc-edac Missing soc part. And then adjust filename to match proper (new) compatible. > + > + reg: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + edac: mc0@1fe00600 { memory-controller@ and drop unused label. > + compatible = "loongson,ls-mc-edac"; > + reg = <0x0 0x1fe00600 0x0 0x50>; > + }; Best regards, Krzysztof
On Wed, Aug 21, 2024 at 10:20:29AM +0200, Krzysztof Kozlowski wrote: > On 21/08/2024 08:47, Zhao Qunqin wrote: > > From: zhaoqunqin <zhaoqunqin@loongson.cn> > > > > Add: drivers/edac/loongson_edac.c This is not what your patch does. > > > > Signed-off-by: zhaoqunqin <zhaoqunqin@loongson.cn> > > Please use full name, not login. > > > --- > > .../bindings/edac/loongson,ls-mc-edac.yaml | 35 +++++++++++++++++++ > > Bindings are before users. > > > MAINTAINERS | 7 ++++ > > 2 files changed, 42 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/edac/loongson,ls-mc-edac.yaml > > > > diff --git a/Documentation/devicetree/bindings/edac/loongson,ls-mc-edac.yaml b/Documentation/devicetree/bindings/edac/loongson,ls-mc-edac.yaml > > new file mode 100644 > > index 000000000..29e5b8381 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/edac/loongson,ls-mc-edac.yaml > > @@ -0,0 +1,35 @@ > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/edac/loongson,ls-mc-edac.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Loongson Memory Controller EDAC > > + > > +maintainers: > > + - Zhao Qunqin <zhaoqunqin@loongson.cn> > > + > > +description: | > > + EDAC node is defined to describe on-chip error detection and correction for > > + Loongson Memory Controller. > > + > > +properties: > > + > > + compatible: > > + const: loongson,ls-mc-edac > > Missing soc part. And then adjust filename to match proper (new) compatible. Please, please speak with your colleagues at Loongson that have submitted other binding patches. Each time someone new submits one, we are back to square one in terms of compatible strings. Thanks, Conor.
在 2024/8/21 下午4:20, Krzysztof Kozlowski 写道: > On 21/08/2024 08:47, Zhao Qunqin wrote: >> From: zhaoqunqin <zhaoqunqin@loongson.cn> >> >> Add: drivers/edac/loongson_edac.c >> >> Signed-off-by: zhaoqunqin <zhaoqunqin@loongson.cn> > Please use full name, not login. > >> --- >> .../bindings/edac/loongson,ls-mc-edac.yaml | 35 +++++++++++++++++++ > Bindings are before users. dt-bindings is 0001-*.patch and driver is 0002-*.patch ? > >> MAINTAINERS | 7 ++++ >> 2 files changed, 42 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/edac/loongson,ls-mc-edac.yaml >> >> diff --git a/Documentation/devicetree/bindings/edac/loongson,ls-mc-edac.yaml b/Documentation/devicetree/bindings/edac/loongson,ls-mc-edac.yaml >> new file mode 100644 >> index 000000000..29e5b8381 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/edac/loongson,ls-mc-edac.yaml >> @@ -0,0 +1,35 @@ >> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/edac/loongson,ls-mc-edac.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Loongson Memory Controller EDAC >> + >> +maintainers: >> + - Zhao Qunqin <zhaoqunqin@loongson.cn> >> + >> +description: | >> + EDAC node is defined to describe on-chip error detection and correction for >> + Loongson Memory Controller. >> + >> +properties: >> + >> + compatible: >> + const: loongson,ls-mc-edac > Missing soc part. And then adjust filename to match proper (new) compatible. ls3c5000l, ls3c5000, ls3d5000, ls3a6000 and ls3c6000 are compatible with ls3a5000. Can i write compatible string this way: properties: compatible: oneOf: - enum: - loongson,ls3a5000-mc-edac - items: - enum: - loongson,ls3c5000l-mc-edac - loongson,ls3c5000-mc-edac - loongson,ls3d5000-mc-edac - loongson,ls3a6000-mc-edac - loongson,ls3c6000-mc-edac - const: loongson,ls3a5000-mc-edac > >> + >> + reg: >> + maxItems: 1 >> + >> +required: >> + - compatible >> + - reg >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + edac: mc0@1fe00600 { > memory-controller@ > > and drop unused label. > > >> + compatible = "loongson,ls-mc-edac"; >> + reg = <0x0 0x1fe00600 0x0 0x50>; >> + }; > Best regards, > Krzysztof Thanks for your suggestions, Zhao Qunqin
diff --git a/Documentation/devicetree/bindings/edac/loongson,ls-mc-edac.yaml b/Documentation/devicetree/bindings/edac/loongson,ls-mc-edac.yaml new file mode 100644 index 000000000..29e5b8381 --- /dev/null +++ b/Documentation/devicetree/bindings/edac/loongson,ls-mc-edac.yaml @@ -0,0 +1,35 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/edac/loongson,ls-mc-edac.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Loongson Memory Controller EDAC + +maintainers: + - Zhao Qunqin <zhaoqunqin@loongson.cn> + +description: | + EDAC node is defined to describe on-chip error detection and correction for + Loongson Memory Controller. + +properties: + + compatible: + const: loongson,ls-mc-edac + + reg: + maxItems: 1 + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + edac: mc0@1fe00600 { + compatible = "loongson,ls-mc-edac"; + reg = <0x0 0x1fe00600 0x0 0x50>; + }; diff --git a/MAINTAINERS b/MAINTAINERS index 958e93544..bc419e309 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -13017,6 +13017,13 @@ S: Maintained F: Documentation/devicetree/bindings/thermal/loongson,ls2k-thermal.yaml F: drivers/thermal/loongson2_thermal.c +LOONGSON EDAC DRIVER +M: Zhao Qunqin <zhaoqunqin@loongson.cn> +L: linux-edac@vger.kernel.org +S: Maintained +F: Documentation/devicetree/bindings/edac/loongson,ls-mc-edac.yaml +F: drivers/edac/loongson_edac.c + LSILOGIC MPT FUSION DRIVERS (FC/SAS/SPI) M: Sathya Prakash <sathya.prakash@broadcom.com> M: Sreekanth Reddy <sreekanth.reddy@broadcom.com>