| Message ID | 20240903114714.11428-2-zhaoqunqin@loongson.cn (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Add EDAC driver for loongson memory controller | expand |
On 03/09/2024 13:47, Zhao Qunqin wrote: > add device tree bindings for ls3a5000 EDAC driver. > > Signed-off-by: Zhao Qunqin <zhaoqunqin@loongson.cn> So no improvements? No changes? Why do you send the same? Best regards, Krzysztof
在 2024/9/3 下午8:29, Krzysztof Kozlowski 写道: > On 03/09/2024 13:47, Zhao Qunqin wrote: >> add device tree bindings for ls3a5000 EDAC driver. >> >> Signed-off-by: Zhao Qunqin <zhaoqunqin@loongson.cn> > So no improvements? No changes? Why do you send the same? I'm sorry, I thought if you hadn't raised any issues with the previous version of dt binding, I wouldn't need to make any changes. For this version of the patch, I only changed the driver. Best regards, Zhao Qunqin. > > Best regards, > Krzysztof
On 04/09/2024 03:15, Zhao Qunqin wrote: > > 在 2024/9/3 下午8:29, Krzysztof Kozlowski 写道: >> On 03/09/2024 13:47, Zhao Qunqin wrote: >>> add device tree bindings for ls3a5000 EDAC driver. >>> >>> Signed-off-by: Zhao Qunqin <zhaoqunqin@loongson.cn> >> So no improvements? No changes? Why do you send the same? > > I'm sorry, I thought if you hadn't raised any issues with the previous > version of dt binding, I wouldn't need to make any changes. > > For this version of the patch, I only changed the driver. So what changed? Where is the changelog? Where is the tag? Did you get one? Did you read submitting patches document? Best regards, Krzysztof
在 2024/9/4 下午1:51, Krzysztof Kozlowski 写道: > On 04/09/2024 03:15, Zhao Qunqin wrote: >> 在 2024/9/3 下午8:29, Krzysztof Kozlowski 写道: >>> On 03/09/2024 13:47, Zhao Qunqin wrote: >>>> add device tree bindings for ls3a5000 EDAC driver. >>>> >>>> Signed-off-by: Zhao Qunqin <zhaoqunqin@loongson.cn> >>> So no improvements? No changes? Why do you send the same? >> I'm sorry, I thought if you hadn't raised any issues with the previous >> version of dt binding, I wouldn't need to make any changes. >> >> For this version of the patch, I only changed the driver. > So what changed? Where is the changelog? Where is the tag? Did you get one? > > Did you read submitting patches document? My apologies! I must have missed a part of the content in the document, please forgive me for wasting your time. Will add tag and changelog in patch v4. Thank you very much for taking the time to review. Best regards, Zhao Qunqin. > > Best regards, > Krzysztof
diff --git a/Documentation/devicetree/bindings/edac/loongson,ls3a5000-mc-edac.yaml b/Documentation/devicetree/bindings/edac/loongson,ls3a5000-mc-edac.yaml new file mode 100644 index 000000000..52f10bc94 --- /dev/null +++ b/Documentation/devicetree/bindings/edac/loongson,ls3a5000-mc-edac.yaml @@ -0,0 +1,44 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/edac/loongson,ls3a5000-mc-edac.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Loongson Memory Controller EDAC + +maintainers: + - Zhao Qunqin <zhaoqunqin@loongson.cn> + +description: | + EDAC node is defined to describe on-chip error detection and correction for + Loongson Memory Controller. + +properties: + compatible: + oneOf: + - enum: + - loongson,ls3a5000-mc-edac + - items: + - enum: + - loongson,ls3c5000l-mc-edac + - loongson,ls3c5000-mc-edac + - loongson,ls3d5000-mc-edac + - loongson,ls3a6000-mc-edac + - loongson,ls3c6000-mc-edac + - const: loongson,ls3a5000-mc-edac + + reg: + maxItems: 1 + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + memory-controller@1fe00600 { + compatible = "loongson,ls3a5000-mc-edac"; + reg = <0x1fe00600 0x50>; + }; diff --git a/MAINTAINERS b/MAINTAINERS index 42decde38..6cc8cfc8f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -13237,6 +13237,12 @@ S: Maintained F: Documentation/devicetree/bindings/thermal/loongson,ls2k-thermal.yaml F: drivers/thermal/loongson2_thermal.c +LOONGSON EDAC DRIVER +M: Zhao Qunqin <zhaoqunqin@loongson.cn> +L: linux-edac@vger.kernel.org +S: Maintained +F: Documentation/devicetree/bindings/edac/loongson,ls3a5000-mc-edac.yaml + LSILOGIC MPT FUSION DRIVERS (FC/SAS/SPI) M: Sathya Prakash <sathya.prakash@broadcom.com> M: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
add device tree bindings for ls3a5000 EDAC driver. Signed-off-by: Zhao Qunqin <zhaoqunqin@loongson.cn> --- .../edac/loongson,ls3a5000-mc-edac.yaml | 44 +++++++++++++++++++ MAINTAINERS | 6 +++ 2 files changed, 50 insertions(+) create mode 100644 Documentation/devicetree/bindings/edac/loongson,ls3a5000-mc-edac.yaml