| Message ID | CAMhTFw=OUaVSLGz1tyHJYiq6UXBNni5=fBp16M7vPXjA0HHEEA@mail.gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2,1/1] EDAC: (pnd2) Fix the log level and remove the word "error" for message "Failed to register device with error %d" | expand |
On Fri, 2020-03-20 at 16:26 +0800, she90122 . wrote: > From: Amy Shih <amy.shih@advantech.com.tw> > > Fix the log level from "KERN_ERR" to "KERN_INFO" and remove the word > "error" for message "Failed to register device with error %d", since > it is not the error message but the information to notice the user. > > Signed-off-by: Amy Shih <amy.shih@advantech.com.tw> > --- > Changes in v2: > - Remove the word "error" from output message. > --- > drivers/edac/pnd2_edac.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/edac/pnd2_edac.c b/drivers/edac/pnd2_edac.c index > 933f772..399da3e 100644 > --- a/drivers/edac/pnd2_edac.c > +++ b/drivers/edac/pnd2_edac.c > @@ -1572,7 +1572,8 @@ static int __init pnd2_init(void) > > rc = pnd2_probe(); > if (rc < 0) { > - pnd2_printk(KERN_ERR, "Failed to register device with error %d.\n", rc); > + pnd2_printk(KERN_INFO, > + "Failed to register device - %d.\n", rc); > return rc; > } This will not apply as it's whitespace damaged. Another possibility would be to use the new %pe extension. --- drivers/edac/pnd2_edac.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/edac/pnd2_edac.c b/drivers/edac/pnd2_edac.c index 933f77..370f219 100644 --- a/drivers/edac/pnd2_edac.c +++ b/drivers/edac/pnd2_edac.c @@ -1572,7 +1572,8 @@ static int __init pnd2_init(void) rc = pnd2_probe(); if (rc < 0) { - pnd2_printk(KERN_ERR, "Failed to register device with error %d.\n", rc); + pnd2_printk(KERN_INFO, "Failed to register device - %pe\n", + ERR_PTR(rc)); return rc; }
diff --git a/drivers/edac/pnd2_edac.c b/drivers/edac/pnd2_edac.c index 933f772..399da3e 100644 --- a/drivers/edac/pnd2_edac.c +++ b/drivers/edac/pnd2_edac.c @@ -1572,7 +1572,8 @@ static int __init pnd2_init(void) rc = pnd2_probe(); if (rc < 0) { - pnd2_printk(KERN_ERR, "Failed to register device with error %d.\n", rc); + pnd2_printk(KERN_INFO, + "Failed to register device - %d.\n", rc); return rc; }