EDAC: Aspeed: Use devm_platform_ioremap_resource() in aspeed_probe()

Commit Message

Markus Elfring Sept. 21, 2019, 4:46 p.m. UTC

From: Markus Elfring <[e-mail]>
Date: Sat, 21 Sep 2019 18:32:46 +0200

Simplify this function implementation by using a known wrapper function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[e-mail]>
---
 drivers/edac/aspeed_edac.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

--
2.23.0

Comments

Joel Stanley Oct. 23, 2019, 6:23 a.m. UTC | #1

On Sat, 21 Sep 2019 at 16:47, Markus Elfring <[e-mail]> wrote:
>
> From: Markus Elfring <[e-mail]>
> Date: Sat, 21 Sep 2019 18:32:46 +0200
>
> Simplify this function implementation by using a known wrapper function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <[e-mail]>

Acked-by: Joel Stanley <[e-mail]>

Borislav Petkov Oct. 24, 2019, 1:45 p.m. UTC | #2

On Wed, Oct 23, 2019 at 06:23:53AM +0000, Joel Stanley wrote:
> On Sat, 21 Sep 2019 at 16:47, Markus Elfring <[e-mail]> wrote:
> >
> > From: Markus Elfring <[e-mail]>
> > Date: Sat, 21 Sep 2019 18:32:46 +0200
> >
> > Simplify this function implementation by using a known wrapper function.
> >
> > This issue was detected by using the Coccinelle software.
> >
> > Signed-off-by: Markus Elfring <[e-mail]>
> 
> Acked-by: Joel Stanley <[e-mail]>

Applied, thanks.

Patch

diff --git a/drivers/edac/aspeed_edac.c b/drivers/edac/aspeed_edac.c
index 5634437bb39d..09a9e3de9595 100644
--- a/drivers/edac/aspeed_edac.c
+++ b/drivers/edac/aspeed_edac.c
@@ -281,16 +281,11 @@  static int aspeed_probe(struct platform_device *pdev)
 	struct device *dev = &pdev->dev;
 	struct edac_mc_layer layers[2];
 	struct mem_ctl_info *mci;
-	struct resource *res;
 	void __iomem *regs;
 	u32 reg04;
 	int rc;

-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	if (!res)
-		return -ENOENT;
-
-	regs = devm_ioremap_resource(dev, res);
+	regs = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(regs))
 		return PTR_ERR(regs);