From patchwork Thu Aug 2 11:28:38 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans de Goede X-Patchwork-Id: 10553491 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id BC86115A6 for ; Thu, 2 Aug 2018 11:28:46 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A9F5D2BCD8 for ; Thu, 2 Aug 2018 11:28:46 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9E3042BCDF; Thu, 2 Aug 2018 11:28:46 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 48FC22BCD9 for ; Thu, 2 Aug 2018 11:28:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732202AbeHBNT2 (ORCPT ); Thu, 2 Aug 2018 09:19:28 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:41828 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728767AbeHBNT1 (ORCPT ); Thu, 2 Aug 2018 09:19:27 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EF343401DE61; Thu, 2 Aug 2018 11:28:43 +0000 (UTC) Received: from shalem.localdomain.com (ovpn-116-163.ams2.redhat.com [10.36.116.163]) by smtp.corp.redhat.com (Postfix) with ESMTP id 22318215670D; Thu, 2 Aug 2018 11:28:42 +0000 (UTC) From: Hans de Goede To: Bartlomiej Zolnierkiewicz Cc: Hans de Goede , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: [PATCH fix for 4.19 0/3] fbcon: Fix VT switching being broken in combination with vgacon Date: Thu, 2 Aug 2018 13:28:38 +0200 Message-Id: <20180802112841.27679-1-hdegoede@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Thu, 02 Aug 2018 11:28:44 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Thu, 02 Aug 2018 11:28:44 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'hdegoede@redhat.com' RCPT:'' Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Bartlomiej, After backporting the deferred fbcon takeover patches to the 4.18 kernel for the upcoming Fedora 29 release, Fedora QA found a serious bug caused by the fbcon takeover support. When using classic (non EFI) boot on x86 and thus using vgacon, dummycon is not used, so the deferred takeover never happens as that depends on dummycon being the vt-console driver until the takeover happens. This is fixed by the 2nd patch in this set, futher testing has shown that that breaks the build when fb.o is a module, because of the conswitchp symbol not being exported. This made me realize that I never intended for deferred fbcon takeover to be possible when fbdev+fbcon are being build as a module (*), so instead of exporting yet more symbols, the first patch is a preparation patch which only allows deferred fbcon takeover when builtin. The third patch is a cleanup patch unexporting the dummycon_[un]register_output symbols since those now no longer need to be exported. At least patches 1 and 2 should be added to your tree for merging into 4.19, patch 3 can go in in the 4.20 cycle if you prefer delaying it till then. Regards, Hans *) which I should have realized when we hit the same issue with the dummycon_[un]register_output symbols --- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html