| Message ID | 20190625163434.13620-1-brgl@bgdev.pl (mailing list archive) |
|---|---|
| Headers | show |
| Series | ARM: davinci: da850-evm: remove more legacy GPIO calls | expand |
Hi Lee, Daniel, Jingoo, On 25/06/19 10:04 PM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > This is another small step on the path to liberating davinci from legacy > GPIO API calls and shrinking the davinci GPIO driver by not having to > support the base GPIO number anymore. > > This time we're removing the legacy calls used indirectly by the LCDC > fbdev driver. > > The first three patches modify the GPIO backlight driver. The first > of them adds the necessary functionality, the other two are just > tweaks and cleanups. Can you take the first three patches for v5.3 - if its not too late? I think that will make it easy for rest of patches to make into subsequent kernel releases. > > Next two patches enable the GPIO backlight driver in > davinci_all_defconfig. > > Patch 6/12 models the backlight GPIO as an actual GPIO backlight device. > > Patches 7-9 extend the fbdev driver with regulator support and convert > the da850-evm board file to using it. > > Last three patches are improvements to the da8xx fbdev driver since > we're already touching it in this series. Thanks, Sekhar
On Mon, 01 Jul 2019, Sekhar Nori wrote: > Hi Lee, Daniel, Jingoo, > > On 25/06/19 10:04 PM, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > > > This is another small step on the path to liberating davinci from legacy > > GPIO API calls and shrinking the davinci GPIO driver by not having to > > support the base GPIO number anymore. > > > > This time we're removing the legacy calls used indirectly by the LCDC > > fbdev driver. > > > > The first three patches modify the GPIO backlight driver. The first > > of them adds the necessary functionality, the other two are just > > tweaks and cleanups. > > Can you take the first three patches for v5.3 - if its not too late? I > think that will make it easy for rest of patches to make into subsequent > kernel releases. It's already too late in the cycle (-rc7) for that. I require patches of this nature to have a good soak in -next before being merged. There shouldn't be an issue with getting them into v5.4 though. > > Next two patches enable the GPIO backlight driver in > > davinci_all_defconfig. > > > > Patch 6/12 models the backlight GPIO as an actual GPIO backlight device. > > > > Patches 7-9 extend the fbdev driver with regulator support and convert > > the da850-evm board file to using it. > > > > Last three patches are improvements to the da8xx fbdev driver since > > we're already touching it in this series. > > Thanks, > Sekhar >
On Tue, Jul 02, 2019 at 07:36:53AM +0100, Lee Jones wrote: > On Mon, 01 Jul 2019, Sekhar Nori wrote: > > > Hi Lee, Daniel, Jingoo, > > > > On 25/06/19 10:04 PM, Bartosz Golaszewski wrote: > > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > > > > > This is another small step on the path to liberating davinci from legacy > > > GPIO API calls and shrinking the davinci GPIO driver by not having to > > > support the base GPIO number anymore. > > > > > > This time we're removing the legacy calls used indirectly by the LCDC > > > fbdev driver. > > > > > > The first three patches modify the GPIO backlight driver. The first > > > of them adds the necessary functionality, the other two are just > > > tweaks and cleanups. > > > > Can you take the first three patches for v5.3 - if its not too late? I > > think that will make it easy for rest of patches to make into subsequent > > kernel releases. > > It's already too late in the cycle (-rc7) for that. I require patches > of this nature to have a good soak in -next before being merged. There > shouldn't be an issue with getting them into v5.4 though. On the other hand I think we did take a patch that did much the same thing as patch 1/12 in this series: https://git.kernel.org/pub/scm/linux/kernel/git/lee/backlight.git/commit/?h=for-backlight-next&id=98b7404eb7d64e55f8fdd419cb3965a8abf0e217 I'm not 100% sure but I think that might allow the patchset to be split into two that are independent (one for Davinci and one for gpio backlight improvements). Daniel. > > > > Next two patches enable the GPIO backlight driver in > > > davinci_all_defconfig. > > > > > > Patch 6/12 models the backlight GPIO as an actual GPIO backlight device. > > > > > > Patches 7-9 extend the fbdev driver with regulator support and convert > > > the da850-evm board file to using it. > > > > > > Last three patches are improvements to the da8xx fbdev driver since > > > we're already touching it in this series. > > > > Thanks, > > Sekhar > > > > -- > Lee Jones [李琼斯] > Linaro Services Technical Lead > Linaro.org │ Open source software for ARM SoCs > Follow Linaro: Facebook | Twitter | Blog
From: Bartosz Golaszewski <bgolaszewski@baylibre.com> This is another small step on the path to liberating davinci from legacy GPIO API calls and shrinking the davinci GPIO driver by not having to support the base GPIO number anymore. This time we're removing the legacy calls used indirectly by the LCDC fbdev driver. The first three patches modify the GPIO backlight driver. The first of them adds the necessary functionality, the other two are just tweaks and cleanups. Next two patches enable the GPIO backlight driver in davinci_all_defconfig. Patch 6/12 models the backlight GPIO as an actual GPIO backlight device. Patches 7-9 extend the fbdev driver with regulator support and convert the da850-evm board file to using it. Last three patches are improvements to the da8xx fbdev driver since we're already touching it in this series. Bartosz Golaszewski (12): backlight: gpio: allow to probe non-pdata devices from board files backlight: gpio: use a helper variable for &pdev->dev backlight: gpio: pull the non-pdata device probing code into probe() ARM: davinci: refresh davinci_all_defconfig ARM: davinci_all_defconfig: enable GPIO backlight ARM: davinci: da850-evm: model the backlight GPIO as an actual device fbdev: da8xx: add support for a regulator ARM: davinci: da850-evm: switch to using a fixed regulator for lcdc fbdev: da8xx: remove panel_power_ctrl() callback from platform data fbdev: da8xx-fb: use devm_platform_ioremap_resource() fbdev: da8xx-fb: drop a redundant if fbdev: da8xx: use resource management for dma arch/arm/configs/davinci_all_defconfig | 28 +++--- arch/arm/mach-davinci/board-da850-evm.c | 90 ++++++++++++----- drivers/video/backlight/gpio_backlight.c | 67 +++++-------- drivers/video/fbdev/da8xx-fb.c | 118 +++++++++++++---------- include/video/da8xx-fb.h | 1 - 5 files changed, 165 insertions(+), 139 deletions(-)