From patchwork Sat May 11 12:45:14 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 2553811 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id CC275DF230 for ; Sat, 11 May 2013 12:45:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752194Ab3EKMpR (ORCPT ); Sat, 11 May 2013 08:45:17 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:51568 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751990Ab3EKMpQ (ORCPT ); Sat, 11 May 2013 08:45:16 -0400 Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MMM008W2WRBYSE0@mailout1.samsung.com> for linux-fbdev@vger.kernel.org; Sat, 11 May 2013 21:45:14 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.48]) by epcpsbgr1.samsung.com (EPCPMTA) with SMTP id 85.ED.31024.A5D3E815; Sat, 11 May 2013 21:45:14 +0900 (KST) X-AuditID: cbfee68d-b7f016d000007930-bf-518e3d5a2653 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 3A.0B.01422.A5D3E815; Sat, 11 May 2013 21:45:14 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MMM00DDBWREP290@mmp1.samsung.com>; Sat, 11 May 2013 21:45:14 +0900 (KST) From: Jingoo Han To: linux-fbdev@vger.kernel.org Cc: 'Florian Tobias Schandinat' , 'Tomi Valkeinen' , Jingoo Han , 'Mike Frysinger' , 'Michael Hennerich' Subject: [PATCH 01/15] video: bfin: remove unnecessary platform_set_drvdata() Date: Sat, 11 May 2013 21:45:14 +0900 Message-id: <000101ce4e45$61e28c30$25a7a490$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: Ac5ORVxvMIlwFqDHSJi5sW2ndL0GJA== Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrGIsWRmVeSWpSXmKPExsVy+t8zA90o275Ag8OfZSw6Z15jtLi88BKr xYm+D6wWEw5vZrdYP/8Wm8XNCT+YHdg8Xl119Lj8/Q2zx4ePcR59W1Yxehy/sZ3J4/MmuQC2 KC6blNSczLLUIn27BK6Mvc2tjAUrBSpuHz/M1sB4h7eLkYNDQsBE4vpuly5GTiBTTOLCvfVs XYxcHEICyxglHpzsZoNImEjs3P8HzBYSWMQoseOILETRL0aJttcHwBJsAmoSX74cZgexRQTk Jfb0tzOBFDELPGOUOLjsJCtIQljAV2Ldzg0sIJtZBFQlbh6LBDF5BSwlJjcbglTwCghK/Jh8 jwXEZhbQkli/8zgThC0vsXnNW2aIexQkdpx9zQixSk9i8qS/UPUiEvtevGMEWSshcIldYu75 72C3sQgISHybfIgF4mFZiU0HoOZIShxccYNlAqPYLCSrZyFZPQvJ6llIVixgZFnFKJpakFxQ nJReZKhXnJhbXJqXrpecn7uJERKHvTsYbx+wPsSYDLR+IrOUaHI+MI7zSuINjc2MLExNTI2N zC3NSBNWEudVa7EOFBJITyxJzU5NLUgtii8qzUktPsTIxMEp1cCYqs9XsfzCks3XXrfvs/ia s2mmwc6+43Oyp7fEn0laIrvoSR7nlPdxN5z6j3+73787oujSDa7IUytVsiYWSBjpRwuJWwpb BkRnsi/X4tae3G/ztPGL8TaVPa285ZvWGc6Z+eq14XsFkQatc/2rZr7+suXuMYOF7zY3bk6Z sXGR2w+mc5MNrvxkVWIpzkg01GIuKk4EAACvTYbZAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrCKsWRmVeSWpSXmKPExsVy+t9jAd0o275Ag7/LJSw6Z15jtLi88BKr xYm+D6wWEw5vZrdYP/8Wm8XNCT+YHdg8Xl119Lj8/Q2zx4ePcR59W1Yxehy/sZ3J4/MmuQC2 qAZGm4zUxJTUIoXUvOT8lMy8dFsl7+B453hTMwNDXUNLC3MlhbzE3FRbJRefAF23zBygK5QU yhJzSoFCAYnFxUr6dpgmhIa46VrANEbo+oYEwfUYGaCBhHWMGXubWxkLVgpU3D5+mK2B8Q5v FyMnh4SAicTO/X/YIGwxiQv31oPZQgKLGCV2HJHtYuQCsn8xSrS9PgCWYBNQk/jy5TA7iC0i IC+xp7+dCaSIWeAZo8TBZSdZQRLCAr4S63ZuYOli5OBgEVCVuHksEsTkFbCUmNxsCFLBKyAo 8WPyPRYQm1lAS2L9zuNMELa8xOY1b5kh7lGQ2HH2NSPEKj2JyZP+QtWLSOx78Y5xAqPALCSj ZiEZNQvJqFlIWhYwsqxiFE0tSC4oTkrPNdIrTswtLs1L10vOz93ECI7zZ9I7GFc1WBxiFOBg VOLhrRDqDRRiTSwrrsw9xCjBwawkwvvsAVCINyWxsiq1KD++qDQntfgQYzLQnxOZpUST84Ep KK8k3tDYxMzI0sjMwsjE3Jw0YSVx3oOt1oFCAumJJanZqakFqUUwW5g4OKUaGPON8zPzN6/a rHtP47Arc31sXdGJd/UbT+3Vj3k66xz3ub/fwqav3L6K7eefm3uPN7jMnGb8+8+FnOXGyY87 ZJ8E6wTd58hcwrKd8arK/55LB6+lTnRRmKLx2yfgLb/B3cp3TEW57ZPSjM+rZx+LMzl97tmL +yJrzrDOl5j49AHPsm1mcgWXWUKUWIozEg21mIuKEwEyKRNZNwMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/video/bf54x-lq043fb.c | 1 - drivers/video/bfin-lq035q1-fb.c | 2 -- drivers/video/bfin-t350mcqb-fb.c | 2 -- 3 files changed, 0 insertions(+), 5 deletions(-) diff --git a/drivers/video/bf54x-lq043fb.c b/drivers/video/bf54x-lq043fb.c index 2726a5b..87f288b 100644 --- a/drivers/video/bf54x-lq043fb.c +++ b/drivers/video/bf54x-lq043fb.c @@ -681,7 +681,6 @@ out3: out2: free_dma(CH_EPPI0); out1: - platform_set_drvdata(pdev, NULL); return ret; } diff --git a/drivers/video/bfin-lq035q1-fb.c b/drivers/video/bfin-lq035q1-fb.c index 29d8c04..be65bae 100644 --- a/drivers/video/bfin-lq035q1-fb.c +++ b/drivers/video/bfin-lq035q1-fb.c @@ -759,7 +759,6 @@ static int bfin_lq035q1_probe(struct platform_device *pdev) out2: free_dma(CH_PPI); out1: - platform_set_drvdata(pdev, NULL); return ret; } @@ -788,7 +787,6 @@ static int bfin_lq035q1_remove(struct platform_device *pdev) bfin_lq035q1_free_ports(info->disp_info->ppi_mode == USE_RGB565_16_BIT_PPI); - platform_set_drvdata(pdev, NULL); framebuffer_release(fbinfo); dev_info(&pdev->dev, "unregistered LCD driver\n"); diff --git a/drivers/video/bfin-t350mcqb-fb.c b/drivers/video/bfin-t350mcqb-fb.c index d46da01..48c0c4e 100644 --- a/drivers/video/bfin-t350mcqb-fb.c +++ b/drivers/video/bfin-t350mcqb-fb.c @@ -578,7 +578,6 @@ out3: out2: free_dma(CH_PPI); out1: - platform_set_drvdata(pdev, NULL); return ret; } @@ -608,7 +607,6 @@ static int bfin_t350mcqb_remove(struct platform_device *pdev) bfin_t350mcqb_request_ports(0); - platform_set_drvdata(pdev, NULL); framebuffer_release(fbinfo); printk(KERN_INFO DRIVER_NAME ": Unregister LCD driver.\n");