From patchwork Sat May 11 12:47:08 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 2553821 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 6CC04DF230 for ; Sat, 11 May 2013 12:47:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752240Ab3EKMrK (ORCPT ); Sat, 11 May 2013 08:47:10 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:23835 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751781Ab3EKMrK (ORCPT ); Sat, 11 May 2013 08:47:10 -0400 Received: from epcpsbgr5.samsung.com (u145.gpu120.samsung.co.kr [203.254.230.145]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MMM001XZWUK8H90@mailout4.samsung.com> for linux-fbdev@vger.kernel.org; Sat, 11 May 2013 21:47:08 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.49]) by epcpsbgr5.samsung.com (EPCPMTA) with SMTP id E7.A8.19350.CCD3E815; Sat, 11 May 2013 21:47:08 +0900 (KST) X-AuditID: cbfee691-b7fe56d000004b96-17-518e3dccd5ad Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 51.3B.01422.CCD3E815; Sat, 11 May 2013 21:47:08 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MMM00KSIWUKZH20@mmp2.samsung.com>; Sat, 11 May 2013 21:47:08 +0900 (KST) From: Jingoo Han To: linux-fbdev@vger.kernel.org Cc: 'Florian Tobias Schandinat' , 'Tomi Valkeinen' , Jingoo Han , Hartley Sweeten , 'Ryan Mallon' Subject: [PATCH 02/15] video: ep93xx: remove unnecessary platform_set_drvdata() Date: Sat, 11 May 2013 21:47:08 +0900 Message-id: <000201ce4e45$a5da7330$f18f5990$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: Ac5ORW//J/ZceVbYTk2lkkJL6c7v0w== Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrJIsWRmVeSWpSXmKPExsVy+t8zQ90ztn2BBova5Cw6Z15jtJg75zu7 xeWFl1gtTvR9YLU4vm0Nm8X6+bfYHNg8ds66y+7x4WOcR9+WVYwex29sZ/L4vEnO4/mZH2wB bFFcNimpOZllqUX6dglcGR2bt7AXHGavePf0MXsD42y2LkZODgkBE4lFF7ZD2WISF+6tB7K5 OIQEljFKHJvaBeRwgBXtWmMDEZ/OKLF23zcWCOcXo8SvB+vZQbrZBNQkvnw5DGaLCMhL7Olv ZwIpYha4zyjx9fohVpCEsIC/xLmbc8DWsQioSuzZtZYFxOYVsJS4vHsJG4QtKPFj8j2wOLOA lsT6nceZIGx5ic1r3jJDnKogsePsa0aIZXoSh7/PZISoEZHY9+IdI0TNJXaJWdPsIHYJSHyb fIgF4htZiU0HoMZIShxccYNlAqPYLCSbZyHZPAvJ5llINixgZFnFKJpakFxQnJReZKpXnJhb XJqXrpecn7uJERKNE3cw3j9gfYgxGWj9RGYp0eR8YDTnlcQbGpsZWZiamBobmVuakSasJM6r 3mIdKCSQnliSmp2aWpBaFF9UmpNafIiRiYNTqoFxye2pJx7tj5sspDnBr7POg+/ti/Ns3C8n JedbdVld2+FeuXVBgF9C4QeXUyeUvbMCdux00pN88cpPeM6b1dM23mw9Vvbw6ARWGffYgDuS jkcn77T6HXMvhOkdL5ucoZ1fzF0hpoBrUZs27+I6f8lM0dmCf3+KZof+pxUerkX+jOu4y+XM DrQpsRRnJBpqMRcVJwIAvLF7U9wCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrOKsWRmVeSWpSXmKPExsVy+t9jQd0ztn2BBlc7pCw6Z15jtJg75zu7 xeWFl1gtTvR9YLU4vm0Nm8X6+bfYHNg8ds66y+7x4WOcR9+WVYwex29sZ/L4vEnO4/mZH2wB bFENjDYZqYkpqUUKqXnJ+SmZeem2St7B8c7xpmYGhrqGlhbmSgp5ibmptkouPgG6bpk5QGco KZQl5pQChQISi4uV9O0wTQgNcdO1gGmM0PUNCYLrMTJAAwnrGDM6Nm9hLzjMXvHu6WP2BsbZ bF2MHBwSAiYSu9bYdDFyApliEhfurQcKc3EICUxnlFi77xsLhPOLUeLXg/XsIFVsAmoSX74c BrNFBOQl9vS3M4EUMQvcZ5T4ev0QK0hCWMBf4tzNOWwgNouAqsSeXWtZQGxeAUuJy7uXsEHY ghI/Jt8DizMLaEms33mcCcKWl9i85i0zxEkKEjvOvmaEWKYncfj7TEaIGhGJfS/eMU5gFJiF ZNQsJKNmIRk1C0nLAkaWVYyiqQXJBcVJ6blGesWJucWleel6yfm5mxjB0f5MegfjqgaLQ4wC HIxKPLwVQr2BQqyJZcWVuYcYJTiYlUR4nz0ACvGmJFZWpRblxxeV5qQWH2JMBvp0IrOUaHI+ MBHllcQbGpuYGVkamVkYmZibkyasJM57sNU6UEggPbEkNTs1tSC1CGYLEwenVAOjwpysGJ3s DN69l8s2X6yR4zA/xSCUrlV+tk6zh1l/aqXXTD4/7/3sLvbaEn3vDysfzEqW4zUrvjanaHHu s4yz18RN369eUpC4PWrXrN+Fc0rFviqffZ+e7qyv8viRq3a2Nudn84/lOsu+KSy7ype6hnWf lW/WvmmGrRf098YG9fwIefD3QqoSS3FGoqEWc1FxIgBDA8G4OgMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han Reviewed-by: H Hartley Sweeten --- drivers/video/ep93xx-fb.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/video/ep93xx-fb.c b/drivers/video/ep93xx-fb.c index ee1ee54..28a837d 100644 --- a/drivers/video/ep93xx-fb.c +++ b/drivers/video/ep93xx-fb.c @@ -595,7 +595,6 @@ failed_videomem: fb_dealloc_cmap(&info->cmap); failed_cmap: kfree(info); - platform_set_drvdata(pdev, NULL); return err; } @@ -614,7 +613,6 @@ static int ep93xxfb_remove(struct platform_device *pdev) fbi->mach_info->teardown(pdev); kfree(info); - platform_set_drvdata(pdev, NULL); return 0; }