From patchwork Sat May 11 12:48:01 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 2553831 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 9F5993FCA5 for ; Sat, 11 May 2013 12:48:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751954Ab3EKMsE (ORCPT ); Sat, 11 May 2013 08:48:04 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:16544 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751781Ab3EKMsD (ORCPT ); Sat, 11 May 2013 08:48:03 -0400 Received: from epcpsbgr5.samsung.com (u145.gpu120.samsung.co.kr [203.254.230.145]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MMM00KYDWW26H60@mailout3.samsung.com> for linux-fbdev@vger.kernel.org; Sat, 11 May 2013 21:48:02 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.49]) by epcpsbgr5.samsung.com (EPCPMTA) with SMTP id CC.A8.19350.20E3E815; Sat, 11 May 2013 21:48:02 +0900 (KST) X-AuditID: cbfee691-b7fe56d000004b96-cb-518e3e027f7c Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 11.4B.01422.10E3E815; Sat, 11 May 2013 21:48:02 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MMM00D91WW1UG90@mmp1.samsung.com>; Sat, 11 May 2013 21:48:01 +0900 (KST) From: Jingoo Han To: linux-fbdev@vger.kernel.org Cc: 'Florian Tobias Schandinat' , 'Tomi Valkeinen' , Jingoo Han , 'Sascha Hauer' Subject: [PATCH 03/15] video: imxfb: remove unnecessary platform_set_drvdata() Date: Sat, 11 May 2013 21:48:01 +0900 Message-id: <000301ce4e45$c5d95e30$518c1a90$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: Ac5ORby8kD8rd+CxRFyE+r941QAxQg== Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrHIsWRmVeSWpSXmKPExsVy+t8zQ10mu75Ag+lTuCw6Z15jtLi88BKr xaqpO1ksTvR9YLVYP/8WmwOrx4ePcR79fw08+rasYvQ4fmM7k8fnTXIBrFFcNimpOZllqUX6 dglcGSuPX2EqeMRecXxXA3MD4w62LkZODgkBE4kv1z9C2WISF+6tB7K5OIQEljFKTLhygQmm aF/jI2aIxCJGiT+/3jBBOL8YJXqOfABrZxNQk/jy5TA7iC0iIC+xp78drIhZYBOjxP6pDYxd jBwcwgJ+Epvf8IPUsAioSryatQasnlfAUuLK9FtMELagxI/J91hAbGYBLYn1O48zQdjyEpvX vGWGuEhBYsfZ12AjRQT0JLYf04QoEZHY9+IdI8haCYF97BI/Fk9gg9glIPFt8iEWkHoJAVmJ TQegxkhKHFxxg2UCo9gsJJtnIdk8C8nmWUhWLGBkWcUomlqQXFCclF5kqlecmFtcmpeul5yf u4kREncTdzDeP2B9iDEZaP1EZinR5Hxg3OaVxBsamxlZmJqYGhuZW5qRJqwkzqveYh0oJJCe WJKanZpakFoUX1Sak1p8iJGJg1OqgbHgyZvsRaX7AhwUFd6eWJ++3Lw3PW1GZvKqva2vWBgP xdfv8lGp6grZdorn1fmMe1dmrM+PsPCbEfdjwtrTFw+/XP4gXurVJPb3mVoqW75kfLrNdX7K jXcK+aqvPUwDXbISdQ0DGfd8b5ySJ37d9/yzbRl+L9lnWJXxs0w4Zbh45bwLdw7G+p1VYinO SDTUYi4qTgQAG8OjvtECAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprNKsWRmVeSWpSXmKPExsVy+t9jAV0mu75Ag72n2Cw6Z15jtLi88BKr xaqpO1ksTvR9YLVYP/8WmwOrx4ePcR79fw08+rasYvQ4fmM7k8fnTXIBrFENjDYZqYkpqUUK qXnJ+SmZeem2St7B8c7xpmYGhrqGlhbmSgp5ibmptkouPgG6bpk5QLuVFMoSc0qBQgGJxcVK +naYJoSGuOlawDRG6PqGBMH1GBmggYR1jBkrj19hKnjEXnF8VwNzA+MOti5GTg4JAROJfY2P mCFsMYkL99YDxbk4hAQWMUr8+fWGCcL5xSjRc+QDWAebgJrEly+H2UFsEQF5iT397WBFzAKb GCX2T21g7GLk4BAW8JPY/IYfpIZFQFXi1aw1YPW8ApYSV6bfYoKwBSV+TL7HAmIzC2hJrN95 nAnClpfYvOYt1EUKEjvOvgYbKSKgJ7H9mCZEiYjEvhfvGCcwCsxCMmkWkkmzkEyahaRlASPL KkbR1ILkguKk9FwjveLE3OLSvHS95PzcTYzgqH4mvYNxVYPFIUYBDkYlHt4Kod5AIdbEsuLK 3EOMEhzMSiK8zx4AhXhTEiurUovy44tKc1KLDzEmAz06kVlKNDkfmHDySuINjU3MjCyNzCyM TMzNSRNWEuc92GodKCSQnliSmp2aWpBaBLOFiYNTqoGRNUP/ZFTmU9W3N1Of//D4+dFFcT2L hPyba0XNP9Zcvjjr9Dob5u/pD/sY/YXZ5sZUq8eVuDb/CvfdWli97NEboShNIdNLruy1XI4m Psd/5BowWRTf/2fcz8G2rSbhyYZjk68KfZtoFXpt06UrG9Lu7eBrdQ6Sf2ovkfLvSXjUgZyY lptvbqxUYinOSDTUYi4qTgQA694Txi4DAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/video/imxfb.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/drivers/video/imxfb.c b/drivers/video/imxfb.c index 0abf2bf..c1945b3 100644 --- a/drivers/video/imxfb.c +++ b/drivers/video/imxfb.c @@ -923,7 +923,6 @@ failed_getclock: failed_req: kfree(info->pseudo_palette); failed_init: - platform_set_drvdata(pdev, NULL); framebuffer_release(info); return ret; } @@ -955,8 +954,6 @@ static int imxfb_remove(struct platform_device *pdev) iounmap(fbi->regs); release_mem_region(res->start, resource_size(res)); - platform_set_drvdata(pdev, NULL); - return 0; }