From patchwork Sat May 11 12:48:55 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 2553841 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id A45AA3FCA5 for ; Sat, 11 May 2013 12:48:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752226Ab3EKMs5 (ORCPT ); Sat, 11 May 2013 08:48:57 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:29940 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751781Ab3EKMs4 (ORCPT ); Sat, 11 May 2013 08:48:56 -0400 Received: from epcpsbgr4.samsung.com (u144.gpu120.samsung.co.kr [203.254.230.144]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MMM00014WXJ4G70@mailout2.samsung.com> for linux-fbdev@vger.kernel.org; Sat, 11 May 2013 21:48:55 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.47]) by epcpsbgr4.samsung.com (EPCPMTA) with SMTP id A4.14.04074.73E3E815; Sat, 11 May 2013 21:48:55 +0900 (KST) X-AuditID: cbfee690-b7f136d000000fea-7d-518e3e37ba33 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id B7.5B.01422.73E3E815; Sat, 11 May 2013 21:48:55 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MMM00JP3WXJ1A50@mmp2.samsung.com>; Sat, 11 May 2013 21:48:55 +0900 (KST) From: Jingoo Han To: linux-fbdev@vger.kernel.org Cc: 'Florian Tobias Schandinat' , 'Tomi Valkeinen' , Jingoo Han , Lars-Peter Clausen Subject: [PATCH 04/15] video: jz4740: remove unnecessary platform_set_drvdata() Date: Sat, 11 May 2013 21:48:55 +0900 Message-id: <000401ce4e45$e593ed30$b0bbc790$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: Ac5ORdSI0cKjGosmR9eVmhH82QZ77g== Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrPIsWRmVeSWpSXmKPExsVy+t8zfV1zu75Agz/NEhadM68xWlxeeInV Ysnk+awWJ/o+sFqsn3+LzYHV48PHOI8lbw6xevRtWcXocfzGdiaPz5vkAlijuGxSUnMyy1KL 9O0SuDLmrjnFVnCaraL3z0XWBsaDrF2MnBwSAiYStyb9Y4awxSQu3FvP1sXIxSEksIxR4srq OSwwRdf+rYNKTGeU2D9zKwuE84tR4vqrY2wgVWwCahJfvhxmB7FFBOQl9vS3M4HYzAIbGCWe XUsDsYUF/CVaVswDWsfBwSKgKnH2RjBImFfAUuLpvH1sELagxI/J91ggWrUk1u88DjVGXmLz mrdQlypI7Dj7mhFilZ7Ex8PfoGpEJPa9eMcIcpuEwD52iSW728CKWAQEJL5NPsQCsldCQFZi 0wGoOZISB1fcYJnAKDYLyepZSFbPQrJ6FpIVCxhZVjGKphYkFxQnpReZ6BUn5haX5qXrJefn bmKERN6EHYz3DlgfYkwGWj+RWUo0OR8YuXkl8YbGZkYWpiamxkbmlmakCSuJ86q3WAcKCaQn lqRmp6YWpBbFF5XmpBYfYmTi4JRqYJxX+vaTzoFtVVcPK6lmulz4Pr3UZk+s2Z7YjJzCCdl7 Wjs+WO/e9fHZLlYH7W4eySX5zQL/C33/7Zo1yyvTus1v63umaUsYGLbfW7Fu+kn7r35m6oaV P734z9eLFwcdqNS2jXyS/t/h6tOvetVHPplm+53R8amNV9/o9Syp0VdXi+3M5guMNUosxRmJ hlrMRcWJACND3W/SAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprDKsWRmVeSWpSXmKPExsVy+t9jQV1zu75Ag/enRCw6Z15jtLi88BKr xZLJ81ktTvR9YLVYP/8WmwOrx4ePcR5L3hxi9ejbsorR4/iN7UwenzfJBbBGNTDaZKQmpqQW KaTmJeenZOal2yp5B8c7x5uaGRjqGlpamCsp5CXmptoqufgE6Lpl5gAtV1IoS8wpBQoFJBYX K+nbYZoQGuKmawHTGKHrGxIE12NkgAYS1jFmzF1ziq3gNFtF75+LrA2MB1m7GDk5JARMJK79 W8cGYYtJXLi3Hsjm4hASmM4osX/mVhYI5xejxPVXx8Cq2ATUJL58OcwOYosIyEvs6W9nArGZ BTYwSjy7lgZiCwv4S7SsmMfcxcjBwSKgKnH2RjBImFfAUuLpvH1sELagxI/J91ggWrUk1u88 DjVGXmLzmrfMEAcpSOw4+5oRYpWexMfD36BqRCT2vXjHOIFRYBaSUbOQjJqFZNQsJC0LGFlW MYqmFiQXFCel5xrpFSfmFpfmpesl5+duYgTH9TPpHYyrGiwOMQpwMCrx8FYI9QYKsSaWFVfm HmKU4GBWEuF99gAoxJuSWFmVWpQfX1Sak1p8iDEZ6NGJzFKiyfnAlJNXEm9obGJmZGlkZmFk Ym5OmrCSOO/BVutAIYH0xJLU7NTUgtQimC1MHJxSDYwSJ/5usFJumbbpp3nj5JCZkoZzu1Vt 9878WmhcdcAzU2/DsYVHi4qZWaak5k1QLph+8lX0gkXeC+5xWn7/aFxdfTg0+N3yBZ/qllU4 31or827mse8Pf0pPmidmVDzPTuBN0bwN56cF2Hx+m5fiucQ5rSfqi7ZYCw/Pvqu5gi4+eSbv F27r7o5WYinOSDTUYi4qTgQAJVcjyy8DAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/video/jz4740_fb.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/video/jz4740_fb.c b/drivers/video/jz4740_fb.c index 36979b4..2c49112 100644 --- a/drivers/video/jz4740_fb.c +++ b/drivers/video/jz4740_fb.c @@ -737,8 +737,6 @@ static int jzfb_remove(struct platform_device *pdev) fb_dealloc_cmap(&jzfb->fb->cmap); jzfb_free_devmem(jzfb); - platform_set_drvdata(pdev, NULL); - framebuffer_release(jzfb->fb); return 0;