From patchwork Sat May 11 12:51:33 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 2553871 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 5B3873FCA5 for ; Sat, 11 May 2013 12:51:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751990Ab3EKMvf (ORCPT ); Sat, 11 May 2013 08:51:35 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:30074 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751954Ab3EKMve (ORCPT ); Sat, 11 May 2013 08:51:34 -0400 Received: from epcpsbgr5.samsung.com (u145.gpu120.samsung.co.kr [203.254.230.145]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MMM007HUX1XF550@mailout2.samsung.com> for linux-fbdev@vger.kernel.org; Sat, 11 May 2013 21:51:33 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.47]) by epcpsbgr5.samsung.com (EPCPMTA) with SMTP id 41.D8.19350.5DE3E815; Sat, 11 May 2013 21:51:33 +0900 (KST) X-AuditID: cbfee691-b7fe56d000004b96-cf-518e3ed50b83 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 0D.23.08957.5DE3E815; Sat, 11 May 2013 21:51:33 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MMM00F80X1XJV60@mmp1.samsung.com>; Sat, 11 May 2013 21:51:33 +0900 (KST) From: Jingoo Han To: linux-fbdev@vger.kernel.org Cc: 'Florian Tobias Schandinat' , 'Tomi Valkeinen' , Jingoo Han , Russell King Subject: [PATCH 07/15] video: sa1100fb: remove unnecessary platform_set_drvdata() Date: Sat, 11 May 2013 21:51:33 +0900 Message-id: <000701ce4e46$43c31a20$cb494e60$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: Ac5ORiuyZDJhUQF2QwOm5RoWmVzHpA== Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrIIsWRmVeSWpSXmKPExsVy+t8zfd2rdn2BBk/PSVp0zrzGaHF54SVW ixN9H1gtNn94yWaxfv4tNgdWj5bmHjaPDx/jPPq2rGL0OH5jO5PH501yAaxRXDYpqTmZZalF +nYJXBnPbixiLbjGVnHiVAtjA+NJ1i5GTg4JAROJCf8vsUHYYhIX7q0Hsrk4hASWMUq0PpvL CFO09PUFVojEIkaJu/ufMUI4vxglns08BFbFJqAm8eXLYXYQW0RAXmJPfzsTSBGzwDZGicXN k1hAEsICwRI7lk1lArFZBFQlpn5fBbabV8BS4v2Gr0wQtqDEj8n3wOqZBbQk1u88zgRhy0ts XvOWGeIkBYkdZ18zQizTk1g8uQmqXkRi34t3YNdJCBxil5h16CU7xDIBiW+TDwEVcQAlZCU2 HYCaIylxcMUNlgmMYrOQrJ6FZPUsJKtnIVmxgJFlFaNoakFyQXFSepGpXnFibnFpXrpecn7u JkZI9E3cwXj/gPUhxmSg9ROZpUST84HRm1cSb2hsZmRhamJqbGRuaUaasJI4r3qLdaCQQHpi SWp2ampBalF8UWlOavEhRiYOTqkGxnzftLuektIVa9tNpgvbJJwLKWey9T1Vu9Xkathcljlr FjHPyvLva3g6/7CBaOZNb8mDHjeiNxbOdLd7Iyk609+prOiocuPCiF0Pr2k2LFnC+lFd+vX2 8EsVbE9TOzIcd51uCjhQyPPb/02rj//8dduD79011iveH9Iqv5n3aIy3lWYm/6/1SizFGYmG WsxFxYkAK3XV/9QCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprHKsWRmVeSWpSXmKPExsVy+t9jAd2rdn2BBveei1p0zrzGaHF54SVW ixN9H1gtNn94yWaxfv4tNgdWj5bmHjaPDx/jPPq2rGL0OH5jO5PH501yAaxRDYw2GamJKalF Cql5yfkpmXnptkrewfHO8aZmBoa6hpYW5koKeYm5qbZKLj4Bum6ZOUDLlRTKEnNKgUIBicXF Svp2mCaEhrjpWsA0Ruj6hgTB9RgZoIGEdYwZz24sYi24xlZx4lQLYwPjSdYuRk4OCQETiaWv L0DZYhIX7q1n62Lk4hASWMQocXf/M0YI5xejxLOZhxhBqtgE1CS+fDnMDmKLCMhL7OlvZwIp YhbYxiixuHkSC0hCWCBYYseyqUwgNouAqsTU76vYQGxeAUuJ9xu+MkHYghI/Jt8Dq2cW0JJY v/M4E4QtL7F5zVtmiJMUJHacfc0IsUxPYvHkJqh6EYl9L94xTmAUmIVk1Cwko2YhGTULScsC RpZVjKKpBckFxUnpuYZ6xYm5xaV56XrJ+bmbGMGx/UxqB+PKBotDjAIcjEo8vAoCvYFCrIll xZW5hxglOJiVRHifPQAK8aYkVlalFuXHF5XmpBYfYkwG+nQis5Rocj4w7eSVxBsam5gZWRqZ WRiZmJuTJqwkznug1TpQSCA9sSQ1OzW1ILUIZgsTB6dUAyP776iWXduV5Kdwyi8RSeN4eOiY IfeNzF7Oj82TA9cWPZa+3br2p8U67vL23N3dUgoRznIPqr3Ozkh+/GTVyX5vh70VLGtP7lA4 tn0eo4jwobtNYr25y/f/0YlZFbz426GjoivNZ7e0bAl/smYm1/89wUqi2pcdJ/S9bdsq8nDr NIvNAvuTtsspsRRnJBpqMRcVJwIAEhJo8zEDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/video/sa1100fb.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/video/sa1100fb.c b/drivers/video/sa1100fb.c index f34c858..de76da0 100644 --- a/drivers/video/sa1100fb.c +++ b/drivers/video/sa1100fb.c @@ -1271,7 +1271,6 @@ static int sa1100fb_probe(struct platform_device *pdev) failed: if (fbi) iounmap(fbi->base); - platform_set_drvdata(pdev, NULL); kfree(fbi); release_mem_region(res->start, resource_size(res)); return ret;