From patchwork Sat May 11 12:56:06 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 2553911 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id DEA2CDF230 for ; Sat, 11 May 2013 12:56:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751990Ab3EKM4J (ORCPT ); Sat, 11 May 2013 08:56:09 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:30256 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751954Ab3EKM4I (ORCPT ); Sat, 11 May 2013 08:56:08 -0400 Received: from epcpsbgr4.samsung.com (u144.gpu120.samsung.co.kr [203.254.230.144]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MMM0055OX9JS760@mailout2.samsung.com> for linux-fbdev@vger.kernel.org; Sat, 11 May 2013 21:56:07 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.51]) by epcpsbgr4.samsung.com (EPCPMTA) with SMTP id EF.44.04074.7EF3E815; Sat, 11 May 2013 21:56:07 +0900 (KST) X-AuditID: cbfee690-b7f136d000000fea-b0-518e3fe70816 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id CB.83.08957.6EF3E815; Sat, 11 May 2013 21:56:06 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MMM00FISX9IJV60@mmp1.samsung.com>; Sat, 11 May 2013 21:56:06 +0900 (KST) From: Jingoo Han To: linux-fbdev@vger.kernel.org Cc: 'Florian Tobias Schandinat' , 'Tomi Valkeinen' , Jingoo Han , 'Vasily Khoruzhick' Subject: [PATCH 11/15] video: pxa: remove unnecessary platform_set_drvdata() Date: Sat, 11 May 2013 21:56:06 +0900 Message-id: <000b01ce4e46$e6da5a70$b48f0f50$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: Ac5ORsCBoZ4o6A6BTZC25u9BVT8d6A== Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrAIsWRmVeSWpSXmKPExsVy+t8zY93n9n2BBsd2M1m0HnvGaNE58xqj xeWFl1gtTvR9YLVYP/8WmwOrx85Zd9k9PnyM8+jbsorR4/iN7UwenzfJBbBGcdmkpOZklqUW 6dslcGXsXLyUreAxd8W89StZGhi/cHYxcnJICJhILGifyAphi0lcuLeeDcQWEljGKLFtjj5M zZyLxxi7GLmA4osYJeYc+MQE4fxilNjyvA+sg01ATeLLl8PsILaIgLzEnv52sCJmgS2MEh/m HwFbISzgIzFz7zUmEJtFQFXi/P7/LCA2r4ClRNv9K2wQtqDEj8n3wOLMAloS63ceZ4Kw5SU2 r3nLDHGSgsSOs68ZIZbpScx9vguqRkRi34t3YKdKCBxil/jR+oQFYpmAxLfJh4BsDqCErMSm A1BzJCUOrrjBMoFRbBaS1bOQrJ6FZPUsJCsWMLKsYhRNLUguKE5KLzLRK07MLS7NS9dLzs/d xAiJvQk7GO8dsD7EmAy0fiKzlGhyPjB280riDY3NjCxMTUyNjcwtzUgTVhLnVW+xDhQSSE8s Sc1OTS1ILYovKs1JLT7EyMTBKdXAaJGzOp7pp6woozHjbovVr39eZog+c++7onXNBIsy6WeS f5kqW8OEJVQO2/1i0ZxiuvTA1tWObOdeS363W2X6v3SprOmt/tVW2UpfCmvq65OLmLT7bxjl 9r4qm73S2T36UNyj2c+Pz41ueRE0z233grkvnj1wtTrqc/jVs5DS+ZdVSjWOtS45rsRSnJFo qMVcVJwIAOy7m/fTAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprHKsWRmVeSWpSXmKPExsVy+t9jAd1n9n2BBksvW1u0HnvGaNE58xqj xeWFl1gtTvR9YLVYP/8WmwOrx85Zd9k9PnyM8+jbsorR4/iN7UwenzfJBbBGNTDaZKQmpqQW KaTmJeenZOal2yp5B8c7x5uaGRjqGlpamCsp5CXmptoqufgE6Lpl5gAtV1IoS8wpBQoFJBYX K+nbYZoQGuKmawHTGKHrGxIE12NkgAYS1jFm7Fy8lK3gMXfFvPUrWRoYv3B2MXJySAiYSMy5 eIwRwhaTuHBvPVsXIxeHkMAiRok5Bz4xQTi/GCW2PO9jA6liE1CT+PLlMDuILSIgL7Gnvx2s iFlgC6PEh/lHWEESwgI+EjP3XmMCsVkEVCXO7//PAmLzClhKtN2/wgZhC0r8mHwPLM4soCWx fudxJghbXmLzmrfMECcpSOw4+5oRYpmexNznu6BqRCT2vXjHOIFRYBaSUbOQjJqFZNQsJC0L GFlWMYqmFiQXFCel5xrqFSfmFpfmpesl5+duYgTH9jOpHYwrGywOMQpwMCrx8CoI9AYKsSaW FVfmHmKU4GBWEuF99gAoxJuSWFmVWpQfX1Sak1p8iDEZ6NOJzFKiyfnAtJNXEm9obGJmZGlk ZmFkYm5OmrCSOO+BVutAIYH0xJLU7NTUgtQimC1MHJxSDYzFB3saTW4tnuT7y1WWaT2LQk3X jyePBWpmmSnnJJ75XrAknanv3c7Z03KMWw4EiMUUBCydx7N316LKiZ5RP1dwfF5Wdyu088SR W1c3GinpxptZaevK7ZjUdzXhw2mevRsdN0pM3KwS2vqmwFK7OfaHkG7NSY9d9v0LlnHc9llY KR7wx/QZg5sSS3FGoqEWc1FxIgAiN2HgMQMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/video/pxa3xx-gcu.c | 2 -- drivers/video/pxafb.c | 1 - 2 files changed, 0 insertions(+), 3 deletions(-) diff --git a/drivers/video/pxa3xx-gcu.c b/drivers/video/pxa3xx-gcu.c index 97563c5..95c3c4ae 100644 --- a/drivers/video/pxa3xx-gcu.c +++ b/drivers/video/pxa3xx-gcu.c @@ -711,7 +711,6 @@ err_misc_deregister: misc_deregister(&priv->misc_dev); err_free_priv: - platform_set_drvdata(dev, NULL); free_buffers(dev, priv); kfree(priv); return ret; @@ -729,7 +728,6 @@ static int pxa3xx_gcu_remove(struct platform_device *dev) priv->shared, priv->shared_phys); iounmap(priv->mmio_base); release_mem_region(r->start, resource_size(r)); - platform_set_drvdata(dev, NULL); clk_disable(priv->clk); free_buffers(dev, priv); kfree(priv); diff --git a/drivers/video/pxafb.c b/drivers/video/pxafb.c index 580f80c..eca2de4 100644 --- a/drivers/video/pxafb.c +++ b/drivers/video/pxafb.c @@ -2256,7 +2256,6 @@ failed_free_res: release_mem_region(r->start, resource_size(r)); failed_fbi: clk_put(fbi->clk); - platform_set_drvdata(dev, NULL); kfree(fbi); failed: return ret;