From patchwork Sat May 11 12:59:54 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 2553931 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id D5BCFDF230 for ; Sat, 11 May 2013 12:59:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751990Ab3EKM74 (ORCPT ); Sat, 11 May 2013 08:59:56 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:24388 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751954Ab3EKM7z (ORCPT ); Sat, 11 May 2013 08:59:55 -0400 Received: from epcpsbgr5.samsung.com (u145.gpu120.samsung.co.kr [203.254.230.145]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MMM0012XXFU8HA0@mailout4.samsung.com> for linux-fbdev@vger.kernel.org; Sat, 11 May 2013 21:59:54 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.49]) by epcpsbgr5.samsung.com (EPCPMTA) with SMTP id E3.19.19350.AC04E815; Sat, 11 May 2013 21:59:54 +0900 (KST) X-AuditID: cbfee691-b7fe56d000004b96-08-518e40ca4e24 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id DA.B3.08957.AC04E815; Sat, 11 May 2013 21:59:54 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MMM00ISEXFUYE00@mmp1.samsung.com>; Sat, 11 May 2013 21:59:54 +0900 (KST) From: Jingoo Han To: linux-fbdev@vger.kernel.org Cc: 'Florian Tobias Schandinat' , 'Tomi Valkeinen' , Jingoo Han Subject: [PATCH 13/15] video: tmiofb: remove unnecessary platform_set_drvdata() Date: Sat, 11 May 2013 21:59:54 +0900 Message-id: <000d01ce4e47$6e9bc570$4bd35050$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: Ac5ORw2bMc1tBCsPQyGT4VRKuwfchg== Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrGIsWRmVeSWpSXmKPExsVy+t8zQ91TDn2BBmfvGFh0zrzGaHF54SVW ixN9H1gt1s+/xebA4vHhY5xH35ZVjB7Hb2xn8vi8SS6AJYrLJiU1J7MstUjfLoEro/vrBtaC /+wVJ34vZm1gPMvWxcjJISFgInF42iMoW0ziwr31QDYXh5DAMkaJdRsvMXcxcoAVPTpeDxFf xCjRPeEkO4Tzi1Hi+JR5jCDdbAJqEl++HGYHsUUE5CX29LczgRQxC3QwSkzq+wuWEBbwl5i9 Yh7YOhYBVYmtM3aDNfMKWEqsPbqWGcIWlPgx+R4LiM0soCWxfudxJghbXmLzmrfMEKcqSOw4 +5oRYpmexIVjl9kgakQk9r14xwiyWEJgE7vEryXXGCGWCUh8m3yIBeIdWYlNB6DmSEocXHGD ZQKj2Cwkq2chWT0LyepZSFYsYGRZxSiaWpBcUJyUXmSqV5yYW1yal66XnJ+7iRESZxN3MN4/ YH2IMRlo/URmKdHkfGCc5pXEGxqbGVmYmpgaG5lbmpEmrCTOq95iHSgkkJ5YkpqdmlqQWhRf VJqTWnyIkYmDU6qBkXMmZ+fdCK5OX9Fd1QpK7zkufYsqZcur2brh6+nL/7yNav7O5OR/9+uQ ecWMbWxXWWU1nFjCXrDP+GR4MnP5EtON3BuO3prwYVtL32uOvOw4Zq09rQmHcrtztr349FJp 70xrZ3fhfcz8im9vSAdrznwl/V1ZzFQj8vur7ZkZD8X89Hpl/e4dUGIpzkg01GIuKk4EABO7 MKzJAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprMKsWRmVeSWpSXmKPExsVy+t9jAd1TDn2BBneadC06Z15jtLi88BKr xYm+D6wW6+ffYnNg8fjwMc6jb8sqRo/jN7YzeXzeJBfAEtXAaJORmpiSWqSQmpecn5KZl26r 5B0c7xxvamZgqGtoaWGupJCXmJtqq+TiE6DrlpkDtFJJoSwxpxQoFJBYXKykb4dpQmiIm64F TGOErm9IEFyPkQEaSFjHmNH9dQNrwX/2ihO/F7M2MJ5l62Lk4JAQMJF4dLy+i5ETyBSTuHBv PVCYi0NIYBGjRPeEk+wQzi9GieNT5jGCVLEJqEl8+XKYHcQWEZCX2NPfzgRSxCzQwSgxqe8v WEJYwF9i9op5bCA2i4CqxNYZu8GaeQUsJdYeXcsMYQtK/Jh8jwXEZhbQkli/8zgThC0vsXnN W2aIkxQkdpx9zQixTE/iwrHLbBA1IhL7XrxjnMAoMAvJqFlIRs1CMmoWkpYFjCyrGEVTC5IL ipPScw31ihNzi0vz0vWS83M3MYKj+JnUDsaVDRaHGAU4GJV4eBUEegOFWBPLiitzDzFKcDAr ifA+ewAU4k1JrKxKLcqPLyrNSS0+xJgM9OlEZinR5HxggskriTc0NjEzsjQyszAyMTcnTVhJ nPdAq3WgkEB6YklqdmpqQWoRzBYmDk6pBsbYnW5sgtav5Dh90xTCbitZ57Xd2Zba8jpnedqL 40JcLyaEJ3Y12S91O370wDTuo4mL09S3dteWrptXf7L2zle9KRPyn7+Xdfwq2dn4XdduSf9H QQ5xw+ORLHaGdVwqB49FvT0pcHN6xxfNUzcdCt/4ijj9Kg1qYe3fMHdXkD03X+xflgMPpJVY ijMSDbWYi4oTATbOP9AmAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/video/tmiofb.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/drivers/video/tmiofb.c b/drivers/video/tmiofb.c index dc4fb86..deb8733 100644 --- a/drivers/video/tmiofb.c +++ b/drivers/video/tmiofb.c @@ -794,7 +794,6 @@ err_hw_init: cell->disable(dev); err_enable: err_find_mode: - platform_set_drvdata(dev, NULL); free_irq(irq, info); err_request_irq: iounmap(info->screen_base); @@ -823,8 +822,6 @@ static int tmiofb_remove(struct platform_device *dev) if (cell->disable) cell->disable(dev); - platform_set_drvdata(dev, NULL); - free_irq(irq, info); iounmap(info->screen_base);