From patchwork Sat May 11 13:00:43 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 2553941 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id A4774DF230 for ; Sat, 11 May 2013 13:00:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751954Ab3EKNAq (ORCPT ); Sat, 11 May 2013 09:00:46 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:17093 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751069Ab3EKNAp (ORCPT ); Sat, 11 May 2013 09:00:45 -0400 Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MMM0053VXH82H50@mailout3.samsung.com> for linux-fbdev@vger.kernel.org; Sat, 11 May 2013 22:00:44 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.48]) by epcpsbgr1.samsung.com (EPCPMTA) with SMTP id 5C.8E.31024.CF04E815; Sat, 11 May 2013 22:00:44 +0900 (KST) X-AuditID: cbfee68d-b7f016d000007930-34-518e40fc2ae8 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 3E.14.08957.CF04E815; Sat, 11 May 2013 22:00:44 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MMM00JF5XH71A60@mmp2.samsung.com>; Sat, 11 May 2013 22:00:43 +0900 (KST) From: Jingoo Han To: linux-fbdev@vger.kernel.org Cc: 'Florian Tobias Schandinat' , 'Tomi Valkeinen' , Jingoo Han Subject: [PATCH 14/15] video: vga16fb: remove unnecessary platform_set_drvdata() Date: Sat, 11 May 2013 22:00:43 +0900 Message-id: <000e01ce4e47$8bc410d0$a34c3270$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: Ac5OR3hMytzEx5qWQ+6Q28EwicKZzw== Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrKIsWRmVeSWpSXmKPExsVy+t8zA90/Dn2BBr27JC06Z15jtLi88BKr xYm+D6wW6+ffYnNg8fjwMc6jb8sqRo/jN7YzeXzeJBfAEsVlk5Kak1mWWqRvl8CVsX7hDpaC M2wV134eZm9gPMDaxcjJISFgItH78jIbhC0mceHeejBbSGAZo8TeF5kwNYvWTGPsYuQCik9n lLh1tYEdwvnFKDHxfQdYB5uAmsSXL4fZQWwRAXmJPf3tTCBFzAIdjBKT+v6CJYQFAiT+nPwA 1sAioCpxaHYzE4jNK2ApcW7fe2YIW1Dix+R7LCA2s4CWxPqdx5kgbHmJzWveMkOcpCCx4+xr oJM4gJbpSXw8IAxRIiKx78U7sEslBLaxS8zc3soKsUtA4tvkQywg9RICshKbDkCNkZQ4uOIG ywRGsVlINs9CsnkWks2zkKxYwMiyilE0tSC5oDgpvchQrzgxt7g0L10vOT93EyMkynp3MN4+ YH2IMRlo/URmKdHkfGCU5pXEGxqbGVmYmpgaG5lbmpEmrCTOq9ZiHSgkkJ5YkpqdmlqQWhRf VJqTWnyIkYmDU6qB0flm4K+pcev3NZ/8/uPW7b89hUtMyw9sPVVb5zPHvnBtuMzyGbf/fHe9 lPLNbWJ0SZuCtH9Pn2iI1Def65MF2v0fXWItWLwldMWCF0dfySlvf/F+076qYxevN9+VlZ9p vTu14ZHQhNu39/mHW58umi2VnBgoFCn2vejrtTOVaoeuuUw5U8HFdkSJpTgj0VCLuag4EQCS bTA8yAIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprMKsWRmVeSWpSXmKPExsVy+t9jQd0/Dn2BBnPvilp0zrzGaHF54SVW ixN9H1gt1s+/xebA4vHhY5xH35ZVjB7Hb2xn8vi8SS6AJaqB0SYjNTEltUghNS85PyUzL91W yTs43jne1MzAUNfQ0sJcSSEvMTfVVsnFJ0DXLTMHaKWSQlliTilQKCCxuFhJ3w7ThNAQN10L mMYIXd+QILgeIwM0kLCOMWP9wh0sBWfYKq79PMzewHiAtYuRk0NCwERi0ZppjBC2mMSFe+vZ uhi5OIQEpjNK3LrawA7h/GKUmPi+gw2kik1ATeLLl8PsILaIgLzEnv52JpAiZoEORolJfX/B EsICARJ/Tn4Aa2ARUJU4NLuZCcTmFbCUOLfvPTOELSjxY/I9FhCbWUBLYv3O40wQtrzE5jVv mSFOUpDYcfY10HkcQMv0JD4eEIYoEZHY9+Id4wRGgVlIJs1CMmkWkkmzkLQsYGRZxSiaWpBc UJyUnmuoV5yYW1yal66XnJ+7iREcxc+kdjCubLA4xCjAwajEw6sg0BsoxJpYVlyZe4hRgoNZ SYT32QOgEG9KYmVValF+fFFpTmrxIcZkoEcnMkuJJucDE0xeSbyhsYmZkaWRmYWRibk5acJK 4rwHWq0DhQTSE0tSs1NTC1KLYLYwcXBKNTDyay2vT1zYWnYmyipMR/m5zJej9gknamzkHxQf PnntgZOsOuOR2y2XizuLmrizNq+yS0oIYFNd1jpNl4FpXtSXu8dFddTvnrwtFLEuzkf01uMT jUqL3i1Xu6S2h/NUB7/AiUsB02/fmfFj+0OnlV7rpGQW/Xjd+OFA/RbfCSJbnlSf/CWS23lW iaU4I9FQi7moOBEA1AGLgyYDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/video/vga16fb.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/video/vga16fb.c b/drivers/video/vga16fb.c index 545faec..830ded4 100644 --- a/drivers/video/vga16fb.c +++ b/drivers/video/vga16fb.c @@ -1269,7 +1269,6 @@ static void vga16fb_destroy(struct fb_info *info) iounmap(info->screen_base); fb_dealloc_cmap(&info->cmap); /* XXX unshare VGA regions */ - platform_set_drvdata(dev, NULL); framebuffer_release(info); }