From patchwork Sat May 11 13:03:04 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 2553951 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 28A6FDF230 for ; Sat, 11 May 2013 13:03:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752003Ab3EKNDH (ORCPT ); Sat, 11 May 2013 09:03:07 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:30592 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751990Ab3EKNDG (ORCPT ); Sat, 11 May 2013 09:03:06 -0400 Received: from epcpsbgr5.samsung.com (u145.gpu120.samsung.co.kr [203.254.230.145]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MMM005CIXL59E60@mailout2.samsung.com> for linux-fbdev@vger.kernel.org; Sat, 11 May 2013 22:03:05 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.49]) by epcpsbgr5.samsung.com (EPCPMTA) with SMTP id 33.59.19350.9814E815; Sat, 11 May 2013 22:03:05 +0900 (KST) X-AuditID: cbfee691-b7fe56d000004b96-22-518e41891d7d Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 9F.74.08957.8814E815; Sat, 11 May 2013 22:03:05 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MMM00IMBXL4KC70@mmp2.samsung.com>; Sat, 11 May 2013 22:03:04 +0900 (KST) From: Jingoo Han To: linux-fbdev@vger.kernel.org Cc: 'Florian Tobias Schandinat' , 'Tomi Valkeinen' , Jingoo Han , 'Zhou Zhu' , 'Lisa Du' , 'Haojian Zhuang' Subject: [PATCH 15/15] video: mmp: remove unnecessary platform_set_drvdata() Date: Sat, 11 May 2013 22:03:04 +0900 Message-id: <000f01ce4e47$e00c4c70$a024e550$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: Ac5OR5gaSV5x9cSVRqCHRdy7QuS4Pw== Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrPIsWRmVeSWpSXmKPExsVy+t8zQ91Ox75Ag3M32S1e7XnLZNE58xqj xeVzh4HEwkusFif6PrBarJ9/i83iyCpuB3aPDx/jPO5c28PmMXnhRWaPvi2rGD2O39jO5PF5 k1wAWxSXTUpqTmZZapG+XQJXxq0lHUwF7zgrjn3extTAuJSji5GTQ0LAROLP4V3MELaYxIV7 69m6GLk4hASWMUqsuvaSDaZo38OlUInpjBLbT7xkhXB+MUpsuvyXEaSKTUBN4suXw+wgtoiA vMSe/nYmkCJmgR+MEl0tE8ESwgI+EhNm9oLtYxFQlXjV3swCYvMKWEocvrOYGcIWlPgx+R5Y nFlAS2L9zuNMELa8xOY1b6FuVZDYcfY1I8QyPYmVG46wQdSISOx78Y4RZLGEwCV2iRnrT7ND LBOQ+Db5ENBQDqCErMSmA1BzJCUOrrjBMoFRbBaS1bOQrJ6FZPUsJCsWMLKsYhRNLUguKE5K LzLVK07MLS7NS9dLzs/dxAiJzIk7GO8fsD7EmAy0fiKzlGhyPjCy80riDY3NjCxMTUyNjcwt zUgTVhLnVW+xDhQSSE8sSc1OTS1ILYovKs1JLT7EyMTBKdXAuOm8h/kunXtVJ97e8f9b4Jmv Y+9+aof79Kg7k54IPr3ptoNd/4qAab1R07zMwIzVOy/75AXYdAevuLX6ndu6hjXBC9N5bqtO erkwpUWN6bdghPSsRe6P1Evrm+J9bcp23G9+/mWy+aQfFjJN++SePpIsyTAs6ZzXfdH4TBnj h/UNyZb3c1TSlFiKMxINtZiLihMBWEqMaeICAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrDKsWRmVeSWpSXmKPExsVy+t9jQd1Ox75Agwu7mC1e7XnLZNE58xqj xeVzh4HEwkusFif6PrBarJ9/i83iyCpuB3aPDx/jPO5c28PmMXnhRWaPvi2rGD2O39jO5PF5 k1wAW1QDo01GamJKapFCal5yfkpmXrqtkndwvHO8qZmBoa6hpYW5kkJeYm6qrZKLT4CuW2YO 0ClKCmWJOaVAoYDE4mIlfTtME0JD3HQtYBojdH1DguB6jAzQQMI6xoxbSzqYCt5xVhz7vI2p gXEpRxcjJ4eEgInEvodL2SBsMYkL99YD2VwcQgLTGSW2n3jJCuH8YpTYdPkvI0gVm4CaxJcv h9lBbBEBeYk9/e1MIEXMAj8YJbpaJoIlhAV8JCbM7GUGsVkEVCVetTezgNi8ApYSh+8sZoaw BSV+TL4HFmcW0JJYv/M4E4QtL7F5zVtmiJMUJHacfc0IsUxPYuWGI2wQNSIS+168Y5zAKDAL yahZSEbNQjJqFpKWBYwsqxhFUwuSC4qT0nMN9YoTc4tL89L1kvNzNzGC4/6Z1A7GlQ0WhxgF OBiVeHgVBHoDhVgTy4orcw8xSnAwK4nwPnsAFOJNSaysSi3Kjy8qzUktPsSYDPTpRGYp0eR8 YErKK4k3NDYxM7I0MrMwMjE3J01YSZz3QKt1oJBAemJJanZqakFqEcwWJg5OqQbGSs6OY3fE GN02GOxv9O+xLl/w+XidSpuNRBajo3F0rV+/1oJzCod869dM9VJg33NNVF5sZVT5VIPkoom/ Ey1Xfs0/ze/7bp3TOk/OxooHqaUPbrneiqj6vizGb0LvDd6uecEWvz9rrjV55rV6Qu0i3euv n4aFRk6354xoPCLVeiZ9MbepyH0lluKMREMt5qLiRAAb8WGAPwMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/video/mmp/fb/mmpfb.c | 1 - drivers/video/mmp/hw/mmp_ctrl.c | 1 - 2 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/video/mmp/fb/mmpfb.c b/drivers/video/mmp/fb/mmpfb.c index 6d1fa96..4ab95b8 100644 --- a/drivers/video/mmp/fb/mmpfb.c +++ b/drivers/video/mmp/fb/mmpfb.c @@ -659,7 +659,6 @@ failed_destroy_mutex: mutex_destroy(&fbi->access_ok); failed: dev_err(fbi->dev, "mmp-fb: frame buffer device init failed\n"); - platform_set_drvdata(pdev, NULL); framebuffer_release(info); diff --git a/drivers/video/mmp/hw/mmp_ctrl.c b/drivers/video/mmp/hw/mmp_ctrl.c index 4bd31b2..c46bf5a 100644 --- a/drivers/video/mmp/hw/mmp_ctrl.c +++ b/drivers/video/mmp/hw/mmp_ctrl.c @@ -566,7 +566,6 @@ failed: devm_kfree(ctrl->dev, ctrl); } - platform_set_drvdata(pdev, NULL); dev_err(&pdev->dev, "device init failed\n"); return ret;