From patchwork Mon Nov 25 03:19:56 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 3227891 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 668629F3B8 for ; Mon, 25 Nov 2013 03:20:01 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 8FC9620254 for ; Mon, 25 Nov 2013 03:20:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B41D020253 for ; Mon, 25 Nov 2013 03:19:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753301Ab3KYDT7 (ORCPT ); Sun, 24 Nov 2013 22:19:59 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:19886 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753251Ab3KYDT6 (ORCPT ); Sun, 24 Nov 2013 22:19:58 -0500 Received: from epcpsbgr2.samsung.com (u142.gpu120.samsung.co.kr [203.254.230.142]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MWS0063PUL8NS70@mailout4.samsung.com> for linux-fbdev@vger.kernel.org; Mon, 25 Nov 2013 12:19:57 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.51]) by epcpsbgr2.samsung.com (EPCPMTA) with SMTP id 38.E4.18301.CD1C2925; Mon, 25 Nov 2013 12:19:56 +0900 (KST) X-AuditID: cbfee68e-b7f7e6d00000477d-5d-5292c1dcf016 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 15.0C.02580.CD1C2925; Mon, 25 Nov 2013 12:19:56 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MWS00DXTUL8T4H0@mmp1.samsung.com>; Mon, 25 Nov 2013 12:19:56 +0900 (KST) From: Jingoo Han To: 'Jean-Christophe PLAGNIOL-VILLARD' Cc: 'Tomi Valkeinen' , linux-fbdev@vger.kernel.org, 'Jingoo Han' , 'Antonino Daplas' References: <001f01cee985$0b235470$2169fd50$%han@samsung.com> In-reply-to: <001f01cee985$0b235470$2169fd50$%han@samsung.com> Subject: [PATCH 3/4] video: rivafb: remove unnecessary pci_set_drvdata() Date: Mon, 25 Nov 2013 12:19:56 +0900 Message-id: <002101cee98d$3732cde0$a59869a0$%han@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac7phQsIbETGq0sjRtCfpBr3kpLozAACBJmg Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrKIsWRmVeSWpSXmKPExsVy+t8zY907BycFGWzfZG3xs/sLm8XlhZdY LU70fWC1WPfwBZPF+vm32BxYPXbOusvu8erCHRaPvi2rGD2O39jO5PF5k1wAaxSXTUpqTmZZ apG+XQJXxuarL5gLtrFWvJ3Vy97AuJ+li5GDQ0LARKJttloXIyeQKSZx4d56NhBbSGAZo8TJ TaoQcROJnStmAJVzAcUXMUqceb+eEcL5xSjxrG8nWAebgJrEly+H2UFsEQE7iYUXL7GCFDEL TGOUuH/jDzvINiEBW4kna4xBTE6gmk8tuiDlwgIeEv1XZoGNYRFQlfi7soEZxOYFqn54cRqU LSjxY/I9FhCbWUBLYv3O40wQtrzE5jVvmSF+UZd49FcX4gIjicNNrWwQJSIS+168AztZQuAW u8TpI09ZIXYJSHybfAgaDrISmw4wQ/wrKXFwxQ2WCYwSs5BsnoVk8ywkm2chWbGAkWUVo2hq QXJBcVJ6kZFecWJucWleul5yfu4mRkiU9u1gvHnA+hBjMtD6icxSosn5wCjPK4k3NDYzsjA1 MTU2Mrc0I01YSZx30cOkICGB9MSS1OzU1ILUovii0pzU4kOMTBycUg2MDg6nSmYaL+U9u+CA CYNEuhDfjil6Hnd3v/7fdjm3zvhi4ItFq8Nsp7+14XGSaA0+vP3J7glftmWeMojdV3Sjsl3j lFRxy9neVbWWxZN7i66WLDygrdrjGTHh17y6mbMmn0zl5X2ou39fwBU16ZoTjrcPRmk/vPJe 6dx+l4Ap2iGu3wI93665qcRSnJFoqMVcVJwIALN0YrHoAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrCKsWRmVeSWpSXmKPExsVy+t9jAd07BycFGWy/ZW7xs/sLm8XlhZdY LU70fWC1WPfwBZPF+vm32BxYPXbOusvu8erCHRaPvi2rGD2O39jO5PF5k1wAa1QDo01GamJK apFCal5yfkpmXrqtkndwvHO8qZmBoa6hpYW5kkJeYm6qrZKLT4CuW2YO0HYlhbLEnFKgUEBi cbGSvh2mCaEhbroWMI0Rur4hQXA9RgZoIGEdY8bmqy+YC7axVryd1cvewLifpYuRk0NCwERi 54oZULaYxIV769m6GLk4hAQWMUqceb+eEcL5xSjxrG8nG0gVm4CaxJcvh9lBbBEBO4mFFy+x ghQxC0xjlLh/4w9QggOow1biyRpjEJMTqOZTiy5IubCAh0T/lVlgY1gEVCX+rmxgBrF5gaof XpwGZQtK/Jh8D+wgZgEtifU7jzNB2PISm9e8ZQYZKSGgLvHory7EBUYSh5ta2SBKRCT2vXjH OIFRaBaSSbOQTJqFZNIsJC0LGFlWMYqmFiQXFCel5xrqFSfmFpfmpesl5+duYgSngWdSOxhX NlgcYhTgYFTi4bWonBQkxJpYVlyZe4hRgoNZSYR3Tx1QiDclsbIqtSg/vqg0J7X4EGMy0KMT maVEk/OBKSqvJN7Q2MTMyNLIzMLIxNycNGElcd4DrdaBQgLpiSWp2ampBalFMFuYODilGhhD d7CpfS3k3yUcp+vis43DQ3/Rw42mN+74vt61SHrSXq4Xmg7T/37SbEpbuEG+suAw38mCt9Nv pq+L6WoJ11rH+iNn55tnt5aoiJbaftXQX/9l3+Tegw3HT214pjddrMdXVrbY52ZeSvXlKfwZ n4ss9zzgO7ZM480x+Sfv19YcuOT9yLIi1KZFiaU4I9FQi7moOBEAM49fX0cDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/video/riva/fbdev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/riva/fbdev.c b/drivers/video/riva/fbdev.c index a5514ac..8a8d7f0 100644 --- a/drivers/video/riva/fbdev.c +++ b/drivers/video/riva/fbdev.c @@ -2128,7 +2128,6 @@ static void rivafb_remove(struct pci_dev *pd) pci_release_regions(pd); kfree(info->pixmap.addr); framebuffer_release(info); - pci_set_drvdata(pd, NULL); NVTRACE_LEAVE(); }