| Message ID | 005401cea77c$6925eec0$3b71cc40$%han@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 09/02/2013 03:33 AM, Jingoo Han wrote: > Use devm_ioremap_resource() because devm_request_and_ioremap() is > obsoleted by devm_ioremap_resource(). > > Signed-off-by: Jingoo Han <jg1.han@samsung.com> > --- > drivers/video/xilinxfb.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/video/xilinxfb.c b/drivers/video/xilinxfb.c > index 6629b29..ed90051 100644 > --- a/drivers/video/xilinxfb.c > +++ b/drivers/video/xilinxfb.c > @@ -260,9 +260,9 @@ static int xilinxfb_assign(struct platform_device *pdev, > > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > drvdata->regs_phys = res->start; > - drvdata->regs = devm_request_and_ioremap(&pdev->dev, res); > - if (!drvdata->regs) { > - rc = -EADDRNOTAVAIL; > + drvdata->regs = devm_ioremap_resource(&pdev->dev, res); > + if (IS_ERR(drvdata->regs)) { > + rc = PTR_ERR(drvdata->regs); > goto err_region; > } > } > Acked-by: Michal Simek <michal.simek@xilinx.com> Thanks, Michal -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On 02/09/13 04:33, Jingoo Han wrote: > Use devm_ioremap_resource() because devm_request_and_ioremap() is > obsoleted by devm_ioremap_resource(). > > Signed-off-by: Jingoo Han <jg1.han@samsung.com> > --- > drivers/video/xilinxfb.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/video/xilinxfb.c b/drivers/video/xilinxfb.c > index 6629b29..ed90051 100644 > --- a/drivers/video/xilinxfb.c > +++ b/drivers/video/xilinxfb.c > @@ -260,9 +260,9 @@ static int xilinxfb_assign(struct platform_device *pdev, > > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > drvdata->regs_phys = res->start; > - drvdata->regs = devm_request_and_ioremap(&pdev->dev, res); > - if (!drvdata->regs) { > - rc = -EADDRNOTAVAIL; > + drvdata->regs = devm_ioremap_resource(&pdev->dev, res); > + if (IS_ERR(drvdata->regs)) { > + rc = PTR_ERR(drvdata->regs); > goto err_region; > } > } I have already applied a similar patch from Julia Lawall. Tomi
diff --git a/drivers/video/xilinxfb.c b/drivers/video/xilinxfb.c index 6629b29..ed90051 100644 --- a/drivers/video/xilinxfb.c +++ b/drivers/video/xilinxfb.c @@ -260,9 +260,9 @@ static int xilinxfb_assign(struct platform_device *pdev, res = platform_get_resource(pdev, IORESOURCE_MEM, 0); drvdata->regs_phys = res->start; - drvdata->regs = devm_request_and_ioremap(&pdev->dev, res); - if (!drvdata->regs) { - rc = -EADDRNOTAVAIL; + drvdata->regs = devm_ioremap_resource(&pdev->dev, res); + if (IS_ERR(drvdata->regs)) { + rc = PTR_ERR(drvdata->regs); goto err_region; } }
Use devm_ioremap_resource() because devm_request_and_ioremap() is obsoleted by devm_ioremap_resource(). Signed-off-by: Jingoo Han <jg1.han@samsung.com> --- drivers/video/xilinxfb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)