From patchwork Fri Jan 21 11:18:06 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: axel lin X-Patchwork-Id: 494781 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p0LBIJSR005119 for ; Fri, 21 Jan 2011 11:18:20 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754247Ab1AULSS (ORCPT ); Fri, 21 Jan 2011 06:18:18 -0500 Received: from mail-iw0-f174.google.com ([209.85.214.174]:39826 "EHLO mail-iw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754015Ab1AULSS (ORCPT ); Fri, 21 Jan 2011 06:18:18 -0500 Received: by iwn9 with SMTP id 9so1563116iwn.19 for ; Fri, 21 Jan 2011 03:18:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:subject:from:to:cc:content-type:date:message-id :mime-version:x-mailer:content-transfer-encoding; bh=If4e/5c5WWZEddzmsV/MiCYapcOEgVu5wgnT5tjd2xA=; b=kegcGRfPTmGyPaIJ7dJh6BWakJxRDaWzH5vNQObaOEGBJHe1ZoCgfqlcnsl1qVZ/n2 GWFaE8w9YLwKFqnpk7wQ0ZmD3kX8jumalwX1Tx4sXEftSAOwrBO5y1/L8fXk2DMPWOMv d9z/s5sOdaZRA6PVi7rYaZ8lr6x9IUt/F/PDc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:cc:content-type:date:message-id:mime-version :x-mailer:content-transfer-encoding; b=GDpNl6K5Wkl3DxsMmbYq1/QEFPJMD6IMUDBkJzfcfWzWq/V8JXbLriDWPyS8Fp2/qy /FAPJ2wUSL1UXDxV0kDp/GSjdE2e5HV3vJyOtusFZ78hVyiREphX9eeeOcSFO9gCu93Q HWr926usblv0IHwcyfgztn9rJqSsrgPztjP2Q= Received: by 10.231.19.132 with SMTP id a4mr524997ibb.170.1295608696101; Fri, 21 Jan 2011 03:18:16 -0800 (PST) Received: from [218.167.74.81] (218-167-74-81.dynamic.hinet.net [218.167.74.81]) by mx.google.com with ESMTPS id 8sm7753227iba.16.2011.01.21.03.18.10 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 21 Jan 2011 03:18:15 -0800 (PST) Subject: [PATCH] video: pxa168fb: remove a redundant pxa168fb_check_var call From: Axel Lin To: linux-kernel@vger.kernel.org Cc: Lennert Buytenhek , Green Wan , Eric Miao , Marek Vasut , Haojian Zhuang , linux-fbdev@vger.kernel.org, Paul Mundt , Lennert Buytenhek , Green Wan , Eric Miao , Marek Vasut , Haojian Zhuang , linux-fbdev@vger.kernel.org, Paul Mundt Date: Fri, 21 Jan 2011 19:18:06 +0800 Message-ID: <1295608686.3976.9.camel@phoenix> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Fri, 21 Jan 2011 11:18:20 +0000 (UTC) diff --git a/drivers/video/pxa168fb.c b/drivers/video/pxa168fb.c index cea6403..35f61dd 100644 --- a/drivers/video/pxa168fb.c +++ b/drivers/video/pxa168fb.c @@ -701,16 +701,12 @@ static int __devinit pxa168fb_probe(struct platform_device *pdev) */ pxa168fb_init_mode(info, mi); - ret = pxa168fb_check_var(&info->var, info); - if (ret) - goto failed_free_fbmem; - /* * Fill in sane defaults. */ ret = pxa168fb_check_var(&info->var, info); if (ret) - goto failed; + goto failed_free_fbmem; /* * enable controller clock