From patchwork Wed May 18 18:07:18 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: anish X-Patchwork-Id: 794372 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p4II82mc025097 for ; Wed, 18 May 2011 18:08:03 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757115Ab1ERSHz (ORCPT ); Wed, 18 May 2011 14:07:55 -0400 Received: from mail-pv0-f174.google.com ([74.125.83.174]:47284 "EHLO mail-pv0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933401Ab1ERSHW (ORCPT ); Wed, 18 May 2011 14:07:22 -0400 Received: by pvg12 with SMTP id 12so817012pvg.19 for ; Wed, 18 May 2011 11:07:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:subject:from:to:cc:content-type:date:message-id :mime-version:x-mailer:content-transfer-encoding; bh=mvey2H0CjqwEoFmRJyP7uDW8vSEidLthYj+Th7flbPo=; b=jliEfZFUJHjSa/rHUEnidg5NQEftUN6Ch+FYKTYhh901oLkI8hti1iiwaMtJDQrbXF Kj03jhlrHmx8USHVVBL16nLhFscD2VAy2zoPSFZmgt+P9SqoUJ2msOC4F5J2qzECbMPh uPd03UrV1Au1nfqMwyj5+0tRe3D0BSh+7BuqA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:cc:content-type:date:message-id:mime-version :x-mailer:content-transfer-encoding; b=TPp4IlS2C74rn97yF8jReEcqi0tRD2TBtW7HgFLkR43vgvGxT/Ae3U27LKSWeEXFDj 4/dsqHFN2KdYn0/CuMT2vOAkk5yaHmGyUV3Ja8rCSWJvxwEwoHBvK0768UwAP/Ma2uNJ DrnadUHGAIDs6uYWQ5+YKgqW6o4Cb0z2Lc16Q= Received: by 10.142.213.15 with SMTP id l15mr1071479wfg.394.1305742041870; Wed, 18 May 2011 11:07:21 -0700 (PDT) Received: from [192.168.0.196] ([123.238.81.37]) by mx.google.com with ESMTPS id e7sm1197297pbn.24.2011.05.18.11.07.18 (version=SSLv3 cipher=OTHER); Wed, 18 May 2011 11:07:20 -0700 (PDT) Subject: [patch 2/2] trivial: amba-clcd.c changed the printk to pr_err From: anish To: linux@arm.linux.org.uk, lethal@linux-sh.org Cc: linux-fbdev@vger.kernel.org Date: Wed, 18 May 2011 23:37:18 +0530 Message-ID: <1305742038.8771.27.camel@anish-desktop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Wed, 18 May 2011 18:08:03 +0000 (UTC) As suggested by russell,printk in the fail scenario is an error and should be reported at error severity.They cause things to stop working and so they are not just a warning so changed to pr_err. Signed-off-by: anish kumar --- drivers/video/amba-clcd.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/amba-clcd.c b/drivers/video/amba-clcd.c index 5fc983c..9f27c71 100644 --- a/drivers/video/amba-clcd.c +++ b/drivers/video/amba-clcd.c @@ -545,13 +545,13 @@ static int clcdfb_probe(struct amba_device *dev, const struct amba_id *id) ret = amba_request_regions(dev, NULL); if (ret) { - printk(KERN_ERR "CLCD: unable to reserve regs region\n"); + pr_err("CLCD: unable to reserve regs region\n"); goto out; } fb = kzalloc(sizeof(struct clcd_fb), GFP_KERNEL); if (!fb) { - printk(KERN_INFO "CLCD: could not allocate new clcd_fb struct\n"); + pr_err("CLCD: could not allocate new clcd_fb struct\n"); ret = -ENOMEM; goto free_region; }